* [PATCH v2] OvmfPkg: Fix VS toolchain build failure
@ 2016-09-22 1:21 Dandan Bi
2016-09-22 1:37 ` Laszlo Ersek
0 siblings, 1 reply; 4+ messages in thread
From: Dandan Bi @ 2016-09-22 1:21 UTC (permalink / raw)
To: edk2-devel; +Cc: Jordan Justen, Laszlo Ersek, Liming Gao
V2: add the assert codes.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
OvmfPkg/VirtioGpuDxe/Commands.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/OvmfPkg/VirtioGpuDxe/Commands.c b/OvmfPkg/VirtioGpuDxe/Commands.c
index b369dc3..962087c 100644
--- a/OvmfPkg/VirtioGpuDxe/Commands.c
+++ b/OvmfPkg/VirtioGpuDxe/Commands.c
@@ -282,16 +282,17 @@ VirtioGpuSendCommand (
}
Header->CtxId = 0;
Header->Padding = 0;
ASSERT (RequestSize >= sizeof *Header);
+ ASSERT (RequestSize <= MAX_UINT32);
//
// Compose the descriptor chain.
//
VirtioPrepare (&VgpuDev->Ring, &Indices);
- VirtioAppendDesc (&VgpuDev->Ring, (UINTN)Header, RequestSize,
+ VirtioAppendDesc (&VgpuDev->Ring, (UINTN)Header, (UINT32)RequestSize,
VRING_DESC_F_NEXT, &Indices);
VirtioAppendDesc (&VgpuDev->Ring, (UINTN)&Response, sizeof Response,
VRING_DESC_F_WRITE, &Indices);
//
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] OvmfPkg: Fix VS toolchain build failure
2016-09-22 1:21 [PATCH v2] OvmfPkg: Fix VS toolchain build failure Dandan Bi
@ 2016-09-22 1:37 ` Laszlo Ersek
2016-09-22 1:38 ` Laszlo Ersek
0 siblings, 1 reply; 4+ messages in thread
From: Laszlo Ersek @ 2016-09-22 1:37 UTC (permalink / raw)
To: Dandan Bi, edk2-devel; +Cc: Jordan Justen, Liming Gao
On 09/22/16 03:21, Dandan Bi wrote:
> V2: add the assert codes.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> OvmfPkg/VirtioGpuDxe/Commands.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/VirtioGpuDxe/Commands.c b/OvmfPkg/VirtioGpuDxe/Commands.c
> index b369dc3..962087c 100644
> --- a/OvmfPkg/VirtioGpuDxe/Commands.c
> +++ b/OvmfPkg/VirtioGpuDxe/Commands.c
> @@ -282,16 +282,17 @@ VirtioGpuSendCommand (
> }
> Header->CtxId = 0;
> Header->Padding = 0;
>
> ASSERT (RequestSize >= sizeof *Header);
> + ASSERT (RequestSize <= MAX_UINT32);
>
> //
> // Compose the descriptor chain.
> //
> VirtioPrepare (&VgpuDev->Ring, &Indices);
> - VirtioAppendDesc (&VgpuDev->Ring, (UINTN)Header, RequestSize,
> + VirtioAppendDesc (&VgpuDev->Ring, (UINTN)Header, (UINT32)RequestSize,
> VRING_DESC_F_NEXT, &Indices);
> VirtioAppendDesc (&VgpuDev->Ring, (UINTN)&Response, sizeof Response,
> VRING_DESC_F_WRITE, &Indices);
>
> //
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] OvmfPkg: Fix VS toolchain build failure
2016-09-22 1:37 ` Laszlo Ersek
@ 2016-09-22 1:38 ` Laszlo Ersek
2016-09-22 2:33 ` Laszlo Ersek
0 siblings, 1 reply; 4+ messages in thread
From: Laszlo Ersek @ 2016-09-22 1:38 UTC (permalink / raw)
To: Dandan Bi, edk2-devel; +Cc: Jordan Justen, Liming Gao
On 09/22/16 03:37, Laszlo Ersek wrote:
> On 09/22/16 03:21, Dandan Bi wrote:
>> V2: add the assert codes.
>>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>> ---
>> OvmfPkg/VirtioGpuDxe/Commands.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/OvmfPkg/VirtioGpuDxe/Commands.c b/OvmfPkg/VirtioGpuDxe/Commands.c
>> index b369dc3..962087c 100644
>> --- a/OvmfPkg/VirtioGpuDxe/Commands.c
>> +++ b/OvmfPkg/VirtioGpuDxe/Commands.c
>> @@ -282,16 +282,17 @@ VirtioGpuSendCommand (
>> }
>> Header->CtxId = 0;
>> Header->Padding = 0;
>>
>> ASSERT (RequestSize >= sizeof *Header);
>> + ASSERT (RequestSize <= MAX_UINT32);
>>
>> //
>> // Compose the descriptor chain.
>> //
>> VirtioPrepare (&VgpuDev->Ring, &Indices);
>> - VirtioAppendDesc (&VgpuDev->Ring, (UINTN)Header, RequestSize,
>> + VirtioAppendDesc (&VgpuDev->Ring, (UINTN)Header, (UINT32)RequestSize,
>> VRING_DESC_F_NEXT, &Indices);
>> VirtioAppendDesc (&VgpuDev->Ring, (UINTN)&Response, sizeof Response,
>> VRING_DESC_F_WRITE, &Indices);
>>
>> //
>>
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
Before you commit the patch, can you please change the subject line like
this:
OvmfPkg/VirtioGpuDxe: Fix VS toolchain build failure
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] OvmfPkg: Fix VS toolchain build failure
2016-09-22 1:38 ` Laszlo Ersek
@ 2016-09-22 2:33 ` Laszlo Ersek
0 siblings, 0 replies; 4+ messages in thread
From: Laszlo Ersek @ 2016-09-22 2:33 UTC (permalink / raw)
To: Dandan Bi, edk2-devel; +Cc: Jordan Justen, Liming Gao
On 09/22/16 03:38, Laszlo Ersek wrote:
> On 09/22/16 03:37, Laszlo Ersek wrote:
>> On 09/22/16 03:21, Dandan Bi wrote:
>>> V2: add the assert codes.
>>>
>>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Liming Gao <liming.gao@intel.com>
>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>>> ---
>>> OvmfPkg/VirtioGpuDxe/Commands.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/OvmfPkg/VirtioGpuDxe/Commands.c b/OvmfPkg/VirtioGpuDxe/Commands.c
>>> index b369dc3..962087c 100644
>>> --- a/OvmfPkg/VirtioGpuDxe/Commands.c
>>> +++ b/OvmfPkg/VirtioGpuDxe/Commands.c
>>> @@ -282,16 +282,17 @@ VirtioGpuSendCommand (
>>> }
>>> Header->CtxId = 0;
>>> Header->Padding = 0;
>>>
>>> ASSERT (RequestSize >= sizeof *Header);
>>> + ASSERT (RequestSize <= MAX_UINT32);
>>>
>>> //
>>> // Compose the descriptor chain.
>>> //
>>> VirtioPrepare (&VgpuDev->Ring, &Indices);
>>> - VirtioAppendDesc (&VgpuDev->Ring, (UINTN)Header, RequestSize,
>>> + VirtioAppendDesc (&VgpuDev->Ring, (UINTN)Header, (UINT32)RequestSize,
>>> VRING_DESC_F_NEXT, &Indices);
>>> VirtioAppendDesc (&VgpuDev->Ring, (UINTN)&Response, sizeof Response,
>>> VRING_DESC_F_WRITE, &Indices);
>>>
>>> //
>>>
>>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>
>
> Before you commit the patch, can you please change the subject line like
> this:
>
> OvmfPkg/VirtioGpuDxe: Fix VS toolchain build failure
I just realized you may not have commit rights. I committed this patch
for you: 7f1bf51bdbca.
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-22 2:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-22 1:21 [PATCH v2] OvmfPkg: Fix VS toolchain build failure Dandan Bi
2016-09-22 1:37 ` Laszlo Ersek
2016-09-22 1:38 ` Laszlo Ersek
2016-09-22 2:33 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox