From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by mx.groups.io with SMTP id smtpd.web10.330.1570566467826338378
 for <devel@edk2.groups.io>;
 Tue, 08 Oct 2019 13:27:47 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 6A65230013A1;
	Tue,  8 Oct 2019 20:27:47 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-109.rdu2.redhat.com [10.10.120.109])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 896415D9CD;
	Tue,  8 Oct 2019 20:27:43 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 2/4] OvmfPkg/OvmfXen.dsc: remove PcdCpu* dynamic defaults
To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@redhat.com>,
 devel@edk2.groups.io
Cc: Anthony Perard <anthony.perard@citrix.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 Igor Mammedov <imammedo@redhat.com>,
 Jordan Justen <jordan.l.justen@intel.com>,
 Julien Grall <julien.grall@arm.com>
References: <20191008112714.6215-1-lersek@redhat.com>
 <20191008112714.6215-3-lersek@redhat.com>
 <e97563df-c966-24be-2260-b6ab37f49a20@redhat.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <3296b5aa-f47d-e14d-3486-22d37d6a9cec@redhat.com>
Date: Tue, 8 Oct 2019 22:27:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <e97563df-c966-24be-2260-b6ab37f49a20@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Tue, 08 Oct 2019 20:27:47 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 10/08/19 15:11, Philippe Mathieu-Daud=C3=A9 wrote:
> On 10/8/19 1:27 PM, Laszlo Ersek wrote:
>> PcdCpuMaxLogicalProcessorNumber and PcdCpuApInitTimeOutInMicroSeconds =
are
>> only referenced in "OvmfPkg/PlatformPei/PlatformPei.inf", and OvmfXen
>> does
>> not include that module. Remove the unnecessary dynamic PCD defaults f=
rom
>> "OvmfXen.dsc".
>>
>> Cc: Anthony Perard <anthony.perard@citrix.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Igor Mammedov <imammedo@redhat.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Julien Grall <julien.grall@arm.com>
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1515
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>> =C2=A0 OvmfPkg/OvmfXen.dsc | 4 ----
>> =C2=A0 1 file changed, 4 deletions(-)
>>
>> diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
>> index 5a31f75f05d0..6deafea034c0 100644
>> --- a/OvmfPkg/OvmfXen.dsc
>> +++ b/OvmfPkg/OvmfXen.dsc
>> @@ -481,10 +481,6 @@ [PcdsDynamicDefault]
>> =C2=A0=C2=A0=C2=A0 gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|FAL=
SE
>> =C2=A0=C2=A0=C2=A0 gEfiMdeModulePkgTokenSpaceGuid.PcdPropertiesTableEn=
able|FALSE
>> =C2=A0 -=C2=A0 # UefiCpuPkg PCDs related to initial AP bringup and gen=
eral AP
>> management.
>> -=C2=A0 gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber|64
>> -=C2=A0 gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds|50=
000
>> -
>> =C2=A0=C2=A0=C2=A0 # Set memory encryption mask
>> =C2=A0=C2=A0=C2=A0
>> gEfiMdeModulePkgTokenSpaceGuid.PcdPteMemoryEncryptionAddressOrMask|0x0
>> =C2=A0
>=20
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

Thanks!