Re: [edk2-devel] [Patch v4 19/22] .pytool: Add CISettings.py and Readme.md

[rebecca@bsdio.com]

On 11/6/19 6:13 PM, Michael D Kinney wrote:

> +# Copyright (c) 2018, Microsoft Corporation

Should probably be 2019.

> +    # ####################################################################################### #
> +    #                             Extra CmdLine configuration                                 #
> +    # ####################################################################################### #
> +
> +    def AddCommandLineOptions(self, parserObj):
> +        pass

The comment blocks don't seem very Pythonic.

> +## Background
> +
> +While a number of CI solutions exist, this proposal will focus on the usage of
> +Azure Dev Ops and Build Pipelines. For demonstration, a sample
> +[TianoCore repo](https://github.com/tianocore/edk2-staging.git) (branch master)
> +and [Dev Ops Pipeline](https://dev.azure.com/tianocore/edk2-ci-play/_build?definitionId=14)
> +have been set up.

Since this is no longer a proposal, should we update this text?

> +Inspection of these files reveals the EDKII Tools commands that make up the
> +primary processes for the CI build: 'stuart_setup', 'stuart_update', and
> +'stuart_ci_build'. These commands come from the EDKII Tools PIP modules and are
> +configured as described below. More documentation on the stuart tools can be
> +found [here](https://github.com/tianocore/edk2-pytool-extensions/blob/master/docs/using.md)
> +and [here](https://github.com/tianocore/edk2-pytool-extensions/blob/master/docs/features/feature_invocables.md).

What's the relevance of "stuart"?


-- 
Rebecca Cran