From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from muon.bsdio.com (muon.bsdio.com [65.103.231.193]) by mx.groups.io with SMTP id smtpd.web10.6429.1573143371172633947 for ; Thu, 07 Nov 2019 08:16:11 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=temperror, err=temporary DNS error (domain: bsdio.com, ip: 65.103.231.193, mailfrom: rebecca@bsdio.com) Received: from muon.bsdio.com (localhost [127.0.0.1]) by muon.bsdio.com (Postfix) with ESMTP id 7A02B9C55; Thu, 7 Nov 2019 09:18:50 -0700 (MST) Received: from muon.bsdio.com ([127.0.0.1]) by muon.bsdio.com (muon.bsdio.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id BkswZUN-Ro1V; Thu, 7 Nov 2019 09:18:49 -0700 (MST) Received: from [10.0.10.115] (unknown [10.0.10.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by muon.bsdio.com (Postfix) with ESMTPSA; Thu, 7 Nov 2019 09:18:49 -0700 (MST) Subject: Re: [edk2-devel] [Patch v4 19/22] .pytool: Add CISettings.py and Readme.md To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Sean Brogan , Bret Barkelew , Liming Gao References: <20191107011349.16524-1-michael.d.kinney@intel.com> <20191107011349.16524-20-michael.d.kinney@intel.com> From: rebecca@bsdio.com Message-ID: <32a78ab8-f333-796b-48ec-3ccdf0b0292b@bsdio.com> Date: Thu, 7 Nov 2019 09:16:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191107011349.16524-20-michael.d.kinney@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 11/6/19 6:13 PM, Michael D Kinney wrote: > +# Copyright (c) 2018, Microsoft Corporation Should probably be 2019. > + # ####################################################################################### # > + # Extra CmdLine configuration # > + # ####################################################################################### # > + > + def AddCommandLineOptions(self, parserObj): > + pass The comment blocks don't seem very Pythonic. > +## Background > + > +While a number of CI solutions exist, this proposal will focus on the usage of > +Azure Dev Ops and Build Pipelines. For demonstration, a sample > +[TianoCore repo](https://github.com/tianocore/edk2-staging.git) (branch master) > +and [Dev Ops Pipeline](https://dev.azure.com/tianocore/edk2-ci-play/_build?definitionId=14) > +have been set up. Since this is no longer a proposal, should we update this text? > +Inspection of these files reveals the EDKII Tools commands that make up the > +primary processes for the CI build: 'stuart_setup', 'stuart_update', and > +'stuart_ci_build'. These commands come from the EDKII Tools PIP modules and are > +configured as described below. More documentation on the stuart tools can be > +found [here](https://github.com/tianocore/edk2-pytool-extensions/blob/master/docs/using.md) > +and [here](https://github.com/tianocore/edk2-pytool-extensions/blob/master/docs/features/feature_invocables.md). What's the relevance of "stuart"? -- Rebecca Cran