From: Laszlo Ersek <lersek@redhat.com>
To: Jordan Justen <jordan.l.justen@intel.com>, Andrew Fish <afish@apple.com>
Cc: Mike Kinney <michael.d.kinney@intel.com>,
edk2-devel-01 <edk2-devel@ml01.01.org>,
"Gao, Liming" <liming.gao@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files
Date: Sat, 22 Oct 2016 00:31:26 +0200 [thread overview]
Message-ID: <32ac0268-7b31-5a41-358a-b876ad6ae8cd@redhat.com> (raw)
In-Reply-To: <147708782254.15094.11260195572460159641@jljusten-ivb>
On 10/22/16 00:10, Jordan Justen wrote:
> On 2016-10-21 14:02:44, Laszlo Ersek wrote:
>> Honestly, I imagined that DISABLE_NEW_DEPRECATED_INTERFACES would be
>> temporary in the edk2 tree. That is, it's a means so we can gradually
>> transition with all the in-tree stuff to a deprecationless code base.
>> Once that's done -- i.e., *all* platform DSCs within the edk2 tree
>> specify this feature test macro under their respective [BuildOptions]
>> sections --, then whatever the macro excises from the core packages can
>> be removed permanently, together with those platform [BuildOptions].
>>
>
> That could be reasonable, although I'd argue that we could flip it
> around. Opt-in to the deprecated interfaces on all platforms, and then
> start marking deprecated interfaces. Finally we could clean up
> platforms and removed the override.
That's a valid idea, IMO.
> But ... I think DISABLE_NEW_DEPRECATED_INTERFACES was first added in:
>
> commit bf4a3dbd4751b6411bdfc98bf3ac2c4f928bdfdf
> Author: ydong10 <ydong10@6f19259b-4bc3-4df7-8a09-765794883524>
> Date: Wed May 30 07:36:00 2012 +0000
>
> So, I guess it is not going to be removed anytime soon. :(
I believe we just need to make progress with the individual platforms
(and their dependencies from other Pkgs). It's not a lot of fun, but the
BZs exist (well, they can be filed) now, and then we can address them...
I mean, I didn't care (or, really, know) about
DISABLE_NEW_DEPRECATED_INTERFACES until the ArmVirtPkg / OvmfPkg BZs got
filed. Bugzilla is great. I like the attention that it gets, from others
and from myself.
Thanks
Laszlo
next prev parent reply other threads:[~2016-10-21 22:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-164-63@https.bugzilla.tianocore.org/>
[not found] ` <bug-164-63-L8k0GFC2io@https.bugzilla.tianocore.org/>
2016-10-21 19:37 ` [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files Ard Biesheuvel
2016-10-21 19:41 ` Michael Zimmermann
2016-10-21 19:58 ` Jordan Justen
2016-10-21 20:14 ` Laszlo Ersek
2016-10-21 20:19 ` Ard Biesheuvel
2016-10-21 20:40 ` Laszlo Ersek
2016-10-21 20:57 ` Ard Biesheuvel
2016-10-21 20:20 ` Andrew Fish
2016-10-21 20:39 ` Jordan Justen
2016-10-21 20:54 ` Andrew Fish
2016-10-21 20:55 ` Andrew Fish
2016-10-21 21:02 ` Laszlo Ersek
2016-10-21 22:10 ` Jordan Justen
2016-10-21 22:31 ` Laszlo Ersek [this message]
2016-10-21 23:13 ` Yao, Jiewen
2016-10-23 14:28 ` Mudusuru, Giri P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32ac0268-7b31-5a41-358a-b876ad6ae8cd@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox