public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Jiaxin Wu <jiaxin.wu@intel.com>, edk2-devel@ml01.01.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Ye Ting <ting.ye@intel.com>,
	Fu Siyuan <siyuan.fu@intel.com>
Subject: Re: [Patch] NetworkPkg/HttpBootDxe: Declare the functions as EFIAPI to pass the GCC build
Date: Thu, 16 Feb 2017 10:58:20 +0100	[thread overview]
Message-ID: <32c59d64-9bb1-5f0d-3ebc-9dd645226564@redhat.com> (raw)
In-Reply-To: <1487207966-42416-1-git-send-email-jiaxin.wu@intel.com>

On 02/16/17 02:19, Jiaxin Wu wrote:
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  NetworkPkg/HttpBootDxe/HttpBootSupport.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Build-tested-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo

> 
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.c b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> index d786d72..e831df9 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> @@ -629,10 +629,11 @@ HttpBootSetHeader (
>  
>    @param[in]  Context         The opaque parameter to the function.
>  
>  **/
>  VOID
> +EFIAPI
>  HttpIoNotifyDpc (
>    IN VOID                *Context
>    )
>  {
>    *((BOOLEAN *) Context) = TRUE;
> @@ -644,10 +645,11 @@ HttpIoNotifyDpc (
>    @param[in]  Event                 The event signaled.
>    @param[in]  Context               The opaque parameter to the function.
>  
>  **/
>  VOID
> +EFIAPI
>  HttpIoNotify (
>    IN EFI_EVENT              Event,
>    IN VOID                   *Context
>    )
>  {
> 



  reply	other threads:[~2017-02-16  9:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16  1:19 [Patch] NetworkPkg/HttpBootDxe: Declare the functions as EFIAPI to pass the GCC build Jiaxin Wu
2017-02-16  9:58 ` Laszlo Ersek [this message]
2017-02-16 14:40   ` Wu, Jiaxin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32c59d64-9bb1-5f0d-3ebc-9dd645226564@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox