* [Patch] NetworkPkg/HttpBootDxe: Declare the functions as EFIAPI to pass the GCC build
@ 2017-02-16 1:19 Jiaxin Wu
2017-02-16 9:58 ` Laszlo Ersek
0 siblings, 1 reply; 3+ messages in thread
From: Jiaxin Wu @ 2017-02-16 1:19 UTC (permalink / raw)
To: edk2-devel; +Cc: Laszlo Ersek, Gerd Hoffmann, Ye Ting, Fu Siyuan, Wu Jiaxin
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
NetworkPkg/HttpBootDxe/HttpBootSupport.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.c b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
index d786d72..e831df9 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootSupport.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
@@ -629,10 +629,11 @@ HttpBootSetHeader (
@param[in] Context The opaque parameter to the function.
**/
VOID
+EFIAPI
HttpIoNotifyDpc (
IN VOID *Context
)
{
*((BOOLEAN *) Context) = TRUE;
@@ -644,10 +645,11 @@ HttpIoNotifyDpc (
@param[in] Event The event signaled.
@param[in] Context The opaque parameter to the function.
**/
VOID
+EFIAPI
HttpIoNotify (
IN EFI_EVENT Event,
IN VOID *Context
)
{
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch] NetworkPkg/HttpBootDxe: Declare the functions as EFIAPI to pass the GCC build
2017-02-16 1:19 [Patch] NetworkPkg/HttpBootDxe: Declare the functions as EFIAPI to pass the GCC build Jiaxin Wu
@ 2017-02-16 9:58 ` Laszlo Ersek
2017-02-16 14:40 ` Wu, Jiaxin
0 siblings, 1 reply; 3+ messages in thread
From: Laszlo Ersek @ 2017-02-16 9:58 UTC (permalink / raw)
To: Jiaxin Wu, edk2-devel; +Cc: Gerd Hoffmann, Ye Ting, Fu Siyuan
On 02/16/17 02:19, Jiaxin Wu wrote:
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
> NetworkPkg/HttpBootDxe/HttpBootSupport.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Build-tested-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
>
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.c b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> index d786d72..e831df9 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> @@ -629,10 +629,11 @@ HttpBootSetHeader (
>
> @param[in] Context The opaque parameter to the function.
>
> **/
> VOID
> +EFIAPI
> HttpIoNotifyDpc (
> IN VOID *Context
> )
> {
> *((BOOLEAN *) Context) = TRUE;
> @@ -644,10 +645,11 @@ HttpIoNotifyDpc (
> @param[in] Event The event signaled.
> @param[in] Context The opaque parameter to the function.
>
> **/
> VOID
> +EFIAPI
> HttpIoNotify (
> IN EFI_EVENT Event,
> IN VOID *Context
> )
> {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] NetworkPkg/HttpBootDxe: Declare the functions as EFIAPI to pass the GCC build
2017-02-16 9:58 ` Laszlo Ersek
@ 2017-02-16 14:40 ` Wu, Jiaxin
0 siblings, 0 replies; 3+ messages in thread
From: Wu, Jiaxin @ 2017-02-16 14:40 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel@ml01.01.org; +Cc: Gerd Hoffmann, Ye, Ting, Fu, Siyuan
Commit:
https://github.com/tianocore/edk2/commit/6c6452c6e23a89be0e565501500e83c136e3fcbd
Thanks,
Jiaxin
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Thursday, February 16, 2017 5:58 PM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel@ml01.01.org
> Cc: Gerd Hoffmann <kraxel@redhat.com>; Ye, Ting <ting.ye@intel.com>; Fu,
> Siyuan <siyuan.fu@intel.com>
> Subject: Re: [Patch] NetworkPkg/HttpBootDxe: Declare the functions as
> EFIAPI to pass the GCC build
>
> On 02/16/17 02:19, Jiaxin Wu wrote:
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Ye Ting <ting.ye@intel.com>
> > Cc: Fu Siyuan <siyuan.fu@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> > ---
> > NetworkPkg/HttpBootDxe/HttpBootSupport.c | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Build-tested-by: Laszlo Ersek <lersek@redhat.com>
>
> Thanks!
> Laszlo
>
> >
> > diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> > index d786d72..e831df9 100644
> > --- a/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> > +++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> > @@ -629,10 +629,11 @@ HttpBootSetHeader (
> >
> > @param[in] Context The opaque parameter to the function.
> >
> > **/
> > VOID
> > +EFIAPI
> > HttpIoNotifyDpc (
> > IN VOID *Context
> > )
> > {
> > *((BOOLEAN *) Context) = TRUE;
> > @@ -644,10 +645,11 @@ HttpIoNotifyDpc (
> > @param[in] Event The event signaled.
> > @param[in] Context The opaque parameter to the function.
> >
> > **/
> > VOID
> > +EFIAPI
> > HttpIoNotify (
> > IN EFI_EVENT Event,
> > IN VOID *Context
> > )
> > {
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-16 14:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-16 1:19 [Patch] NetworkPkg/HttpBootDxe: Declare the functions as EFIAPI to pass the GCC build Jiaxin Wu
2017-02-16 9:58 ` Laszlo Ersek
2017-02-16 14:40 ` Wu, Jiaxin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox