From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 50ED0820F7
 for <edk2-devel@ml01.01.org>; Thu, 16 Feb 2017 01:58:23 -0800 (PST)
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
 (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id D03FD3A7694;
 Thu, 16 Feb 2017 09:58:23 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-72.phx2.redhat.com
 [10.3.116.72])
 by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 v1G9wMUc012541; Thu, 16 Feb 2017 04:58:22 -0500
To: Jiaxin Wu <jiaxin.wu@intel.com>, edk2-devel@ml01.01.org
References: <1487207966-42416-1-git-send-email-jiaxin.wu@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, Ye Ting <ting.ye@intel.com>,
 Fu Siyuan <siyuan.fu@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <32c59d64-9bb1-5f0d-3ebc-9dd645226564@redhat.com>
Date: Thu, 16 Feb 2017 10:58:20 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <1487207966-42416-1-git-send-email-jiaxin.wu@intel.com>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.29]); Thu, 16 Feb 2017 09:58:23 +0000 (UTC)
Subject: Re: [Patch] NetworkPkg/HttpBootDxe: Declare the functions as EFIAPI to pass the GCC build
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Feb 2017 09:58:23 -0000
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 02/16/17 02:19, Jiaxin Wu wrote:
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  NetworkPkg/HttpBootDxe/HttpBootSupport.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Build-tested-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo

> 
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.c b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> index d786d72..e831df9 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> @@ -629,10 +629,11 @@ HttpBootSetHeader (
>  
>    @param[in]  Context         The opaque parameter to the function.
>  
>  **/
>  VOID
> +EFIAPI
>  HttpIoNotifyDpc (
>    IN VOID                *Context
>    )
>  {
>    *((BOOLEAN *) Context) = TRUE;
> @@ -644,10 +645,11 @@ HttpIoNotifyDpc (
>    @param[in]  Event                 The event signaled.
>    @param[in]  Context               The opaque parameter to the function.
>  
>  **/
>  VOID
> +EFIAPI
>  HttpIoNotify (
>    IN EFI_EVENT              Event,
>    IN VOID                   *Context
>    )
>  {
>