public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Jiewen Yao <jiewen.yao@intel.com>,
	Jian J Wang <jian.j.wang@intel.com>,
	Xiaoyu Lu <xiaoyu1.lu@intel.com>,
	Guomin Jiang <guomin.jiang@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove MU_CHANGE comment markers
Date: Thu, 14 Apr 2022 10:18:57 -0400	[thread overview]
Message-ID: <32cd6aa6-41ed-c03f-25b5-a5d2e9c84ebc@linux.microsoft.com> (raw)
In-Reply-To: <16E328537D985BE0.6541@groups.io>

Please review this patch when possible. It is just removing two 
irrelevant comments.

Thanks,
Michael

On 4/5/2022 8:50 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> MU_CHANGE tags are used in a different project (Project Mu) to
> highlight deviations from Tianocore. Therefore, the comments are
> not needed when the changes are present in a Tianocore repository.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   CryptoPkg/Library/TlsLibNull/TlsConfigNull.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c
> index b5d9aca06535..03726fd7264c 100644
> --- a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c
> +++ b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c
> @@ -130,8 +130,6 @@ TlsSetVerify (
>     ASSERT (FALSE);
>   }
>   
> -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN) accepted. [BEGIN]
> -
>   /**
>     Set the specified host name to be verified.
>   
> @@ -156,8 +154,6 @@ TlsSetVerifyHost (
>     return EFI_UNSUPPORTED;
>   }
>   
> -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN) accepted. [END]
> -
>   /**
>     Sets a TLS/SSL session ID to be used during TLS/SSL connect.
>   

       reply	other threads:[~2022-04-14 14:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <16E328537D985BE0.6541@groups.io>
2022-04-14 14:18 ` Michael Kubacki [this message]
2022-04-14 14:32   ` [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove MU_CHANGE comment markers Yao, Jiewen
     [not found]   ` <16E5C9D091CB7A74.8845@groups.io>
2022-04-14 14:51     ` Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32cd6aa6-41ed-c03f-25b5-a5d2e9c84ebc@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox