From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web12.12161.1649945939404977512
 for <devel@edk2.groups.io>;
 Thu, 14 Apr 2022 07:18:59 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=cRGMNZbb;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.46.36])
	by linux.microsoft.com (Postfix) with ESMTPSA id 2670820C34F0;
	Thu, 14 Apr 2022 07:18:58 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2670820C34F0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1649945938;
	bh=AdbVQt5QpXNw6kjRm6rpdRNCAs6X+V5MSOmoRfnWQyw=;
	h=Date:Subject:From:To:Cc:Reply-To:References:In-Reply-To:From;
	b=cRGMNZbbslfsGHJC2v+c+/6wkWdBB/b3NxaXPWC8WshSTqSNM8qPM5EdJrUBkzMPc
	 aEg8brf4vBJlvUxw1z3NsTZDl9dug70iaLARu6+HF1KQ2BEAdAVxR2SFyMT+5+OZeb
	 eRY1bKCLwi0L0JBjciJFILGSSjGMAAXR496K6bzY=
Message-ID: <32cd6aa6-41ed-c03f-25b5-a5d2e9c84ebc@linux.microsoft.com>
Date: Thu, 14 Apr 2022 10:18:57 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove MU_CHANGE comment markers
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Jiewen Yao <jiewen.yao@intel.com>, Jian J Wang <jian.j.wang@intel.com>,
 Xiaoyu Lu <xiaoyu1.lu@intel.com>, Guomin Jiang <guomin.jiang@intel.com>
Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com
References: <16E328537D985BE0.6541@groups.io>
In-Reply-To: <16E328537D985BE0.6541@groups.io>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Please review this patch when possible. It is just removing two 
irrelevant comments.

Thanks,
Michael

On 4/5/2022 8:50 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> MU_CHANGE tags are used in a different project (Project Mu) to
> highlight deviations from Tianocore. Therefore, the comments are
> not needed when the changes are present in a Tianocore repository.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   CryptoPkg/Library/TlsLibNull/TlsConfigNull.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c
> index b5d9aca06535..03726fd7264c 100644
> --- a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c
> +++ b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c
> @@ -130,8 +130,6 @@ TlsSetVerify (
>     ASSERT (FALSE);
>   }
>   
> -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN) accepted. [BEGIN]
> -
>   /**
>     Set the specified host name to be verified.
>   
> @@ -156,8 +154,6 @@ TlsSetVerifyHost (
>     return EFI_UNSUPPORTED;
>   }
>   
> -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN) accepted. [END]
> -
>   /**
>     Sets a TLS/SSL session ID to be used during TLS/SSL connect.
>