* Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove MU_CHANGE comment markers [not found] <16E328537D985BE0.6541@groups.io> @ 2022-04-14 14:18 ` Michael Kubacki 2022-04-14 14:32 ` Yao, Jiewen [not found] ` <16E5C9D091CB7A74.8845@groups.io> 0 siblings, 2 replies; 3+ messages in thread From: Michael Kubacki @ 2022-04-14 14:18 UTC (permalink / raw) To: devel; +Cc: Jiewen Yao, Jian J Wang, Xiaoyu Lu, Guomin Jiang Please review this patch when possible. It is just removing two irrelevant comments. Thanks, Michael On 4/5/2022 8:50 PM, Michael Kubacki wrote: > From: Michael Kubacki <michael.kubacki@microsoft.com> > > MU_CHANGE tags are used in a different project (Project Mu) to > highlight deviations from Tianocore. Therefore, the comments are > not needed when the changes are present in a Tianocore repository. > > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Jian J Wang <jian.j.wang@intel.com> > Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com> > Cc: Guomin Jiang <guomin.jiang@intel.com> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> > --- > CryptoPkg/Library/TlsLibNull/TlsConfigNull.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c > index b5d9aca06535..03726fd7264c 100644 > --- a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c > +++ b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c > @@ -130,8 +130,6 @@ TlsSetVerify ( > ASSERT (FALSE); > } > > -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN) accepted. [BEGIN] > - > /** > Set the specified host name to be verified. > > @@ -156,8 +154,6 @@ TlsSetVerifyHost ( > return EFI_UNSUPPORTED; > } > > -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN) accepted. [END] > - > /** > Sets a TLS/SSL session ID to be used during TLS/SSL connect. > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove MU_CHANGE comment markers 2022-04-14 14:18 ` [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove MU_CHANGE comment markers Michael Kubacki @ 2022-04-14 14:32 ` Yao, Jiewen [not found] ` <16E5C9D091CB7A74.8845@groups.io> 1 sibling, 0 replies; 3+ messages in thread From: Yao, Jiewen @ 2022-04-14 14:32 UTC (permalink / raw) To: devel@edk2.groups.io, mikuback@linux.microsoft.com Cc: Wang, Jian J, Lu, Xiaoyu1, Jiang, Guomin Ah, thanks for the reminder. I overlooked this one. Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael > Kubacki > Sent: Thursday, April 14, 2022 10:19 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; > Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com> > Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove > MU_CHANGE comment markers > > Please review this patch when possible. It is just removing two > irrelevant comments. > > Thanks, > Michael > > On 4/5/2022 8:50 PM, Michael Kubacki wrote: > > From: Michael Kubacki <michael.kubacki@microsoft.com> > > > > MU_CHANGE tags are used in a different project (Project Mu) to > > highlight deviations from Tianocore. Therefore, the comments are > > not needed when the changes are present in a Tianocore repository. > > > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > Cc: Jian J Wang <jian.j.wang@intel.com> > > Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com> > > Cc: Guomin Jiang <guomin.jiang@intel.com> > > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> > > --- > > CryptoPkg/Library/TlsLibNull/TlsConfigNull.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c > b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c > > index b5d9aca06535..03726fd7264c 100644 > > --- a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c > > +++ b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c > > @@ -130,8 +130,6 @@ TlsSetVerify ( > > ASSERT (FALSE); > > } > > > > -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN) > accepted. [BEGIN] > > - > > /** > > Set the specified host name to be verified. > > > > @@ -156,8 +154,6 @@ TlsSetVerifyHost ( > > return EFI_UNSUPPORTED; > > } > > > > -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN) > accepted. [END] > > - > > /** > > Sets a TLS/SSL session ID to be used during TLS/SSL connect. > > > > > > ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <16E5C9D091CB7A74.8845@groups.io>]
* Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove MU_CHANGE comment markers [not found] ` <16E5C9D091CB7A74.8845@groups.io> @ 2022-04-14 14:51 ` Yao, Jiewen 0 siblings, 0 replies; 3+ messages in thread From: Yao, Jiewen @ 2022-04-14 14:51 UTC (permalink / raw) To: devel@edk2.groups.io, Yao, Jiewen, mikuback@linux.microsoft.com Cc: Wang, Jian J, Lu, Xiaoyu1, Jiang, Guomin Merged - https://github.com/tianocore/edk2/pull/2779 > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen > Sent: Thursday, April 14, 2022 10:32 PM > To: devel@edk2.groups.io; mikuback@linux.microsoft.com > Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; > Jiang, Guomin <guomin.jiang@intel.com> > Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove > MU_CHANGE comment markers > > Ah, thanks for the reminder. I overlooked this one. > > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael > > Kubacki > > Sent: Thursday, April 14, 2022 10:19 PM > > To: devel@edk2.groups.io > > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J > <jian.j.wang@intel.com>; > > Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com> > > Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove > > MU_CHANGE comment markers > > > > Please review this patch when possible. It is just removing two > > irrelevant comments. > > > > Thanks, > > Michael > > > > On 4/5/2022 8:50 PM, Michael Kubacki wrote: > > > From: Michael Kubacki <michael.kubacki@microsoft.com> > > > > > > MU_CHANGE tags are used in a different project (Project Mu) to > > > highlight deviations from Tianocore. Therefore, the comments are > > > not needed when the changes are present in a Tianocore repository. > > > > > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > > Cc: Jian J Wang <jian.j.wang@intel.com> > > > Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com> > > > Cc: Guomin Jiang <guomin.jiang@intel.com> > > > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> > > > --- > > > CryptoPkg/Library/TlsLibNull/TlsConfigNull.c | 4 ---- > > > 1 file changed, 4 deletions(-) > > > > > > diff --git a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c > > b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c > > > index b5d9aca06535..03726fd7264c 100644 > > > --- a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c > > > +++ b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c > > > @@ -130,8 +130,6 @@ TlsSetVerify ( > > > ASSERT (FALSE); > > > } > > > > > > -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN) > > accepted. [BEGIN] > > > - > > > /** > > > Set the specified host name to be verified. > > > > > > @@ -156,8 +154,6 @@ TlsSetVerifyHost ( > > > return EFI_UNSUPPORTED; > > > } > > > > > > -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN) > > accepted. [END] > > > - > > > /** > > > Sets a TLS/SSL session ID to be used during TLS/SSL connect. > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-14 14:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <16E328537D985BE0.6541@groups.io>
2022-04-14 14:18 ` [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove MU_CHANGE comment markers Michael Kubacki
2022-04-14 14:32 ` Yao, Jiewen
[not found] ` <16E5C9D091CB7A74.8845@groups.io>
2022-04-14 14:51 ` Yao, Jiewen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox