From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 15D34AC116D for ; Fri, 15 Mar 2024 10:29:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gMz85vOXaAT1fmurrKy9lTJ4poJ91cn4ABHrEFW4BzU=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1710498576; v=1; b=NwhJPeR1Jnro2lcrQ3S8qfgT6itbXdxQdcGe/OviWOH8yI4Ih3Eo9BU3pelCIsBnfOi2RJpA cc/Hzg1Fo4WBJtdsdBAmnelOV0sIfNv8abBjAj4vBcFV++qF7jrem5uHbjQ6Nw4b48PQWQpYamW mAJGktQW2/0xJ/RHdiJQ4ZZxOuVbyYxxZyhL7mRwNc96IpnpmN84gFlE1h3s8sedjhPhlvxlQUG PERdOZSIYx2Ae3JvhdsTINzEOM2TGJmLpCGRggfWaMf6CQVO1V/GTPt1B9R6WomZJh3JulIBoy5 Ntp1ACo9HW6gTS04Dcht6Gdq+EY5HcEvC9xrwouzpC5Pw== X-Received: by 127.0.0.2 with SMTP id up4TYY7687511xUjjzp64T7C; Fri, 15 Mar 2024 03:29:36 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.18637.1710498575316913634 for ; Fri, 15 Mar 2024 03:29:36 -0700 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8CxF+iiIPRlPG4ZAA--.41352S3; Fri, 15 Mar 2024 18:19:15 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxzxOgIPRlHdhaAA--.52836S3; Fri, 15 Mar 2024 18:19:12 +0800 (CST) Message-ID: <32d4cd2c-1d83-48f5-ba30-7eda6dbcbf44@loongson.cn> Date: Fri, 15 Mar 2024 18:19:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 18/26] OvmfPkg/LoongArchVirt: Add the early serial port output library To: devel@edk2.groups.io, kraxel@redhat.com Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Bibo Mao , Dongyan Qian , Xianglai Li References: <20240311093631.1251466-1-lichao@loongson.cn> <20240311093908.1254385-1-lichao@loongson.cn> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8AxzxOgIPRlHdhaAA--.52836S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQARCGX0BucCWQABsy X-Coremail-Antispam: 1Uk129KBj9xXoW7XF45KryrGFWrZrW3Jr4xGrX_yoWkCrb_C3 43Xry5Xwnrt3ZFgr4qqr98GrZYga9ruFZ0yrZ2gws7AFWxCayvvw15Xa40ga1xJ347Ar4D Wr17Kr43Ar1vgosvyTuYvTs0mTUanT9S1TB71UUUUUJqnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjDUYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUUbV8YFVCjjxCrM7AC 8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr 0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AK xVWUCVW8JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIE14 v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26F4UJVW0owAaw2AFwI0_Jrv_JF1l e2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAv7VC0I7IYx2 IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0 Y48IcVAKI48JMx8GjcxK6IxK0xIIj40E5I8CrwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4 IE7xkEbVWUJVW8JwCFI7km07C267AKxVWUXVWUAwC20s026c02F40E14v26r106r1rMI8I 3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIx AIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAI cVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2js IEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07jUManUUUUU= X-Gw-Check: 35eccaf8ce65f800 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 15 Mar 2024 03:29:36 -0700 Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: rYCwqoK6cfNnuAi1kSezS640x7686176AA= Content-Type: multipart/alternative; boundary="------------qojP1nfZTkU7bvFvfOz8tqk0" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=NwhJPeR1; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------qojP1nfZTkU7bvFvfOz8tqk0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Gerd, Thanks, Chao On 2024/3/15 17:36, Gerd Hoffmann wrote: > On Mon, Mar 11, 2024 at 05:39:08PM +0800, Chao Li wrote: >> Add a early serial port output library into LoongArchVirt that named >> EarlyFdtSerialPortLib16550, this library is referenced from >> MdeModulePkg. > Why create your own copy? What are the differences to > MdeModulePkg/Library/BaseSerialPortLib16550? This library is used in the PEI stage, same as the Hook Library,=20 LoongArch QEMU is runs on flash in PEI stage, MdeModule version does not=20 support to get the SerialRegisterBase via registers or HOB or FDT, I=20 thought if we adjust the MdeModule version is a big project, so I copied=20 the MdeModule version, and added a way to get SerialRegisterBase via FDT. > > take care, > Gerd > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116804): https://edk2.groups.io/g/devel/message/116804 Mute This Topic: https://groups.io/mt/104859894/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------qojP1nfZTkU7bvFvfOz8tqk0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Gerd,


=
Thanks,
Chao
On 2024/3/15 17:36, Gerd Hoffmann wrote:
On Mon, Mar 11, 2024 at 05:39:=
08PM +0800, Chao Li wrote:

Add a early serial port outp=
ut library into LoongArchVirt that named
EarlyFdtSerialPortLib16550, this library is referenced from
MdeModulePkg.

Why create your own copy?  What are the differences to=20
MdeModulePkg/Library/BaseSerialPortLib16550?
This library is used in the PEI stage, same as the Hook Library, LoongArch QEMU is runs on flash in PEI stage, MdeModule version does not support to get the SerialRegisterBase via registers or HOB or FDT, I thought if we adjust the MdeModule version is a big project, so I copied the MdeModule version, and added a way to get SerialRegisterBase via FDT.

take care,
  Gerd
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#116804) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------qojP1nfZTkU7bvFvfOz8tqk0--