From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.561.1591219843107035349 for ; Wed, 03 Jun 2020 14:30:43 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A025555D; Wed, 3 Jun 2020 14:30:41 -0700 (PDT) Received: from [192.168.1.69] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3772F3F6CF; Wed, 3 Jun 2020 14:30:41 -0700 (PDT) Subject: Re: [PATCH] ArmPkg/ArmPkg.dsc: set terminal type PCD to the right value To: Leif Lindholm Cc: devel@edk2.groups.io References: <20200603193635.5823-1-ard.biesheuvel@arm.com> <20200603201844.GU28566@vanye> From: "Ard Biesheuvel" Message-ID: <32e90755-7e29-fcd8-9d9d-1e990413c875@arm.com> Date: Wed, 3 Jun 2020 23:30:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200603201844.GU28566@vanye> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 6/3/20 10:18 PM, Leif Lindholm wrote: > On Wed, Jun 03, 2020 at 21:36:35 +0200, Ard Biesheuvel wrote: >> PlatformBootManagerLib now asserts at build time that the correct >> terminal type is used, and so leaving it unset breaks the ArmPkg >> DSC build. So fix that. >> >> Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Thanks Pushed as #657 >> --- >> ArmPkg/ArmPkg.dsc | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc >> index 549a2d29ab61..bac1306af61f 100644 >> --- a/ArmPkg/ArmPkg.dsc >> +++ b/ArmPkg/ArmPkg.dsc >> @@ -29,6 +29,9 @@ [BuildOptions] >> RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG >> *_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES >> >> +[PcdsFixedAtBuild] >> + gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4 >> + >> [LibraryClasses.common] >> BaseLib|MdePkg/Library/BaseLib/BaseLib.inf >> BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf >> -- >> 2.26.2 >>