From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, ardb@kernel.org
Cc: Michael Kubacki <mikuback@linux.microsoft.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [RFC PATCH] ArmPkg: Enable AuditMode for Uncrustify CI checks
Date: Wed, 21 Jun 2023 12:41:01 +0200 [thread overview]
Message-ID: <32rzrxqiqgc4li3hrhui2qvcg7caootlvphlwq5hnvtukhvl7y@szpomotvdcte> (raw)
In-Reply-To: <CAMj1kXHuZOqNyOXaJnu5eJVg5xsSBcegh2RDFr_RVDuAak+7Uw@mail.gmail.com>
Hi,
> > In AArch64Mmu.h, I agree that preserving the (mostly) global column as
> > opposed to block-specific columns would be easier to vertically scan. Is
> > that the main issue in the file?
>
> Yes.
It is possible to exclude specific files from checks, see CryptoPkg for
example which does this for some files generated by openssl configure.
> I'm sure this all seems quite reasonable if you already bought into
> using uncrustify. But for a drive-by contributor, or someone like me
> who has been contributing code for many years based on the agreed
> coding style guidelines, I struggle to understand why uncrustify is a
> reasonable solution to the problem of inconsistent coding style.
I find it quite nice. Yes, you have to invest the time to set things up
once. But then you can just delegate all code formating to uncrustify
instead of doing it manually.
take care,
Gerd
prev parent reply other threads:[~2023-06-21 10:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 8:51 [RFC PATCH] ArmPkg: Enable AuditMode for Uncrustify CI checks Ard Biesheuvel
2023-06-02 9:34 ` Leif Lindholm
2023-06-02 15:18 ` [edk2-devel] " Michael Kubacki
[not found] ` <1764E0991FEF04DA.11185@groups.io>
2023-06-02 15:22 ` Michael Kubacki
2023-06-02 15:26 ` Michael Kubacki
2023-06-02 15:50 ` Ard Biesheuvel
2023-06-02 16:52 ` Michael Kubacki
2023-06-21 10:41 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32rzrxqiqgc4li3hrhui2qvcg7caootlvphlwq5hnvtukhvl7y@szpomotvdcte \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox