public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Chuong Tran <chuong@amperemail.onmicrosoft.com>
To: memristor2 <memristor2@proton.me>, devel@edk2.groups.io
Cc: Nhi Pham OS <nhi@os.amperecomputing.com>,
	"quic_llindhol@quicinc.com" <quic_llindhol@quicinc.com>,
	Chuong Tran OS <chuong@os.amperecomputing.com>,
	Rebecca Cran OS <rebecca@os.amperecomputing.com>
Subject: Re: [edk2-devel] [PATCH 0/2] Ampere: Add BMC Configuration Screen
Date: Fri, 6 Sep 2024 15:15:11 +0700	[thread overview]
Message-ID: <33030a6f-796b-4ed0-8559-a249cd67a8fe@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <HVS7ZqaJKjbWt0NNP3PVpx9kuJj09E9Lxqfx_h560pk9L8gvZJ9-LNozRgo1ivIfMwNIWVe75TYGFdBsgXkPBvVpZ0KaqE5MVSGb5DsTXyg=@proton.me>

Hi,

The driver was intended for Platform Configuration Screen of Ampere's 
platforms. You can always leverage this driver and submit another 
patchset to ManageabilityPkg.

Thanks,
Chuong

On 9/1/2024 2:31 PM, memristor2 wrote:
> [EXTERNAL EMAIL NOTICE: This email originated from an external sender. 
> Please be mindful of safe email handling and proprietary information 
> protection practices.]
>
> Hello,
> I looked into this driver and saw it was platform-independent. Why not 
> add this into to the features directory? I wrote this driver from 
> scratch and saw this patch later in my emails. it would facilitated my 
> development if I saw it sooner if it were inside a directory that was 
> platform-independent.
> Thanks,
> Memristor
>
> Sent with Proton Mail <https://proton.me/> secure email.
>
> On Thursday, August 29th, 2024 at 10:46 AM, Nhi Pham via groups.io 
> <nhi=os.amperecomputing.com@groups.io> wrote:
>> Pushed as 9d8eda6ffff2..146cb5322498
>>
>> Thanks,
>> Nhi
>> ------------------------------------------------------------------------
>> *From:* devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Nhi 
>> Pham via groups.io <nhi=os.amperecomputing.com@groups.io>
>> *Sent:* Friday, August 23, 2024 9:51 AM
>> *To:* Chuong Tran OS <chuong@amperemail.onmicrosoft.com>; 
>> devel@edk2.groups.io <devel@edk2.groups.io>
>> *Cc:* quic_llindhol@quicinc.com <quic_llindhol@quicinc.com>; Chuong 
>> Tran OS <chuong@os.amperecomputing.com>; Rebecca Cran OS 
>> <rebecca@os.amperecomputing.com>
>> *Subject:* Re: [edk2-devel] [PATCH 0/2] Ampere: Add BMC Configuration 
>> Screen
>> Thanks for the review. I will push after the IPMI SSIF support is merged.
>>
>> -Nhi
>> ------------------------------------------------------------------------
>> *From:* Chuong Tran OS <chuong@amperemail.onmicrosoft.com>
>> *Sent:* Thursday, August 22, 2024 3:22 PM
>> *To:* Nhi Pham OS <nhi@os.amperecomputing.com>; devel@edk2.groups.io 
>> <devel@edk2.groups.io>
>> *Cc:* quic_llindhol@quicinc.com <quic_llindhol@quicinc.com>; Chuong 
>> Tran OS <chuong@os.amperecomputing.com>; Rebecca Cran OS 
>> <rebecca@os.amperecomputing.com>
>> *Subject:* Re: [PATCH 0/2] Ampere: Add BMC Configuration Screen
>> Reviewed-by: Chuong Tran <chuong@os.amperecomputing.com>
>>
>> Thanks,
>> Chuong
>>
>> On 8/14/2024 10:18 AM, Nhi Pham wrote:
>> > This implements BMC Configuration Screen and supports on Ampere Mt. 
>> Jade platform.
>> >
>> > Nhi Pham (2):
>> >    AmpereSiliconPkg: Implement BMC Configuration screen
>> >    JadePkg: Add BmcConfigDxe
>> >
>> > Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec |   8 +-
>> > Platform/Ampere/JadePkg/Jade.dsc |   1 +
>> > Platform/Ampere/JadePkg/Jade.fdf |   1 +
>> > 
>> Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe.inf 
>> |  44 +++
>> > Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe.h 
>> |  35 +++
>> > Silicon/Ampere/AmpereSiliconPkg/Include/Guid/BmcConfigHii.h |  19 ++
>> > 
>> Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigVfr.vfr 
>> |  42 +++
>> > Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe.c 
>> | 326 ++++++++++++++++++++
>> > 
>> Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe.uni 
>> |  18 ++
>> >   9 files changed, 493 insertions(+), 1 deletion(-)
>> >   create mode 100644 
>> Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe.inf
>> >   create mode 100644 
>> Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe.h
>> >   create mode 100644 
>> Silicon/Ampere/AmpereSiliconPkg/Include/Guid/BmcConfigHii.h
>> >   create mode 100644 
>> Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigVfr.vfr
>> >   create mode 100644 
>> Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe.c
>> >   create mode 100644 
>> Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe.uni
>> >
>> > --
>> > 2.25.1
>> >
>>
>> 
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120522): https://edk2.groups.io/g/devel/message/120522
Mute This Topic: https://groups.io/mt/107889120/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      reply	other threads:[~2024-09-06 14:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14  3:18 [edk2-devel] [PATCH 0/2] Ampere: Add BMC Configuration Screen Nhi Pham via groups.io
2024-08-14  3:18 ` [edk2-devel] [PATCH 1/2] AmpereSiliconPkg: Implement BMC Configuration screen Nhi Pham via groups.io
2024-09-03 14:34   ` Rebecca Cran via groups.io
2024-08-14  3:18 ` [edk2-devel] [PATCH 2/2] JadePkg: Add BmcConfigDxe Nhi Pham via groups.io
2024-08-22  8:22 ` [edk2-devel] [PATCH 0/2] Ampere: Add BMC Configuration Screen Chuong Tran
2024-08-23  2:51   ` Nhi Pham via groups.io
     [not found]   ` <17EE3BCF72FBD18E.23723@groups.io>
2024-08-29  7:16     ` Nhi Pham via groups.io
2024-09-01  7:31       ` memristor2 via groups.io
2024-09-06  8:15         ` Chuong Tran [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33030a6f-796b-4ed0-8559-a249cd67a8fe@amperemail.onmicrosoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox