From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 21 May 2019 14:10:09 -0700 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5DCF23002DAE; Tue, 21 May 2019 21:10:00 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-194.rdu2.redhat.com [10.10.120.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5B89066618; Tue, 21 May 2019 21:09:58 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH] BaseTools:Add the FeatureFlagExpression usage to the InfBuildData To: devel@edk2.groups.io, zhijux.fan@intel.com Cc: "Gao, Liming" , "Feng, Bob C" References: From: "Laszlo Ersek" Message-ID: <330e5eb6-5220-5026-74da-d4fb1622cca9@redhat.com> Date: Tue, 21 May 2019 23:09:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Tue, 21 May 2019 21:10:08 +0000 (UTC) Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/17/19 02:57, Fan, ZhijuX wrote: > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1446 > > FeatureFlagExpression Support in LibraryClasses/Guids/Ppi/Protocols > section of INF file. The Pcd value in the expression is from INF or DEC > When a FeatureFlagExpression is present,if the expression evaluates > to TRUE,then the entry is valid. If the expression evaluates to FALSE, > then the EDK II build tools must ignore the entry. > > This patch is going to add this feature. > > Cc: Bob Feng > Cc: Liming Gao > Signed-off-by: Zhiju.Fan > --- > BaseTools/Source/Python/Common/Expression.py | 2 +- > BaseTools/Source/Python/Common/GlobalData.py | 1 + > BaseTools/Source/Python/Workspace/InfBuildData.py | 69 ++++++++++++++++++++-- > .../Source/Python/Workspace/WorkspaceCommon.py | 10 +++- > 4 files changed, 73 insertions(+), 9 deletions(-) This feature has missed edk2-stable201905. Please postpone the following BZ reference: https://bugzilla.tianocore.org/show_bug.cgi?id=1446 from https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning#edk2-stable201905-tag-planning to https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning#edk2-stable201908-tag-planning Thanks, Laszlo