From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.65, mailfrom: philmd@redhat.com) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by groups.io with SMTP; Thu, 11 Apr 2019 03:59:14 -0700 Received: by mail-wr1-f65.google.com with SMTP id w1so6754672wrp.2 for ; Thu, 11 Apr 2019 03:59:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yRO02cd/7qd2gEOB5hTgEwuuNR4UBMZZNsQUj86m2Ug=; b=J1BcUtoDFTfdKNnabGHfbOmnIvFH26rXVqHGNuSqN3jkF7vA3Xq2FWyQEP5fybTf7u UgIpMrt3KefVrzLgU0jZOs5UlTG6R4hD0CcKwt+Opk8+uwFpyMe/Y02Rv05cJzM4amNK a+mp3ioajg0GZ1ylAHPn0DAHvycoqqFWfSDIWdNeMXuKKKaMdEc1hRNuXWkaq5ZwIizx FCI0fEWZ8P9x7PgxyW8AUIUBfZ0P6rxz8smVXdNMni3TpWxEZy8Y9FAMQIs7WfmLf/SA Q6rgUQiPzA8Ov5+1FMAd4Aj8SxztUk/D3yWiue1UUH7uW16lMjfOeqKYtywFDSw4dP8b z86g== X-Gm-Message-State: APjAAAXYa+myKnMM8g39o3O0C4P5KqBEZNonWUJcYs2IK5UBscDlbO0O Xkymg61xrh+c25UHNwG3Skh+sg== X-Google-Smtp-Source: APXvYqyT4AYUMJVjteUDIMBC5BeT475GJDXgWfN3THigQ3aP/fLp2IOTVAp+JemrwN+sYY7QIO/7Wg== X-Received: by 2002:a5d:4750:: with SMTP id o16mr27656793wrs.206.1554980353195; Thu, 11 Apr 2019 03:59:13 -0700 (PDT) Return-Path: Received: from [192.168.1.33] (193.red-88-21-103.staticip.rima-tde.net. [88.21.103.193]) by smtp.gmail.com with ESMTPSA id f1sm4364713wml.28.2019.04.11.03.59.12 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 11 Apr 2019 03:59:12 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output To: liming.gao@intel.com, Michael D Kinney , Laszlo Ersek References: <20190404175616.51393-1-rebecca@bluestop.org> <1593821D7C44BA9C.31892@groups.io> <4A89E2EF3DFEDB4C8BFDE51014F606A14E42222A@SHSMSX104.ccr.corp.intel.com> Cc: devel@edk2.groups.io, "rebecca@bluestop.org" , Stephano Cetola From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <334bc708-2250-d4e0-9ec5-5f1c6d92c3e2@redhat.com> Date: Thu, 11 Apr 2019 12:59:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E42222A@SHSMSX104.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Liming, On 4/11/19 2:32 AM, Liming Gao wrote: > Push on commit ddb8cedce7e07b87c0ac6b84cd750a6d3dac47c8 I see in the git history the authorship passed from: rebecca@bluestop.org to: Rebecca Cran via Groups.Io I wonder if we shouldn't block pushes until the BaseTools/Scripts/PatchCheck.py tool get fixed to avoid such mistakes which are likely to get reproduced now that we switched to Groups.Io. Thoughts? Regards, Phil. >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Liming Gao >> Sent: Monday, April 08, 2019 9:16 PM >> To: Philippe Mathieu-Daudé ; rebecca@bluestop.org >> Cc: devel@edk2.groups.io >> Subject: Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments >> and improve E820 debug output >> >> Reviewed-by: Liming Gao >> >>> -----Original Message----- >>> From: Philippe Mathieu-Daudé [mailto:philmd@redhat.com] >>> Sent: Friday, April 5, 2019 5:05 PM >>> To: rebecca@bluestop.org; Gao, Liming >>> Cc: devel@edk2.groups.io >>> Subject: Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix >> comments and improve E820 debug output >>> >>> On 4/4/19 7:56 PM, Rebecca Cran via Groups.Io wrote: >>>> Fix a few typos in LegacyBiosBuildE820, and improve the debug output of >>>> the E820 table to pad with zeros instead of spaces, remove extra hyphens >>>> and display the memory type in decimal. >>>> >>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>> Signed-off-by: Rebecca Cran >>> >>> Reviewed-by: Philippe Mathieu-Daude >>> >>>> --- >>>> .../Csm/LegacyBiosDxe/LegacyBootSupport.c | 10 +++++----- >>>> 1 file changed, 5 insertions(+), 5 deletions(-) >>>> >>>> diff --git >> a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBootSupport.c >>> b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBootSupport.c >>>> index a7b8e6a9a0..8c415cdfc6 100644 >>>> --- >> a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBootSupport.c >>>> +++ >> b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBootSupport.c >>>> @@ -1711,9 +1711,9 @@ LegacyBiosBuildE820 ( >>>> >>>> do { >>>> // >>>> - // Use size returned back plus 1 descriptor for the AllocatePool. >>>> + // Use size returned for the AllocatePool. >>>> // We don't just multiply by 2 since the "for" loop below terminates on >>>> - // EfiMemoryMapEnd which is dependent upon EfiMemoryMapSize. >> Otherwize >>>> + // EfiMemoryMapEnd which is dependent upon EfiMemoryMapSize. >> Otherwise >>>> // we process bogus entries and create bogus E820 entries. >>>> // >>>> EfiMemoryMap = (EFI_MEMORY_DESCRIPTOR *) AllocatePool >> (EfiMemoryMapSize); >>>> @@ -1801,7 +1801,7 @@ LegacyBiosBuildE820 ( >>>> MemoryBlockLength = (UINT64) (LShiftU64 (EfiEntry->NumberOfPages, >> 12)); >>>> if ((EfiEntry->PhysicalStart + MemoryBlockLength) < 0x100000) { >>>> // >>>> - // Skip the memory block is under 1MB >>>> + // Skip the memory block if under 1MB >>>> // >>>> } else { >>>> if (EfiEntry->PhysicalStart < 0x100000) { >>>> @@ -1926,7 +1926,7 @@ LegacyBiosBuildE820 ( >>>> *Size = (UINTN) (Index * sizeof (EFI_E820_ENTRY64)); >>>> >>>> // >>>> - // Determine OS usable memory above 1Mb >>>> + // Determine OS usable memory above 1MB >>>> // >>>> Private->IntThunk->EfiToLegacy16BootTable.OsMemoryAbove1Mb = >> 0x0000; >>>> for (TempIndex = Above1MIndex; TempIndex < Index; TempIndex++) { >>>> @@ -1948,7 +1948,7 @@ LegacyBiosBuildE820 ( >>>> // Print DEBUG information >>>> // >>>> for (TempIndex = 0; TempIndex < Index; TempIndex++) { >>>> - DEBUG((EFI_D_INFO, "E820[%2d]: 0x%16lx ---- 0x%16lx, Type = 0x%x >> \n", >>>> + DEBUG((EFI_D_INFO, "E820[%2d]: 0x%016lx - 0x%016lx, Type = %d\n", >>>> TempIndex, >>>> E820Table[TempIndex].BaseAddr, >>>> (E820Table[TempIndex].BaseAddr + E820Table[TempIndex].Length), >>>> >> >> > > > >