From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web10.36330.1610988495180764209 for ; Mon, 18 Jan 2021 08:48:16 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Q19GAKH/; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610988494; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5bGDvp+QhVJWQTEcMj0sw6OBFjaZF8Q1FuGq5Nn+8FM=; b=Q19GAKH/CXexPFyq2dpuSxO75wXHtbmy6T6gBKw/OznqIGwiZPOil1VPOLRcbmrNKWqBzx vjnM2elBBaL6iNQiZ0dxQgbKYT05siQWMTJF1VT0fJsHGgxoEAtwOQRknWy7fAzbLF9svh em2KOauuXc6hkgoXuWCXcykqCqlcmbU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-366-guD63vnoOW-HhyajOXMdvg-1; Mon, 18 Jan 2021 11:48:10 -0500 X-MC-Unique: guD63vnoOW-HhyajOXMdvg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 974D059; Mon, 18 Jan 2021 16:48:08 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-48.ams2.redhat.com [10.36.112.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4993010023B3; Mon, 18 Jan 2021 16:48:07 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 04/10] EmulatorPkg: add OrderedCollectionLib class resolution From: "Laszlo Ersek" To: devel@edk2.groups.io Cc: Andrew Fish , Jordan Justen , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Ray Ni Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <20210113085453.10168-1-lersek@redhat.com> <20210113085453.10168-5-lersek@redhat.com> Message-ID: <334ca3c6-6950-9ca2-8135-f9b3171e73a2@redhat.com> Date: Mon, 18 Jan 2021 17:48:06 +0100 MIME-Version: 1.0 In-Reply-To: <20210113085453.10168-5-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Ping -- Ray, can you please check this?; it's a one-liner patch. Thanks. Laszlo On 01/13/21 09:54, Laszlo Ersek wrote: > A subsequent patch in the series will make the > > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf > > instance dependent on the OrderedCollectionLib class. Because the shell > binary in this platform consumes the above UefiShellCommandLib instance, > resolve OrderedCollectionLib. > > Cc: Andrew Fish > Cc: Jordan Justen > Cc: Philippe Mathieu-Daudé > Cc: Ray Ni > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3151 > Signed-off-by: Laszlo Ersek > --- > > Notes: > v2: > - new patch > > EmulatorPkg/EmulatorPkg.dsc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc > index de8144844c57..9ecc37334305 100644 > --- a/EmulatorPkg/EmulatorPkg.dsc > +++ b/EmulatorPkg/EmulatorPkg.dsc > @@ -453,6 +453,7 @@ [Components] > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf > SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > # SafeBlockIoLib|ShellPkg/Library/SafeBlockIoLib/SafeBlockIoLib.inf >