From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 02A25AC124F for ; Fri, 20 Oct 2023 12:26:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YtzFmgn6Dv4PO5JaTH7rYM99ew59LZjXVPs1ee/mNgc=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20140610; t=1697804792; v=1; b=n1P2/xjERDx5sSNW2NFJNG6jng3F+8QJETBx6S9ZyjaZip0THFw4rTl2JBKi3c4Uy2GTacHE zo58jlcRtwHSP+jOsmYpLz/eGFZGM3qkkfWX8kVViye4rnwNM//TkLVCHFA8rIVc6VpHa10MyY8 EXL9cvMILuJDdWtOonsaLRMU= X-Received: by 127.0.0.2 with SMTP id P0YIYY7687511x4lQOXkQCnn; Fri, 20 Oct 2023 05:26:32 -0700 X-Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mx.groups.io with SMTP id smtpd.web11.51491.1697798640816847810 for ; Fri, 20 Oct 2023 03:44:01 -0700 X-Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id B9B133FD40 for ; Fri, 20 Oct 2023 10:43:57 +0000 (UTC) X-Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4067f186094so3441595e9.1 for ; Fri, 20 Oct 2023 03:43:57 -0700 (PDT) X-Gm-Message-State: poazBet4zetY0UBARgikheWox7686176AA= X-Received: by 2002:a05:600c:4fcc:b0:401:73b2:f039 with SMTP id o12-20020a05600c4fcc00b0040173b2f039mr1197016wmq.7.1697798635083; Fri, 20 Oct 2023 03:43:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG1z7KcgSx9jehQOZmVZMxdqJlbgOrx1WlOuHS3RuXiUogMKM49PNfr5dnVqqtktcgOSolgkQ== X-Received: by 2002:a05:600c:4fcc:b0:401:73b2:f039 with SMTP id o12-20020a05600c4fcc00b0040173b2f039mr1196993wmq.7.1697798634607; Fri, 20 Oct 2023 03:43:54 -0700 (PDT) X-Received: from [192.168.123.67] (ip-178-202-040-247.um47.pools.vodafone-ip.de. [178.202.40.247]) by smtp.gmail.com with ESMTPSA id h12-20020adff18c000000b0032d402f816csm1390426wro.98.2023.10.20.03.43.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Oct 2023 03:43:54 -0700 (PDT) Message-ID: <334f6539-4a01-4feb-8172-a949f0744184@canonical.com> Date: Fri, 20 Oct 2023 12:43:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list To: Laszlo Ersek Cc: Sunil V L , Li Yong , Leif Lindholm , Ard Biesheuvel , Abner Chang , Daniel Schaefer , devel@edk2.groups.io, YuinYee Chew , ardb@kernel.org References: <20230929020222.2010-1-yuinyee.chew@starfivetech.com> <4487065a-ac8f-4a73-a3e5-b7069df9e7d3@canonical.com> <7844b7331b5f42019dfdf3fc706671c0@EXMBX073.cuchost.com> <82caabf5e259418487d56236a817de42@EXMBX073.cuchost.com> From: Heinrich Schuchardt In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,heinrich.schuchardt@canonical.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: multipart/mixed; boundary="------------uo7acVNVZRgJbs4jjP0YNOCY" Content-Language: en-US X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="n1P2/xjE"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=canonical.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------uo7acVNVZRgJbs4jjP0YNOCY Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 20.10.23 11:49, Laszlo Ersek wrote: > On 10/18/23 10:57, Ard Biesheuvel wrote: >> On Wed, 18 Oct 2023 at 10:49, YuinYee Chew >> wrote: >>> Dear Maintainers, >>> >>> Just a friendly reminder to ask if you could take a look at my patch. I= 'd really appreciate your feedback and help. >>> >> Thanks for the reminder. I don't have time to review this myself but >> I'm happy to merge it if someone else reviews it > Heinrich gave an Acked-by up-thread. >=20 > (I'd just go ahead and merge this myself to help you out a bit, but I > don't have access to the original patch!) >=20 > Laszlo See appendix. Best regards Heinrich -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109846): https://edk2.groups.io/g/devel/message/109846 Mute This Topic: https://groups.io/mt/101660590/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------uo7acVNVZRgJbs4jjP0YNOCY Content-Type: message/rfc822; name="[PATCH v1] EmbeddedPkg_NorFlashInfoLib: Update norflash device list - John Chew - 2023-09-29 0402.eml" Content-Disposition: attachment; filename*0="[PATCH v1] EmbeddedPkg_NorFlashInfoLib: Update norflash devi"; filename*1="ce list - John Chew - 2023-0"; filename*2="9-29 0402.eml" Content-Transfer-Encoding: 7bit Delivered-To: heinrich.schuchardt@canonical.com Received: by 2002:a59:dbd2:0:b0:3fc:79f6:f74 with SMTP id a18csp3818729vqd; Thu, 28 Sep 2023 19:02:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFWhbKlfhDigxiFSrXKkcKeMq6eHHA8IZidj3uTNgkACfO4dJox5WQNFFia+s708BF1hp9F X-Received: by 2002:a05:6a20:4327:b0:160:58f5:693b with SMTP id h39-20020a056a20432700b0016058f5693bmr2710277pzk.44.1695952979835; Thu, 28 Sep 2023 19:02:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695952979; cv=none; d=google.com; s=arc-20160816; b=jMibBFSFL6dX2ZEMJG2fqGkRIBq8MP5fq9Qyh0G7xbMJgDNTi5GEbX0RxX1P9a99zD DCEJioB/+aS1Bl3ezy9kg0QCuljqexM6FCgTWHyx5eAb8VGcdLSiVAVSuPbx3aot005p EmuUHQriuYnVZV6RYQzOt2HFZr/GWD/EkLDIYFYEVW1O5AhJkWA6gLMQV3t4NKqyl51D qvxU5DeNl94ggo/9aC3mCj52is7kGh/yzK0EKgBc5K5tkMpd7maN4wFGoP4J43vya/f3 9h7Jqg0OB5ernsml5w/LNNh7c1QVTU8pbciwcsN/6XoK/CNctBwqHjI2CY9M9E7WdKOS FbKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=Xwsb8jiyaild2kYluLo8AEpiz3AS6ZiqBAYFaXQHjRo=; fh=uCS3TgK5mo6P6f0iyyT3xHUvlQJSplbABS0vRw/n6d8=; b=jSuRSLpwvOT0NiIOQCP9RNw5WUCaugrW/xxWjL0wjAZhF8eMUbNxJJob7tbiLSBMWa q1JKvzohno5YG93hl81mF/6A2YCoTaRyRLpZ/RbTihBc41Q7Z/Z5m7MBaxwmYmcr0blB s3hT8m0Cs1V9TULA1b6gwTcBFfWi5Q/KQ8SAG6/ZjYqTxJbrrNiLkjkEtb+FURNOS/oE AAzwKHoTzeMylxduGDrj1HqVTYSn7cp1YPXJzJljbQuWey0+mo1MoFQmOwiUj4YFroEB T9ee7bqlv1yjcyYd7Dqbt9+HUWHbKog2YFA04cME3/OUX8kSUmzKyziSGU6nUuZzqNKF EZIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of yuinyee.chew@starfivetech.com designates 61.152.239.71 as permitted sender) smtp.mailfrom=yuinyee.chew@starfivetech.com Return-Path: Received: from smtp-mx-canonical-0.canonical.com (smtp-mx-canonical-0.canonical.com. [185.125.188.68]) by mx.google.com with ESMTPS id p20-20020a056a000b5400b00690bd178205si21320085pfo.215.2023.09.28.19.02.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 19:02:59 -0700 (PDT) Received-SPF: pass (google.com: domain of yuinyee.chew@starfivetech.com designates 61.152.239.71 as permitted sender) client-ip=61.152.239.71; Authentication-Results: mx.google.com; spf=pass (google.com: domain of yuinyee.chew@starfivetech.com designates 61.152.239.71 as permitted sender) smtp.mailfrom=yuinyee.chew@starfivetech.com Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=61.152.239.71; helo=fd01.gateway.ufhost.com; envelope-from=yuinyee.chew@starfivetech.com; receiver= X-Envelope-To: heinrich.schuchardt@canonical.com Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-mx-canonical-0.canonical.com (Postfix) with ESMTPS id A4E7A3F4C2 for ; Fri, 29 Sep 2023 02:02:52 +0000 (UTC) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 3D56C808F; Fri, 29 Sep 2023 10:02:41 +0800 (CST) Received: from EXMBX073.cuchost.com (172.16.6.83) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 29 Sep 2023 10:02:41 +0800 Received: from localhost.localdomain (202.188.176.82) by EXMBX073.cuchost.com (172.16.6.83) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 29 Sep 2023 10:02:37 +0800 From: John Chew To: CC: John Chew , Sunil V L , Li Yong , Heinrich Schuchardt , Leif Lindholm , Ard Biesheuvel , Abner Chang , Daniel Schaefer Subject: [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list Date: Fri, 29 Sep 2023 10:02:22 +0800 Message-ID: <20230929020222.2010-1-yuinyee.chew@starfivetech.com> X-Mailer: git-send-email 2.40.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-Originating-IP: [202.188.176.82] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX073.cuchost.com (172.16.6.83) X-YovoleRuleAgent: yovoleflag Update Gigadevice norflash list: gd25q16, gd25q32, gd25q64, gd25lq64c, gd25q128, gd25lq128, gd25q256 Add Silicon Kaiser norflash list: sk25lp128 Cc: Sunil V L Cc: Li Yong Cc: Heinrich Schuchardt Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: John Chew --- EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c b/Embedd= edPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c index e16c1c6a14..422fdac851 100644 --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c @@ -1,6 +1,7 @@ /** @file=0D *=0D * Copyright (c) 2017 Marvell International Ltd.=0D +* Copyright (c) 2023 StarFive, Technology Co., Ltd. All rights reserved.<= BR>=0D *=0D * SPDX-License-Identifier: BSD-2-Clause-Patent=0D *=0D @@ -33,12 +34,20 @@ STATIC CONST NOR_FLASH_INFO NorFlashIds[] =3D { { L"en25q128b", { 0x1c, 0x30, 0x18 }, 3, 256, 64 * 1024, 256, 0 = },=0D { L"en25s64", { 0x1c, 0x38, 0x17 }, 3, 256, 64 * 1024, 128, 0 = },=0D /* GIGADEVICE */=0D - { L"gd25q64b", { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024, 128, NOR= _FLASH_ERASE_4K },=0D + { L"gd25q16", { 0xc8, 0x40, 0x15 }, 3, 256, 64 * 1024, 32, NOR= _FLASH_ERASE_4K },=0D + { L"gd25q32", { 0xc8, 0x40, 0x16 }, 3, 256, 64 * 1024, 64, NOR= _FLASH_ERASE_4K },=0D { L"gd25lq32", { 0xc8, 0x60, 0x16 }, 3, 256, 64 * 1024, 64, NOR= _FLASH_ERASE_4K },=0D + { L"gd25q64b", { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024, 128, NOR= _FLASH_ERASE_4K },=0D + { L"gd25lq64c", { 0xc8, 0x60, 0x17 }, 3, 256, 64 * 1024, 128, NOR= _FLASH_ERASE_4K },=0D + { L"gd25q128", { 0xc8, 0x40, 0x18 }, 3, 256, 64 * 1024, 256, NOR= _FLASH_ERASE_4K },=0D + { L"gd25lq128", { 0xc8, 0x60, 0x18 }, 3, 256, 64 * 1024, 256, NOR= _FLASH_ERASE_4K },=0D + { L"gd25q256", { 0xc8, 0x40, 0x19 }, 3, 256, 64 * 1024, 512, NOR= _FLASH_ERASE_4K },=0D /* ISSI */=0D { L"is25lp032", { 0x9d, 0x60, 0x16 }, 3, 256, 64 * 1024, 64, 0 = },=0D { L"is25lp064", { 0x9d, 0x60, 0x17 }, 3, 256, 64 * 1024, 128, 0 = },=0D { L"is25lp128", { 0x9d, 0x60, 0x18 }, 3, 256, 64 * 1024, 256, 0 = },=0D + /* XINKAI / SILICON KAISER */=0D + { L"sk25lp128", { 0x27, 0x70, 0x18 }, 3, 256, 64 * 1024, 256, NOR= _FLASH_ERASE_4K },=0D /* MACRONIX */=0D { L"mx25l2006e", { 0xc2, 0x20, 0x12 }, 3, 256, 64 * 1024, 4, 0 = },=0D { L"mx25l4005", { 0xc2, 0x20, 0x13 }, 3, 256, 64 * 1024, 8, 0 = },=0D --=20 2.34.1 --------------uo7acVNVZRgJbs4jjP0YNOCY--