From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.6534.1588078087106071700 for ; Tue, 28 Apr 2020 05:48:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dHBe99qo; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588078086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dzwVeOF1p/CZmkxfTUfeQh33uGbR3gCwb3U+lTS2oC4=; b=dHBe99qoNvTrF3XXbu/A77eS00QM51cG91WFyfuKrMVvobCFBLclUmQmFGERLlJyoL9HBW /TCU0VpJW1F+NGxuXPskv4JmykP3f/6rjQuPzFQoYoS0pKFInbizigOnMz6XU4wDoqMvL+ 3z2V60q6+J5cNDrO0Ma6NMwNFn0bqnQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-47-KCh4DzPoPMSjaydCnHQtPA-1; Tue, 28 Apr 2020 08:48:04 -0400 X-MC-Unique: KCh4DzPoPMSjaydCnHQtPA-1 Received: by mail-wm1-f69.google.com with SMTP id 14so786996wmo.9 for ; Tue, 28 Apr 2020 05:48:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+v9A7Q8MTpOtI3vWO605nFixXpiAg44J3tF51iw0My8=; b=qMmlBReKcTarCma+Aa/ysLk0IKcuDl9+uIPR0f2figCkUF3j/bm01z/7KgNSj2VTDu H1c4Axe6yX2JU3h96oyiTXXqlc6NG3IxjlaLhwT3dYOSZ2g0eaUsCV2ykxWiGo2oppZ3 bWtg/lxqxxo0TUyxqTLGxYQX4rkIJiVfxF79gazLAhjNIGrBsZKrSdVwipnOm+danUju OhYGORhKzMi1e1aKF1xHhNMgo7Kyvk+C/MaNDVSILfXSBdO6Wu0eCL8nHQIEzuIBURhI /9QYAN7F9QI9KyYzvAi4grat743+bD4hDhd6hkyF/W+Q6PeJXSyKe3IUi/tPI+BjCUPU sF4A== X-Gm-Message-State: AGi0PuYDKaqlq6XDcoNs9OH4hI+UWcFFfKeZWdw2nhjv1CA0LVxqcGtS x3b3sSVW4O6+zO00MjiW0SUl2OLDucCQ/P1fq0R4ZhFmKkGAatCBW4OuPFvcu5jQny+mN7a3Kp4 zdJW3+WBTpqXiAQ== X-Received: by 2002:a05:6000:1008:: with SMTP id a8mr34062084wrx.189.1588078083547; Tue, 28 Apr 2020 05:48:03 -0700 (PDT) X-Google-Smtp-Source: APiQypK15d2WXWB8MaBRlqnUshU53dVOouas9lPNuoZZMOebQJmzvojwzT5Oaau+yOSDW2g3IulARw== X-Received: by 2002:a05:6000:1008:: with SMTP id a8mr34062073wrx.189.1588078083367; Tue, 28 Apr 2020 05:48:03 -0700 (PDT) Return-Path: Received: from [192.168.1.39] (137.red-88-21-205.staticip.rima-tde.net. [88.21.205.137]) by smtp.gmail.com with ESMTPSA id v7sm3774494wmg.3.2020.04.28.05.48.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2020 05:48:02 -0700 (PDT) Subject: Re: [PATCH 4/7] OvmfPkg/QemuFwCfgDxeLib: allow UEFI_DRIVER modules To: Laszlo Ersek , edk2-devel-groups-io Cc: Ard Biesheuvel , Jordan Justen , Per Sundstrom References: <20200424075353.8489-1-lersek@redhat.com> <20200424075353.8489-5-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <335bc443-68ed-a66a-f486-2bb50aae5d0c@redhat.com> Date: Tue, 28 Apr 2020 14:48:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200424075353.8489-5-lersek@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 4/24/20 9:53 AM, Laszlo Ersek wrote: > We don't distribute UEFI_DRIVER modules stand-alone that were built as > part of an OVMF platform. OVMF's UEFI_DRIVERs are allowed to inherit > platform dependencies. >=20 > By enabling UEFI_DRIVERs to consume QemuFwCfgDxeLib, we can hook > fw_cfg-based NULL class libraries into UEFI drivers, e.g. in order to set > dynamic PCDs. >=20 > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Per Sundstrom > Cc: Philippe Mathieu-Daud=C3=A9 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2681 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf b/OvmfPkg/L= ibrary/QemuFwCfgLib/QemuFwCfgDxeLib.inf > index c331c5e7220a..48899ff1236a 100644 > --- a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf > +++ b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf > @@ -16,7 +16,7 @@ [Defines] > FILE_GUID =3D 80474090-55e7-4c28-b25c-9f236ba41f= 28 > MODULE_TYPE =3D BASE > VERSION_STRING =3D 1.0 > - LIBRARY_CLASS =3D QemuFwCfgLib|DXE_DRIVER DXE_RUNTIME= _DRIVER DXE_SMM_DRIVER > + LIBRARY_CLASS =3D QemuFwCfgLib|DXE_DRIVER DXE_RUNTIME= _DRIVER DXE_SMM_DRIVER UEFI_DRIVER > =20 > CONSTRUCTOR =3D QemuFwCfgInitialize > =20 >=20 Reviewed-by: Philippe Mathieu-Daude