From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.65, mailfrom: philmd@redhat.com) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by groups.io with SMTP; Mon, 29 Apr 2019 05:26:50 -0700 Received: by mail-wr1-f65.google.com with SMTP id l2so79298wrb.9 for ; Mon, 29 Apr 2019 05:26:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PYAWljLTfwIgjrbYx2rSRaO403yZFoQHo8xVjM5ujHA=; b=GroL+w7Lzc7FqV/e4ujyqOGaNAwEIbkB3LAOUBC3Hk+h+n+XJ8/EbOAzKaHj0BG6BB d4wMUIa0g75vZOnWNSIkUePKqM1kAWVjFX52fODJnBAtNdR4YW7qLC1R6NzLSLvHwzaV T4/AGy8tIXL2T+GU/o7SRpEerY32Wi3i/zoaCXIWoscyko3PLoKN+3yk9WEFN0e9v6gZ MeEhhLxkivFNyVbbYeOQ+jeunx4BLh6NY2FDkAZ2tx6OcQbyxrSQKiIbUfZYykmrzqjt bfRZwHFPbsHrNfOIoNCNBOzBwL8Y7adkkKmk1GX98joEM/RYPMdXy47zLbCYItmhcESQ dXnA== X-Gm-Message-State: APjAAAXZrjTef8Gg/ACmiItkm6LKarrFdUMOjHAIRHNYZIjVByCXm5Bx o4e/pRcVSZe+VmmHSIhnG888Sw== X-Google-Smtp-Source: APXvYqzXEugYdBEmvzIXYXJKrvebw9PBlo7VeY3g4BBgwOWnZ+prsDEkQ/XgXaaAyqqcXwGwV07/pw== X-Received: by 2002:a5d:53c8:: with SMTP id a8mr17619181wrw.38.1556540808754; Mon, 29 Apr 2019 05:26:48 -0700 (PDT) Return-Path: Received: from [192.168.1.33] (193.red-88-21-103.staticip.rima-tde.net. [88.21.103.193]) by smtp.gmail.com with ESMTPSA id s17sm2590115wra.94.2019.04.29.05.26.47 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 29 Apr 2019 05:26:48 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 05/16] OvmfPkg/EnrollDefaultKeys: clean up minor whitespace wart To: devel@edk2.groups.io, lersek@redhat.com Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall References: <20190427005328.27005-1-lersek@redhat.com> <20190427005328.27005-6-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <3374736c-6ce4-d77c-c557-3b063b9105b8@redhat.com> Date: Mon, 29 Apr 2019 14:26:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190427005328.27005-6-lersek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/27/19 2:53 AM, Laszlo Ersek wrote: > In edk2, we should spell "#pragma pack(...)" with a space character in > front of the opening parenthesis. Fix up locations that suggest otherwise. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1747 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c b/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c > index b354ec6f81c8..aa827ac6aa81 100644 > --- a/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c > +++ b/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c > @@ -596,17 +596,17 @@ STATIC CONST EFI_GUID mMicrosoftOwnerGuid = { > // }; | > // > // Given that the "struct hack" invokes undefined behavior (which is why C99 > // introduced the flexible array member), and because subtracting those pesky > // sizes of 1 is annoying, and because the format is fully specified in the > // UEFI specification, we'll introduce two matching convenience structures that > // are customized for our X.509 purposes. > // > -#pragma pack(1) > +#pragma pack (1) > typedef struct { > EFI_TIME TimeStamp; > > // > // dwLength covers data below > // > UINT32 dwLength; > UINT16 wRevision; > @@ -627,17 +627,17 @@ typedef struct { > // SignatureSize covers data below > // > EFI_GUID SignatureOwner; > > // > // X.509 certificate follows > // > } REPEATING_HEADER; > -#pragma pack() > +#pragma pack () > > /** > Enroll a set of certificates in a global variable, overwriting it. > > The variable will be rewritten with NV+BS+RT+AT attributes. > > @param[in] VariableName The name of the variable to overwrite. > > Reviewed-by: Philippe Mathieu-Daude