Re: [edk2-devel] [PATCH v1 0/2] Add a new FdtNorFalshQemuLib and enable it in

["Chao Li" <lichao@loongson.cn>]

[-- Attachment #1: Type: text/plain, Size: 5772 bytes --]

Hi Ard and other maintainers,

Could you help to review this patch set?


Thanks,
Chao
On 2024/5/17 15:33, Chao Li wrote:
>
> Hi Ard,
>
> No, it's just that my email was bounced just now, the groupio didn't 
> receive my email when I send the first time, and I sent them again 
> after it unbounce.
>
> On 2024/5/17 15:21, Ard Biesheuvel wrote:
>> Hello Chao Li,
>>
>> You sent two series in quick succession. Is there any difference
>> between the two?
>>
>>
>> On Fri, 17 May 2024 at 09:17, Chao Li<lichao@loongson.cn>  wrote:
>>> Patch1: Added a new library called FdtNorFlashQemuLib in OvmfPkg/Library
>>> which is non-hardcode dependency.
>>> Patch2: Enable the new library in ArmVirtQemu.dsc and
>>> ArmVirtQemuKernel.dsc.
>>>
>>> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=4770
>>>
>>> I have verified on both of the two platforms:
>>> Prepare:
>>> install libvirt, virt-manager, qemu-systemaarch64.
>>>
>>> Step 1:
>>> Built the two platforms with ArmVirtQemu.dsc and
>>> ArmVirtQemuKernel.dsc, and then using the command create the pflash
>>> files:
>>> Build the two platforms firmware using ArmVirtQemu.dsc and
>>> ArmVirtQemuKernel.dsc, and then create the pflash files using following
>>> command:
>>> cat QEMU_EFI.fd  /dev/zero | head -c 64m > ./QEMU_EFI-pflash.raw
>>> cat QEMU_VARS.fd  /dev/zero | head -c 64m > ./vars-template-pflash.raw
>>> qemu-img convert -f raw -O qcow2 -o cluster_size=4096 -S 4096 QEMU_EFI-pflash.raw  QEMU_EFI-pflash.qcow2
>>> qemu-img convert -f raw -O qcow2 -o cluster_size=4096 -S 4096 vars-template-pflash.raw vars-template-pflash.qcow2
>>>
>>> Download a AARCH64 QCOW2 image.
>>> Copy them into /usr/share/edk2/aarch64/.
>>>
>>> Step 2:
>>> Verification the pflash working:
>>> ArmVirtQemu:
>>> Run the QEMU ARM virt machine using the following command:
>>> qemu-system-aarch64 \
>>>      -blockdev '{"driver":"file","filename":"/usr/share/edk2/aarch64/QEMU_EFI-pflash.qcow2","node-name":"libvirt-pflash0-storage","auto-read-only":true,"discard":"unmap"}' \
>>>      -blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver":"qcow2","file":"libvirt-pflash0-storage"}' \
>>>      -blockdev '{"driver":"file","filename":"/usr/share/edk2/aarch64/vars-template-pflash.qcow2","node-name":"libvirt-pflash1-storage","auto-read-only":true,"discard":"unmap"}' \
>>>      -blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver":"qcow2","file":"libvirt-pflash1-storage"}' \
>>>      -machine virt,pflash0=libvirt-pflash0-format,pflash1=libvirt-pflash1-format,acpi=on \
>>>      -cpu cortex-a57 \
>>>      -m size=2097152k \
>>>      -serial stdio \
>>>      -net none \
>>>      -device ramfb \
>>>      -device nec-usb-xhci \
>>>      -device usb-mouse \
>>>      -device usb-kbd
>>>
>>> ArmVirtQemuKernel:
>>> Run the QEMU kernel ARM virt machine using the following command:
>>> qemu-system-aarch64 \
>>>      -blockdev '{"driver":"file","filename":"/usr/share/edk2/aarch64/vars-template-pflash.raw","node-name":"libvirt-pflash1-storage","auto-read-only":true,"discard":"unmap"}' \
>>>      -blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver":"raw","file":"libvirt-pflash1-storage"}' \
>>>      -machine virt,usb=off,dump-guest-core=off,gic-version=3,pflash1=libvirt-pflash1-format \
>>>      -cpu cortex-a57 \
>>>      -m 4096 \
>>>      -smp 1,sockets=1,cores=1,threads=1 \
>>>      -no-user-config \
>>>      -nodefaults \
>>>      -device virtio-gpu-pci \
>>>      -kernel /usr/share/edk2/aarch64/QEMU_EFI-pflash.raw \
>>>      -serial stdio \
>>>      -device nec-usb-xhci \
>>>      -device usb-mouse \
>>>      -device usb-kbd  \
>>>      -hda /usr/share/edk2/aarch64/openEuler-22.03-LTS-SP3-aarch64.qcow2 \
>>>      -monitor tcp::3333,server,nowait
>>>
>>> Step 3:
>>> After the virt-machines starts, enter "F2" to enter the setup UI, try to
>>> change the boot order or some ther variables stored in the flash, then
>>> enter "F10" to save the changes and reboot it.
>>> After restarting, enter "F2" to enter the setup UI and check whether the
>>> changes before the restart operation have been saved.
>>>
>>>
>>> Using the above three steps, both platforms will works fine.
>>>
>>> I have not created the PR in github yet, I will create it once the edk2
>>> merge window reopens.
>>>
>>> Cc: Ard Biesheuvel<ardb+tianocore@kernel.org>
>>> Cc: Leif Lindholm<quic_llindhol@quicinc.com>
>>> Cc: Sami Mujawar<sami.mujawar@arm.com>
>>> Cc: Gerd Hoffmann<kraxel@redhat.com>
>>> Cc: Jiewen Yao<jiewen.yao@intel.com>
>>>
>>> Chao Li (2):
>>>    OvmfPkg: Add no hardcode version of FtdNorFlashQemuLib
>>>    ArmVirtPkg: Enable the non-hardcode version FtdNorFlashQemuLib
>>>
>>>   ArmVirtPkg/ArmVirtQemu.dsc                    |  21 ++-
>>>   ArmVirtPkg/ArmVirtQemuKernel.dsc              |  20 ++-
>>>   ArmVirtPkg/VarStore.fdf.inc                   |   5 +-
>>>   .../FdtNorFlashQemuLib/FdtNorFlashQemuLib.c   | 165 ++++++++++++++++++
>>>   .../FdtNorFlashQemuLib/FdtNorFlashQemuLib.inf |  46 +++++
>>>   5 files changed, 249 insertions(+), 8 deletions(-)
>>>   create mode 100644 OvmfPkg/Library/FdtNorFlashQemuLib/FdtNorFlashQemuLib.c
>>>   create mode 100644 OvmfPkg/Library/FdtNorFlashQemuLib/FdtNorFlashQemuLib.inf
>>>
>>> --
>>> 2.27.0
>>>
>>>
>>>
>>>
>>>
>>>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119250): https://edk2.groups.io/g/devel/message/119250
Mute This Topic: https://groups.io/mt/106149594/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 7718 bytes --]