From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com [40.107.2.84]) by mx.groups.io with SMTP id smtpd.web11.7025.1666787828815383093 for ; Wed, 26 Oct 2022 05:37:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=gpdhOLeY; spf=pass (domain: arm.com, ip: 40.107.2.84, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hHQg7wSmESrmCZnlPh3Tgj2oh/m0YqYpz08Brywn5WSZuzMkcbvp/wXj4oOjsMFQtfWAx1f0D7B/irGAa0wjAflcl/2Z8Jxi2e4Y6hVKuysZ1dwvjSH2abYJCbgHey7uFYNl1mUQJhF5ZfGkgpJaXGBN3Ak58ZCbbY83pAv/y7DRT9hW8HaTG+sejbmoaIvAC/9pXqqtO4RQ0UXq/UK1Q+hqYiCasODHc52Wrdv8qHOifUfLzpL/KbCSDJTCt1bd9GWRxLerT+/Xp1H9QNn8lhJvrkoV2CVFZ8yGOZzslwIg6a16UrFRp0MaYOBsPgcJ3lqVCM4TT1sprF4P00KIKA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VXS8010EooZ63LXwlxqSKIBsjd+5+z0qgkXqUa2nwBU=; b=I5qlgRNzh1VzMmodvldW/VEI0GV2vaMV+gcJ+hoyqEZthJJ9lYwOi5T8rTlHt8X8zRqd3YpEprXr5ktx91xX2DUM9Qfp06Y06GKr06Erh1vQX6yYlr7SR4SQSc2GAlSpDcI7s9dtGdHbRXX4kSRFy910fEjfDJCU3LZP1bTIVtEOCguIvis0I/hQdOsHPll3C3O+fioT51A7v7AA+7RKbR2prPV8kjbf+V5Lho0E2VoEIrwecG6F5e1XCt47KULgxdhsu1OJT6XFsUqt31Wh5Xm8mvdhXMLdpI6qwCRFQF+uKlRIjPjQGpxztpfRiXIhxwiPZNTaULcdWih78EhfTw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VXS8010EooZ63LXwlxqSKIBsjd+5+z0qgkXqUa2nwBU=; b=gpdhOLeYpTQgSdWg+gC3LZk7s/tmgpGfyUkQspt5vV1HhQwZ0p34BPE7IWroCmtJXy0/kqwoY85+j9Y8J0kqsCKNxDo8P4WfvZXbhAmIFs3/V9uZYtG+E7DtB57V9LF2ycBJw4Ppyf2fUBgFKO3g34wrG2w6piIUCbargtARLNE= Received: from AM6PR10CA0066.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::43) by PAVPR08MB9436.eurprd08.prod.outlook.com (2603:10a6:102:316::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Wed, 26 Oct 2022 12:37:04 +0000 Received: from VI1EUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:80:cafe::d6) by AM6PR10CA0066.outlook.office365.com (2603:10a6:209:80::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend Transport; Wed, 26 Oct 2022 12:37:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT018.mail.protection.outlook.com (100.127.144.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.16 via Frontend Transport; Wed, 26 Oct 2022 12:37:03 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Wed, 26 Oct 2022 12:37:03 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: af388b320282a14c X-CR-MTA-TID: 64aa7808 Received: from 9911b4b26022.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 232ADF03-5E44-4FB1-9454-D5E25476DE1D.1; Wed, 26 Oct 2022 12:36:56 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9911b4b26022.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 26 Oct 2022 12:36:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ki/DCFxEQum1/klzMWv/eZc47bTj1xBScflSXAhM3GCE/f0mWt5p8EByHYiIjf3yVivQ1vVvGgPQFc4o1hVMiQZwUcuVJC6lkmPc4fFm2V+wxT2gTk9QlOZ2xQzEM9X8cWzCQ+h7lTEUPxVbgG43L2HbSoypEm0nBCSNrBb/PScByqB9j/rVdvTvdQb/wNsniu7N7OnI1u3LU32IsmnXDgOlCPT6o2pXSVLx6oWa/s243wJQqGwUPQdDibc0nAOoTxVfm7salUQT8lnDcB/gFEUGL16g6bf+EM4Ug5U827PMn+o6/vwkJZfqV2A/+gU/lQJ+pTmW61X248j1cQkm3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VXS8010EooZ63LXwlxqSKIBsjd+5+z0qgkXqUa2nwBU=; b=iWNGmgQRGRZU4ow5dLWqkfGUsjLQQMqPHAUj5B8IoKdJbuGxK3OYdvwpD73oz2/QWtQvbahrITXuN0qpaakYYy0Dvq6CqcIlF947kftCAyYxeuxXJfEvt1tpHgQrlloh3aajf4y8DomoYU5JYGIlJreg0+7TF2U4Hg+n4MMelru34ee4N5r5PWROQJOZ6/jrnVTtYPcMEHbFnF1XZdyAqjkOmuIJd/UYY5PgejUpHVoCt35lHBx05ahKXslU9nl71eZuGqvn4A8QdVO77kiWsPThtrHFFK1GDs4FQihtpyTOTlDfRA4pqyPkpAjWpzy/5U03DfVpTYzh8gLeG+vSIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VXS8010EooZ63LXwlxqSKIBsjd+5+z0qgkXqUa2nwBU=; b=gpdhOLeYpTQgSdWg+gC3LZk7s/tmgpGfyUkQspt5vV1HhQwZ0p34BPE7IWroCmtJXy0/kqwoY85+j9Y8J0kqsCKNxDo8P4WfvZXbhAmIFs3/V9uZYtG+E7DtB57V9LF2ycBJw4Ppyf2fUBgFKO3g34wrG2w6piIUCbargtARLNE= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PAXPR08MB6398.eurprd08.prod.outlook.com (2603:10a6:102:12d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Wed, 26 Oct 2022 12:36:55 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf%5]) with mapi id 15.20.5746.027; Wed, 26 Oct 2022 12:36:55 +0000 Message-ID: <33852e3c-2a7e-5728-8541-47dcbc4b8e45@arm.com> Date: Wed, 26 Oct 2022 13:36:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 04/14] DynamicTablesPkg: Update CmObjParser for MinorRevision To: Pierre.Gondois@arm.com, devel@edk2.groups.io Cc: Alexei Fedorov , "nd@arm.com" References: <20221010092058.118714-1-Pierre.Gondois@arm.com> <20221010092058.118714-5-Pierre.Gondois@arm.com> From: "Sami Mujawar" In-Reply-To: <20221010092058.118714-5-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO4P123CA0212.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::19) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|PAXPR08MB6398:EE_|VI1EUR03FT018:EE_|PAVPR08MB9436:EE_ X-MS-Office365-Filtering-Correlation-Id: 51320224-f2cf-4a94-abdc-08dab74ec940 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 48f3pMzMDS2FH3eBwF3oVSj+gbNBEEbXmtI1KTvaJ+0dbkurN1KuByD/SMmGDCD9raCFkB5x2/y+OFa0Im/X6i5iyFll++6G2AGTCErwZdHHS5EaN5rmTSptpmb7M67ilDvJZiOB4W8vKbx1yb4Ocxp/TD/MgddrkylG5wQG9F9OnhLydj8ggO/cghTYL0pmVD/2l8lN3GWxLjAvFY8mHXGnILiaqChTB9taFp6ouV0Ls7QCgpiQJ+MmhX8tThyXMgbIU0IDEeht2EtN7kVHNJEC75zVd6dyOI1j91W0lsc8Dm3meeM/G5eMKhHRlFZtDkFqLLHAMVsneKTQZ3KK4ThAi5OZzKutSXcks7A987OQyf+1RPQkceMOh4Mt/4A7ukG4Y9XGotYvrQC4aRFZ/d+SU1GCmvZfbO7ImNFLCFjhX3+zsxIrW7OaP91cArlsL+afiUkSsFdxJH0dvRoynwbM1LfYGuMRELwKMLEt0L+7AkxuooKMgryycqpOZFfvVZaLe40JQQtmPd4rsA/ntBlMfdt4ouD8NfYXpYkevXwe9IA0iRdeAr5mPfknpZ1IRXlU0v0RZCSYyuixxFNQc2fEInBAaFFZK2krBX3Mq3XgrFFXqLt6uMmwDkIQF7CG4GO6oIp1+fUINPpw9zGWYcY9Vl1AgDvbbDfBk8jWuo9rv73O8f8LWvnyx4b9PyinsB/avD1+xpj7dGxXBSLjqI8lDt5o7G3/aAdB6cfT5KClC0tDiVrFdtN3IQPfATrN2c92YyLOukP72AAfCbqLP5rNEYgqxWgdZmp2Yi5lGoM= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(4636009)(136003)(376002)(346002)(366004)(39860400002)(396003)(451199015)(83380400001)(66556008)(86362001)(38100700002)(31696002)(66476007)(8936002)(66946007)(5660300002)(44832011)(8676002)(6506007)(4326008)(41300700001)(2906002)(53546011)(6486002)(36756003)(26005)(2616005)(6512007)(54906003)(316002)(478600001)(31686004)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6398 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a754ae1f-8ba0-4af3-227a-08dab74ec3d8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YEhKbOgQBpyaFtLZLTrpAFy0sBg1TbkGViUMU6wF+peU1TtomdJsW1QLDrxMJxFbC+wecV23Yb5cQraF0DRWHLFb+JESLqTI97+vn9ZvcnFY3cjIyKoujiMrtx2L9hMDXZC8whJLU826KNZlS/ACc4kW/qeT7mW0+NunBBBDCDVA0QQz7F7b8pVX9Y3u3rWjnusbBPnRZhTbRTOLITX7ZF148iwwOX2j+ynZhXl8+B0EHwk3TosgGDFRzS2XNVELO+AU/sTX/gZqjL3pKBPE0bG428EgvLx6N7bJHYAFaZ+sHmNkPNvJGOcWRbXtlwq+xsZ7ldNxnSHoC4z7turKh0KJxzrcrlP9BiakKDSKPCo/qm+zgpIw8I6VyKxHiigCUXHvJAFvuTdKKtGBbQ7plfWpq4DwpBoNHt3MEDUTIl9uHpKR9TdbVwvsStRAeMnbO8BQ2rSK68fGV17vfmlueVGbxQI0oB4T8nmP0qdb1dR5QDavr4DV63fs9hHVGkJQ+0+LBhT08N/u87xx/gp4zlIBXJLyLTBUZQx2Jkk8vk+QkATiqzwPECiqDt/eQRPsBQKMwFj+W0dPIw5XL6sKJ3BICfx/Y2rnTEy1JRzLzWgKKpunSTbNAT/zLSkmeGnMlpx/m+jZ940AJsN2nPzFC2TdeylHAStHAMFi6Z1Kh5UsZaUN2SHQ/wQX0qplU3fG4rjuNFBdb9XvUWJjIYsI7yF1PJKz2vjG5XPJ8mOzshKHJCq3NEMjwfWdi1ZhjQtb0WH4zRCFrn8pk11g6EYKSnNIIw5qtqoAsb/pHraS3eyQtY0t/cXAUdO8CVuFahWo X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(6029001)(4636009)(396003)(346002)(376002)(136003)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(40460700003)(356005)(40480700001)(31696002)(36756003)(36860700001)(82740400003)(81166007)(86362001)(70206006)(8676002)(4326008)(316002)(54906003)(44832011)(2906002)(70586007)(41300700001)(8936002)(2616005)(186003)(47076005)(336012)(5660300002)(83380400001)(26005)(6486002)(6512007)(82310400005)(478600001)(6506007)(53546011)(31686004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:37:03.7199 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 51320224-f2cf-4a94-abdc-08dab74ec940 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9436 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/10/2022 10:20 am, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > commit 0d23c447d6f5 ("DynamicTablesPkg: Add support to specify FADT > minor revision") > adds new 'MinorRevision' field to CM_STD_OBJ_ACPI_TABLE_INFO. > Reflect the change in this patch to the CmObjectParser. > > Signed-off-by: Pierre Gondois > --- > .../Common/TableHelperLib/ConfigurationManagerObjectParser.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > index 80ebb0708661..f82541240ae0 100644 > --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > @@ -639,7 +639,8 @@ STATIC CONST CM_OBJ_PARSER StdObjAcpiTableInfoParser[] = { > { "TableGeneratorId", sizeof (ACPI_TABLE_GENERATOR_ID), "0x%x", NULL }, > { "AcpiTableData", sizeof (EFI_ACPI_DESCRIPTION_HEADER *), "0x%p", NULL }, > { "OemTableId", 8, "0x%LLX", NULL }, > - { "OemRevision", 4, "0x%x", NULL } > + { "OemRevision", 4, "0x%x", NULL }, > + { "MinorRevision", 1, "0x%x", NULL }, > }; > > /** A parser for EStdObjSmbiosTableList.