From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io, sami.mujawar@arm.com
Cc: Alexei.Fedorov@arm.com, Matteo.Carlini@arm.com,
Ben.Adderson@arm.com, ray.ni@intel.com, zhichao.gao@intel.com,
nd@arm.com
Subject: Re: [edk2-devel] [PATCH v2 3/8] ShellPkg: Acpiview: Abbreviate field names to preserve alignment
Date: Fri, 15 Oct 2021 14:33:08 +0100 [thread overview]
Message-ID: <33861100-833d-369b-8367-b072b2ba4047@arm.com> (raw)
In-Reply-To: <20210617095538.93280-4-sami.mujawar@arm.com>
Hi Sami,
The patch looks good to me:
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
Regards,
Pierre
On 6/17/21 10:55, Sami Mujawar via groups.io wrote:
> Some field names in the IORT table parser were longer than the
> OUTPUT_FIELD_COLUMN_WIDTH plus indentation, resulting in loss of
> the output print alignment. Therefore, abbreviate the field names.
>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
>
> Notes:
> v2:
> - No code change since v1. Re-sending with v2 series. [SAMI]
>
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> index f7447947b2308d35d4d2890373778f0fd2f97f9e..fcecaff5134256497bda87241f339076897c3ece 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> @@ -1,11 +1,14 @@
> /** @file
> IORT table parser
>
> - Copyright (c) 2016 - 2020, ARM Limited. All rights reserved.
> + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @par Reference(s):
> - - IO Remapping Table, Platform Design Document, Revision D, March 2018
> + - IO Remapping Table, Platform Design Document, Revision D, March 2018
> +
> + @par Glossary:
> + - Ref - Reference
> **/
>
> #include <IndustryStandard/IoRemappingTable.h>
> @@ -144,15 +147,15 @@ STATIC CONST ACPI_PARSER IortNodeSmmuV1V2Parser[] = {
> {L"Span", 8, 24, L"0x%lx", NULL, NULL, NULL, NULL},
> {L"Model", 4, 32, L"%d", NULL, NULL, NULL, NULL},
> {L"Flags", 4, 36, L"0x%x", NULL, NULL, NULL, NULL},
> - {L"Reference to Global Interrupt Array", 4, 40, L"0x%x", NULL, NULL, NULL,
> + {L"Global Interrupt Array Ref", 4, 40, L"0x%x", NULL, NULL, NULL,
> NULL},
> {L"Number of context interrupts", 4, 44, L"%d", NULL,
> (VOID**)&InterruptContextCount, NULL, NULL},
> - {L"Reference to Context Interrupt Array", 4, 48, L"0x%x", NULL,
> + {L"Context Interrupt Array Ref", 4, 48, L"0x%x", NULL,
> (VOID**)&InterruptContextOffset, NULL, NULL},
> {L"Number of PMU Interrupts", 4, 52, L"%d", NULL,
> (VOID**)&PmuInterruptCount, NULL, NULL},
> - {L"Reference to PMU Interrupt Array", 4, 56, L"0x%x", NULL,
> + {L"PMU Interrupt Array Ref", 4, 56, L"0x%x", NULL,
> (VOID**)&PmuInterruptOffset, NULL, NULL},
>
> // Interrupt Array
next prev parent reply other threads:[~2021-10-15 13:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 9:55 [PATCH v2 0/8] IORT Rev E.b specification updates Sami Mujawar
2021-06-17 9:55 ` [PATCH v2 1/8] MdePkg: Fix IORT header file include guard Sami Mujawar
2021-06-17 18:19 ` Michael D Kinney
2021-06-21 11:08 ` [edk2-devel] " Sami Mujawar
2021-06-17 9:55 ` [PATCH v2 2/8] MdePkg: IORT header update for IORT Rev E.b spec Sami Mujawar
2021-06-28 7:53 ` Gao, Zhichao
2021-10-15 14:45 ` [edk2-devel] " PierreGondois
2021-06-17 9:55 ` [PATCH v2 3/8] ShellPkg: Acpiview: Abbreviate field names to preserve alignment Sami Mujawar
2021-06-28 7:53 ` Gao, Zhichao
2021-10-15 13:33 ` PierreGondois [this message]
2021-06-17 9:55 ` [PATCH v2 4/8] ShellPkg: Acpiview: IORT parser update for IORT Rev E.b spec Sami Mujawar
2021-06-28 7:53 ` Gao, Zhichao
2021-06-17 9:55 ` [PATCH v2 5/8] DynamicTablesPkg: IORT set reference to Id array only if present Sami Mujawar
2021-10-15 15:22 ` [edk2-devel] " PierreGondois
2021-06-17 9:55 ` [PATCH v2 6/8] DynamicTablesPkg: IORT set reference to interrupt array " Sami Mujawar
2021-10-18 15:48 ` [edk2-devel] " PierreGondois
2021-06-17 9:55 ` [PATCH v2 7/8] DynamicTablesPkg: Update ArmNameSpaceObjects for IORT Rev E.b Sami Mujawar
2021-10-18 15:59 ` [edk2-devel] " PierreGondois
2021-10-18 16:00 ` PierreGondois
2021-06-17 9:55 ` [PATCH v2 8/8] DynamicTablesPkg: IORT generator updates for Rev E.b spec Sami Mujawar
2021-10-18 16:17 ` [edk2-devel] " PierreGondois
2021-06-18 0:49 ` 回复: [edk2-devel] [PATCH v2 0/8] IORT Rev E.b specification updates gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33861100-833d-369b-8367-b072b2ba4047@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox