From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=01590ee411=brian.johnson@hpe.com) Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by groups.io with SMTP; Fri, 13 Sep 2019 11:09:52 -0700 Received: from pps.filterd (m0148663.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8DI32cC019165; Fri, 13 Sep 2019 18:09:51 GMT Received: from g4t3426.houston.hpe.com (g4t3426.houston.hpe.com [15.241.140.75]) by mx0a-002e3701.pphosted.com with ESMTP id 2v0g2404v8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Sep 2019 18:09:51 +0000 Received: from g9t2301.houston.hpecorp.net (g9t2301.houston.hpecorp.net [16.220.97.129]) by g4t3426.houston.hpe.com (Postfix) with ESMTP id 8142E65; Fri, 13 Sep 2019 18:09:50 +0000 (UTC) Received: from [10.33.152.19] (bjj-laptop2.americas.hpqcorp.net [10.33.152.19]) by g9t2301.houston.hpecorp.net (Postfix) with ESMTP id 1C9FB5C; Fri, 13 Sep 2019 18:09:49 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Entend the support keyboard type of Terminal console To: devel@edk2.groups.io, hao.a.wu@intel.com, "Gao, Zhichao" Cc: "Wang, Jian J" , "Ni, Ray" References: <20190912010231.19544-1-zhichao.gao@intel.com> <20190912010231.19544-2-zhichao.gao@intel.com> From: "Brian J. Johnson" Message-ID: <338af65b-88ef-88d6-fc51-b9e228d6205d@hpe.com> Date: Fri, 13 Sep 2019 13:09:49 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 In-Reply-To: X-Proofpoint-UnRewURL: 5 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-13_08:2019-09-11,2019-09-13 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 clxscore=1011 mlxlogscore=999 suspectscore=0 spamscore=0 priorityscore=1501 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1909130184 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/11/19 9:42 PM, Wu, Hao A wrote: >> -----Original Message----- >> From: Gao, Zhichao >> Sent: Thursday, September 12, 2019 9:02 AM >> To: devel@edk2.groups.io >> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray >> Subject: [PATCH 1/3] MdeModulePkg: Entend the support keyboard type of >> Terminal console > > > Hello, > > Entend -> Extend > > >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186 >> >> A common terminal console software Putty support various types of >> keyboard type, such as normal mode, Linux mode, Xterm R6, Vt400, >> VT100+ and SCO. Refer to the link: >> https://www.ssh.com/ssh/putty/putty-manuals/0.68/Chapter4.html#config- >> funkeys >> >> Cc: Jian J Wang >> Cc: Hao A Wu >> Cc: Ray Ni >> Signed-off-by: Zhichao Gao >> --- >> .../Include/Guid/TerminalConExtendedType.h | 25 >> +++++++++++++++++++ >> MdeModulePkg/MdeModulePkg.dec | 6 +++++ >> 2 files changed, 31 insertions(+) >> create mode 100644 >> MdeModulePkg/Include/Guid/TerminalConExtendedType.h >> >> diff --git a/MdeModulePkg/Include/Guid/TerminalConExtendedType.h >> b/MdeModulePkg/Include/Guid/TerminalConExtendedType.h >> new file mode 100644 >> index 0000000000..18667413e8 >> --- /dev/null >> +++ b/MdeModulePkg/Include/Guid/TerminalConExtendedType.h >> @@ -0,0 +1,25 @@ >> +/** @file >> + GUID definition for Linux, XtermR6, Vt400 and SCO terminal type. >> + >> + >> + Copyright (c) 2019, Intel Corporation. All rights reserved.
>> + SPDX-License-Identifier: BSD-2-Clause-Patent >> + >> +**/ >> + >> +#ifndef __TERMINAL_CON_EXTENDED_TYPE_H__ >> +#define __TERMINAL_CON_EXTENDED_TYPE_H__ >> + >> +#define EDKII_LINUX_MODE_GUID \ >> + { 0xe4364a7f, 0xf825, 0x430e, { 0x9d, 0x3a, 0x9c, 0x9b, 0xe6, 0x81, 0x7c, >> 0xa5 } } >> + >> +#define EDKII_XTERM_R6_GUID \ >> + { 0xfbfca56b, 0xbb36, 0x4b78, { 0xaa, 0xab, 0xbe, 0x1b, 0x97, 0xec, 0x7c, >> 0xcb } } >> + >> +#define EDKII_VT400_GUID \ >> + { 0x8e46dddd, 0x3d49, 0x4a9d, { 0xb8, 0x75, 0x3c, 0x08, 0x6f, 0x6a, 0xa2, >> 0xbd } } >> + >> +#define EDKII_SCO_GUID \ >> + { 0xfc7dd6e0, 0x813c, 0x434d, { 0xb4, 0xda, 0x3b, 0xd6, 0x49, 0xe9, 0xe1, >> 0x5a } } >> + > > > I would suggest to add corresponding GUID declarations just as what has been > done in: > > MdePkg/Include/Guid/PcAnsi.h > MdeModulePkg/Include/Guid/TtyTerm.h > > >> +#endif >> diff --git a/MdeModulePkg/MdeModulePkg.dec >> b/MdeModulePkg/MdeModulePkg.dec >> index 17beb45235..7528d52fcb 100644 >> --- a/MdeModulePkg/MdeModulePkg.dec >> +++ b/MdeModulePkg/MdeModulePkg.dec >> @@ -343,6 +343,12 @@ >> ## Include/Guid/TtyTerm.h >> gEfiTtyTermGuid = { 0x7d916d80, 0x5bb1, 0x458c, {0xa4, 0x8f, 0xe2, >> 0x5f, 0xdd, 0x51, 0xef, 0x94 }} >> >> + ## Include/Guid/TerminalConExtendedType.h >> + gEdkiiLinuxModeGuid = { 0xe4364a7f, 0xf825, 0x430e, { 0x9d, 0x3a, >> 0x9c, 0x9b, 0xe6, 0x81, 0x7c, 0xa5 } } >> + gEdkiiXtermR6Guid = { 0xfbfca56b, 0xbb36, 0x4b78, { 0xaa, 0xab, >> 0xbe, 0x1b, 0x97, 0xec, 0x7c, 0xcb } } >> + gEdkiiVT400Guid = { 0x8e46dddd, 0x3d49, 0x4a9d, { 0xb8, 0x75, 0x3c, >> 0x08, 0x6f, 0x6a, 0xa2, 0xbd } } >> + gEdkiiSCOGuid = { 0xfc7dd6e0, 0x813c, 0x434d, { 0xb4, 0xda, 0x3b, >> 0xd6, 0x49, 0xe9, 0xe1, 0x5a } } >> + > > > After this patch, there will be 3 header files that describe different terminal > modes supported in TerminalDxe driver: > > MdePkg/Include/Guid/PcAnsi.h (PcAnsi, VT100, VT100+, VTUTF8) > MdeModulePkg/Include/Guid/TtyTerm.h (TtyTerm) > MdeModulePkg/Include/Guid/TerminalConExtendedType.h (Linux, Xterm R6, Vt400, SCO) > > Do we have a plan to add those 5 non-UEFI modes in the UEFI spec? > Yes, it's frustrating that the UEFI spec doesn't specify a serial terminal type which is in common use. TtyTerm helped quite a lot with practical usability... these new terminal types should help even more. Thanks, Brian Johnson > If not, I am wondering is it possible to at least merge TtyTerm.h and > TerminalConExtendedType.h into one file so that we can avoid introducing new > header files every time new terminal modes are being added. > > Best Regards, > Hao Wu > > >> ## Include/Guid/HiiBootMaintenanceFormset.h >> gEfiIfrBootMaintenanceGuid = { 0xb2dedc91, 0xd59f, 0x48d2, { 0x89, 0x8a, >> 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }} >> >> -- >> 2.21.0.windows.1 > > > > -- Brian J. Johnson Enterprise X86 Lab Hewlett Packard Enterprise