Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for *.makefile

Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for *.makefile

[Rebecca Cran]

Pull Request: https://github.com/tianocore/edk2/pull/4176

Branch: https://github.com/bcran/edk2/tree/patchcheck_makefiles


On 3/24/23 10:32 AM, Rebecca Cran wrote:
> When checking for Makefiles, in addition to Makefile and GNUmakefile,
> also check for *.makefile: this allows {header,footer,app,lib}.makefile
> in BaseTools/Source/C/Makefiles to be detected and avoid having
> PatchCheck.py complain about tab characters.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>   BaseTools/Scripts/PatchCheck.py | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
> index fcdabfc8acea..3910015d173e 100755
> --- a/BaseTools/Scripts/PatchCheck.py
> +++ b/BaseTools/Scripts/PatchCheck.py
> @@ -383,7 +383,8 @@ class GitDiffCheck:
>                       self.force_crlf = False
>                       self.force_notabs = False
>                   if os.path.basename(self.filename) == 'GNUmakefile' or \
> -                   os.path.basename(self.filename) == 'Makefile':
> +                   os.path.basename(self.filename) == 'Makefile' or \
> +                   os.path.basename(self.filename).endswith("makefile"):
>                       self.force_notabs = False
>               elif len(line.rstrip()) != 0:
>                   self.format_error("didn't find diff command")