From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mx.groups.io with SMTP id smtpd.web11.4102.1679681562551507567 for ; Fri, 24 Mar 2023 11:12:43 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm3 header.b=Z4If0u/9; spf=pass (domain: bsdio.com, ip: 64.147.123.21, mailfrom: rebecca@bsdio.com) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 05D313200077; Fri, 24 Mar 2023 14:12:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 24 Mar 2023 14:12:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1679681560; x=1679767960; bh=Xqc2L8AMGfI5X50dXwfQQThY1g3837nlVQR qEx2a/PU=; b=Z4If0u/9H2h0oqFgORuQnuJmiruxQNwQrGZNjLHoEm2oqCcjQKl bNlfUlnL3QzK1WMEtKg47Dmbk35HQeyoYB4FC0TNKR6rzbKPddghtpUT1d/futrL iXdVa0i+0KAFIibnBXbS7I6UEOQNprvNqcMUAse3/C6ecpaUG3J1gRsoT80gw+iC OYPeFRc7F2ZdNEePmEM3u4enjMoPessCykQ1u3x4V16UF8pwhfKtGCUx/OnME7NZ GQefM5dMez0dfdVjZmwOQYdjs9LPm4BEsOMvcxK/Id+HQd63J4Sye6nKiuzYJspc /4haoeX/pF8AfWQGnKLj9oLxpcMvnzkOOyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1679681560; x= 1679767960; bh=Xqc2L8AMGfI5X50dXwfQQThY1g3837nlVQRqEx2a/PU=; b=K Kp7KBZKPU2mE0bszODeRLA1WetBGaFT+YsZnhIZlB3csEi17VLKM1bVHab1zmqmb tgNPdewl5PCwiE+x7MgwkWEn2F2Pb4hs8sVK8VnB5PLLcVPnumboI2CaBDAR7udk GIiGSbPoDtX52rqtUgMzyTKmhTnf8DwQb9zo9fgwkj25msvltOhfJbukKolzqkOu z/TMNbgsVttFMefS6lfkMe4YMhp20gwWkfIYa9d1ajJdQ8Vy0tSivW2bd0AQn1hR Si9BqbxlEUJ5615Xo7cf4opAzkoYlQKN3RIzc60HObrdx6D7UtHtFhlIyOnAbdBz 7MIKulMp8hfzNjbD1zvNg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegiedgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeetheejvefhjeeutefhtdeivedugedvjeekfeeiteeiveelieefgedvgefh leeggfenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughiohdrtgho mh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Mar 2023 14:12:39 -0400 (EDT) Message-ID: <338e8c7b-4722-a4a4-55d7-caaa40f8aa89@bsdio.com> Date: Fri, 24 Mar 2023 12:12:37 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for *.makefile To: devel@edk2.groups.io, Bob Feng , Liming Gao , Yuwei Chen , Michael D Kinney References: <174F680216543AB6.25304@groups.io> From: "Rebecca Cran" In-Reply-To: <174F680216543AB6.25304@groups.io> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Pull Request: https://github.com/tianocore/edk2/pull/4176 Branch: https://github.com/bcran/edk2/tree/patchcheck_makefiles On 3/24/23 10:32 AM, Rebecca Cran wrote: > When checking for Makefiles, in addition to Makefile and GNUmakefile, > also check for *.makefile: this allows {header,footer,app,lib}.makefile > in BaseTools/Source/C/Makefiles to be detected and avoid having > PatchCheck.py complain about tab characters. > > Signed-off-by: Rebecca Cran > --- > BaseTools/Scripts/PatchCheck.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py > index fcdabfc8acea..3910015d173e 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -383,7 +383,8 @@ class GitDiffCheck: > self.force_crlf = False > self.force_notabs = False > if os.path.basename(self.filename) == 'GNUmakefile' or \ > - os.path.basename(self.filename) == 'Makefile': > + os.path.basename(self.filename) == 'Makefile' or \ > + os.path.basename(self.filename).endswith("makefile"): > self.force_notabs = False > elif len(line.rstrip()) != 0: > self.format_error("didn't find diff command")