From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=17.171.2.34; helo=mail-in24.apple.com; envelope-from=afish@apple.com; receiver=edk2-devel@lists.01.org Received: from mail-in24.apple.com (mail-out24.apple.com [17.171.2.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 32704223DB7A3 for ; Thu, 8 Feb 2018 22:53:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1518159562; x=2382073162; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=p04zBiYUf2rxMG9Fg4lJ4ZCPv+JWLo9Sfn9wv3RsbvY=; b=Ou1U3bi9TPqzpxbi9lD2AfOMsPd9I+k3/uHqT8gy60aOoWLRyRsg0Rdy6prklz+V 4BDkPE5tzFFsWIXBSzMXyEh+e7ybBUljFvdSZcBjopJb6nwlh0LXmVeqQJbEevT3 om/oMxmefl9yHi8VoeANnr8OjMsv3X+wZyahjuTnhFbj1QIdnblJlzXIvPQtN6Sw xybkvI0IZBpuy8n2IgRxCZ1y2/bI3UWP+8feBXXM3yn49+XNkeETLOnBNUdsTg4o 9xqyNNBrQYF2q3CQnKIM8q5iE1wGrOv3U4IT4drvbdPrz5u4vhZ5TK1kxLO4nT/N Qu5aTQ411F4SEmafqtdogw==; Received: from relay21.apple.com (relay21.apple.com [17.171.128.102]) (using TLS with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail-in24.apple.com (Apple Secure Mail Relay) with SMTP id 24.87.10828.AC64D7A5; Thu, 8 Feb 2018 22:59:22 -0800 (PST) X-AuditID: 11ab0218-260a89e000002a4c-24-5a7d46ca23f5 Received: from ma1-mmpp-sz10.apple.com (ma1-mmpp-sz10.apple.com [17.171.128.150]) by relay21.apple.com (Apple SCV relay) with SMTP id EA.95.19484.9C64D7A5; Thu, 8 Feb 2018 22:59:22 -0800 (PST) MIME-version: 1.0 Received: from [17.234.224.196] by ma1-mmpp-sz10.apple.com (Oracle Communications Messaging Server 8.0.2.2.20180130 64bit (built Jan 30 2018)) with ESMTPSA id <0P3V009IBFETRZ60@ma1-mmpp-sz10.apple.com>; Thu, 08 Feb 2018 22:59:21 -0800 (PST) Sender: afish@apple.com From: Andrew Fish Message-id: <339D4678-56CB-4195-AD81-9AE7D0CA2B13@apple.com> Date: Thu, 08 Feb 2018 22:59:16 -0800 In-reply-to: <774033816.4534639.1518139941905@mail.yahoo.com> Cc: "edk2-devel@lists.01.org" To: Ruslan Nikolaev References: <774033816.4534639.1518139941905.ref@mail.yahoo.com> <774033816.4534639.1518139941905@mail.yahoo.com> X-Mailer: Apple Mail (2.3445.5.20) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsUiuLohTfeUW22UwfwWVos9h44yW8z85evA 5NE9+x+Lx6xZh5kCmKK4bFJSczLLUov07RK4Mn69DSrYp1yx5et/5gbGO3JdjBwcEgImEpPb +LoYuTiEBNYzSXTc7mXvYuQEi6+cfZ0JInGYUeL8jv9sIAleAUGJH5PvsYDYzAJhEre3nGCH KPrGKDH5ZhcrSEJYQFzi3ZlNzCA2m4CyxIr5H9ghmm0kJj/tY4OoMZJ4uW0R2CAWAVWJrhUH GEFsTgFbiTtb5zFDLDCXmHHhCxOILSKgKzH7xlGwOUICxRLbGr4xQVyqJDH9+202kCMkBOaw Sfzof8wygVFoFpJjZyE5FsLWkvj+qBUozgFky0scPC8LEdaUeHbvE1SJtsSTdxdYFzCyrWIU zk3MzNHNzDMy0UssKMhJ1UvOz93ECI4EJokdjF9eGx5iFOBgVOLhnRBTEyXEmlhWXJl7iFGa g0VJnHfubaCQQHpiSWp2ampBalF8UWlOavEhRiYOTqkGRqkr1V7Ttlnk805v+iN67fJcTY+T NZvET8eXbbiotGaRbGmbyPqTfg/nR/497zV137NAhsMW1u+u6knH7PJ1N2ufeyxixoHVrvOn vwk48KlJSufZtu52lr953j7Pp39odmVdfDWz7trdS1/kCt22HLRZtSFli8KrzzIf2Fc6V5o7 NM48V5t3ulGJpTgj0VCLuag4EQDqmye4ZQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGLMWRmVeSWpSXmKPExsUiuLphmu4pt9oog4NPmCz2HDrKbDHzl68D k0f37H8sHrNmHWYKYIrisklJzcksSy3St0vgyvj1Nqhgn3LFlq//mRsY78h1MXJySAiYSKyc fZ2pi5GLQ0jgMKPE+R3/2UASvAKCEj8m32MBsZkFwiRubznBDlH0jVFi8s0uVpCEsIC4xLsz m5hBbDYBZYkV8z+wQzTbSEx+2scGUWMk8XLbIrBBLAKqEl0rDjCC2JwCthJ3ts5jhlhgLjHj whcmEFtEQFdi9o2jYHOEBIoltjV8Y4K4VEli+vfbbBMY+WchuW8WkvsgbC2J749ageIcQLa8 xMHzshBhTYln9z5BlWhLPHl3gXUBI9sqRsGi1JzESiNDvcSCgpxUveT83E2MkNBN28H4/5zh IUYBDkYlHt4JMTVRQqyJZcWVuYcYJTiYlUR480xqo4R4UxIrq1KL8uOLSnNSiw8xSnOwKInz lp0GqhZITyxJzU5NLUgtgskycXBKNTDmCIcUXl3zInbZx4mziybeaLgl+nrDp0Q97SijBFXh k1+u7t16rqKmf9G8n+lbD+9Xup4Sl9CW/OW+jeUpwYNirdp1dzbUnmnSCfsoc1O3VTh+V2+1 ojKT3PHFx/1/TPrGG25Tu/ujt4mkjE5bl9RKZU+NJ57VbPfPmvAvsfn1vHP5rQMbVVKUWIoz Eg21mIuKEwGdQXKsWQIAAA== X-Content-Filtered-By: Mailman/MimeDel 2.1.23 Subject: Re: Patch to fix EFIAPI definition X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2018 06:53:37 -0000 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT > On Feb 8, 2018, at 5:32 PM, Ruslan Nikolaev wrote: > > I submitted a bug report and a patch: https://bugzilla.tianocore.org/show_bug.cgi?id=870 > It is very straight-forward. Can someone review it, and, hopefully, commit the change? Ruslan, Was there an example of how to code this? Sorry if I missed it, I'm getting a lot of email these days. Also what is you usage model? Clang is very cross compiler friendly and you can specify a triple to support the ABI you need. To get EFI supported on macOS tools we ended up open sourcing a triple to support the EFIAPI. If you look in https://github.com/tianocore/edk2/blob/master/BaseTools/Conf/tools_def.template you will see that you can use Xcode to build EFIAPI if you pass -target x86_64-pc-win32-macho. I guess I'm asking the question if you really need to support multiple ABIs with clang? The best way to solve this in clang is to make it support EFIAPI. If you don't need multiple ABIs take a look at what we did with -target x86_64-pc-win32-macho, which tells clang to build EFIABI, but output a mach-O executable (we need the mach-O for our debugger). Basically with clang you could upstream what you need into the compiler you are using for other things... Thanks, Andrew Fish > - Ruslan > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel