From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id ABBBBAC1C99 for ; Wed, 24 Apr 2024 22:20:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YjlBDgoP1sfL8QBv/cFBZv0DkuUwwRUF3LiWUTsRQa0=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713997211; v=1; b=k9xjR3z7qeUc3aqAn8YlHA2n/l60nfgA1+vfsVtXBB7+0cvHs/firu/2NGOLr2raVo81msHa AR6cobD+Rnt1RNp7uKHR0f1JwOBwKJe/reHutXXfMSsXAckiQRzMskFsVvQC7m2ym4Ak0SEKmJq YVXIeA2NTrddpGNSh7gADREjBG9G15E0hWhX9ohBXa8sZGSLq2Z/IJQnlx0+4GK5B6pZxVFg9d1 bqtcNT/OAOn2AXyxR7+z9P4dKPjcPKJc2icUK95ivKs1uRNMF3t5ahk44wqGhaIK+fySM06d/7A oVU4csT9kpeXvl0Q9DqFgkG3pjurMiMRYAXgkc7bOv3FQ== X-Received: by 127.0.0.2 with SMTP id kLxxYY7687511xoEk8GFeHEG; Wed, 24 Apr 2024 15:20:11 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.2856.1713997210216263373 for ; Wed, 24 Apr 2024 15:20:10 -0700 X-Received: from [10.6.0.181] (unknown [20.39.63.4]) by linux.microsoft.com (Postfix) with ESMTPSA id 31EF3210DEBC; Wed, 24 Apr 2024 15:20:09 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 31EF3210DEBC Message-ID: <33d7c088-dc8c-459c-9d2e-84053e3be920@linux.microsoft.com> Date: Wed, 24 Apr 2024 18:20:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 1/1] Update to CodeQL 2.16.1 To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: "Feng, Bob C" , Liming Gao , Rebecca Cran , Sean Brogan , "Chen, Christine" , Ard Biesheuvel , doug.edk2@gmail.com References: <17C947F379EB4DB1.31749@groups.io> From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 24 Apr 2024 15:20:10 -0700 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: iccBZAnG7rO1r0JtcVAuk2IJx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=k9xjR3z7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Added. These two PRs seem to be the only ones already impacted by this: - https://github.com/tianocore/edk2/pull/5596 - https://github.com/tianocore/edk2/pull/5582 Rebasing after https://github.com/tianocore/edk2/pull/5597 is completed=20 will resolve the CodeQL failures. Thanks, Michael On 4/24/2024 6:11 PM, Michael D Kinney wrote: > Go ahead and add the push label. >=20 > Mike >=20 >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Michael >> Kubacki >> Sent: Wednesday, April 24, 2024 2:55 PM >> To: devel@edk2.groups.io >> Cc: Feng, Bob C ; Liming Gao >> ; Rebecca Cran ; Sean >> Brogan ; Chen, Christine >> >> Subject: Re: [edk2-devel] [PATCH v1 1/1] Update to CodeQL 2.16.1 >> >> Thanks for reviews. I've updated the PR >> (https://github.com/tianocore/edk2/pull/5597) to include them. >> >> Although it has not been 24 hours, I suggest we merge the patch soon to >> ensure CI is unblocked. Please feel free to add the push tag or let me >> know if you'd like me to. >> >> Thanks, >> Michael >> >> On 4/24/2024 1:37 PM, Michael Kubacki wrote: >>> From: Michael Kubacki >>> >>> Fixes current CI CodeQL failures due to old CodeQL CLI version. >>> >>> Updates CodeQL to work with the latest queries. Includes functional >>> and security fixes within the CodeQL CLI binary. >>> >>> For more information on release details see: >>> >>> https://github.com/github/codeql-cli-binaries/releases >>> >>> For changes between the previous version (2.14.5) and 2.16.1 see: >>> >>> https://github.com/github/codeql-cli- >> binaries/compare/v2.14.5...v2.16.1 >>> >>> Cc: Bob Feng >>> Cc: Joey Vagedes >>> Cc: Liming Gao >>> Cc: Michael D Kinney >>> Cc: Rebecca Cran >>> Cc: Sean Brogan >>> Cc: Yuwei Chen >>> Signed-off-by: Michael Kubacki >>> --- >>> >>> Notes: >>> Tested in https://github.com/tianocore/edk2/pull/5597 >>> >>> BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml | 6 +++--- >>> BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml | 6 +++--- >>> BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml | 6 +++--- >>> 3 files changed, 9 insertions(+), 9 deletions(-) >>> >>> diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml >> b/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml >>> index 37c7c9f595ca..5ec56c6bf06f 100644 >>> --- a/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml >>> +++ b/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml >>> @@ -16,9 +16,9 @@ >>> "scope": "codeql-ext-dep", >>> "type": "web", >>> "name": "codeql_cli", >>> - "source": "https://github.com/github/codeql-cli- >> binaries/releases/download/v2.12.4/codeql.zip", >>> - "version": "2.12.4", >>> - "sha256": >> "f682f1155d627ad97f10b1bcad97f682011986717bd3823e9cf831ed83ac96e7", >>> + "source": "https://github.com/github/codeql-cli- >> binaries/releases/download/v2.16.1/codeql.zip", >>> + "version": "2.16.1", >>> + "sha256": >> "86a98f6ebb8fd49efadf367f3275c438669fcb8426962c33415129aad8e093e6", >>> "compression_type": "zip", >>> "internal_path": "/codeql/", >>> "flags": ["set_shell_var", ], >>> diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml >> b/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml >>> index a6ca5d0f34cc..5b4a919f1de4 100644 >>> --- a/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml >>> +++ b/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml >>> @@ -14,9 +14,9 @@ >>> "scope": "codeql-linux-ext-dep", >>> "type": "web", >>> "name": "codeql_linux_cli", >>> - "source": "https://github.com/github/codeql-cli- >> binaries/releases/download/v2.14.5/codeql-linux64.zip", >>> - "version": "2.14.5", >>> - "sha256": >> "72aa5d748ff9ab57cfd86045560683bdc4897e0fe6d9f9a2786d9394674ae733", >>> + "source": "https://github.com/github/codeql-cli- >> binaries/releases/download/v2.16.1/codeql-linux64.zip", >>> + "version": "2.16.1", >>> + "sha256": >> "40dbb6c0c4064bd14601a02e60c61661fdc0271469f90eb91a2e7d51d4cbc171", >>> "compression_type": "zip", >>> "internal_path": "/codeql/", >>> "flags": ["set_shell_var", ], >>> diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml >> b/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml >>> index e706a7cabf9f..c0c018c9538f 100644 >>> --- a/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml >>> +++ b/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml >>> @@ -14,9 +14,9 @@ >>> "scope": "codeql-windows-ext-dep", >>> "type": "web", >>> "name": "codeql_windows_cli", >>> - "source": "https://github.com/github/codeql-cli- >> binaries/releases/download/v2.14.5/codeql-win64.zip", >>> - "version": "2.14.5", >>> - "sha256": >> "861fcb38365cc311efee0c3a28c77494e93c69a969885b72e53173ad473f61aa", >>> + "source": "https://github.com/github/codeql-cli- >> binaries/releases/download/v2.16.1/codeql-win64.zip", >>> + "version": "2.16.1", >>> + "sha256": >> "9ebe5ea8a7d0a77425428d50d49912319117fccee24ecb62f6219c12584f4f28", >>> "compression_type": "zip", >>> "internal_path": "/codeql/", >>> "flags": ["set_shell_var", ], >> >> >> >> >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118236): https://edk2.groups.io/g/devel/message/118236 Mute This Topic: https://groups.io/mt/105714919/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-