public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, adam.liu@tw.synaptics.com
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Sami Mujawar <sami.mujawar@arm.com>,
	Zhiguang Liu <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH] MdePkg/BaseLib: Fix AARCH64 compilation error
Date: Wed, 7 Feb 2024 22:05:06 +0100	[thread overview]
Message-ID: <33e757b2-9c66-426b-5ffd-bbb798661015@redhat.com> (raw)
In-Reply-To: <DM6PR03MB5356756EDE851422472B19E0B7462@DM6PR03MB5356.namprd03.prod.outlook.com>

On 2/6/24 07:11, Adam Liu wrote:
> Declare InternalAssertJumpBuffer as EXTERN

CC'ing maintainers per Maintainers.txt.

Other than that -- the patch seems to be HTML mail; did you send it with
git-send-email?

Laszlo


> 
>  
> 
> Signed-off-by: "Liu, Shun Cheng" <aliu@synaptics.com
> <mailto:aliu@synaptics.com>>
> 
> ---
> 
> MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 +
> 
> 1 file changed, 1 insertion(+)
> 
>  
> 
> diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
> b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
> 
> index 6ec8f35f2c..397593ceaf 100644
> 
> --- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
> 
> +++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
> 
> @@ -4,6 +4,7 @@
> 
> ; SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> ;
> 
> ;------------------------------------------------------------------------------
> 
> +  EXTERN InternalAssertJumpBuffer
> 
>  
> 
>    EXPORT SetJump
> 
>    EXPORT InternalLongJump
> 
> --
> 
> 2.22.0.windows.1
> 
>  
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115255): https://edk2.groups.io/g/devel/message/115255
Mute This Topic: https://groups.io/mt/104198930/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-02-07 21:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-06  6:11 [edk2-devel] [PATCH] MdePkg/BaseLib: Fix AARCH64 compilation error Adam Liu
2024-02-07 21:05 ` Laszlo Ersek [this message]
2024-02-15  9:02   ` Adam Liu
2024-02-15  9:50     ` Laszlo Ersek
  -- strict thread matches above, loose matches on Subject: below --
2024-01-29  8:41 Adam Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33e757b2-9c66-426b-5ffd-bbb798661015@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox