From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4A842D80110 for ; Wed, 7 Feb 2024 21:05:16 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=CBQp4JoV+OVAXaHmjOCytmXSO5cU3YwU9582DLlQSXw=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707339915; v=1; b=F6gW1VK163Nr9CM+8CIswwt2tU2uEISYqQvDc/gW1AUjgZACesDsFVpgInh3Fy7rdvLKXQ3+ euq6x96y/bcbmQL9M2GML5pb6FqWsvUu7ZabF2wS8obcFzJuHcGy7o2LF7i7MO6HY/Gx60yDnkr vF1voWZx65PCuO7QSCjzMLxg= X-Received: by 127.0.0.2 with SMTP id cJ8yYY7687511xUoni5niyD2; Wed, 07 Feb 2024 13:05:15 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.1442.1707339914171437740 for ; Wed, 07 Feb 2024 13:05:14 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-508-UqJiZOEdMlmr_FflNtmhvQ-1; Wed, 07 Feb 2024 16:05:09 -0500 X-MC-Unique: UqJiZOEdMlmr_FflNtmhvQ-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D7AC585A58E; Wed, 7 Feb 2024 21:05:08 +0000 (UTC) X-Received: from [10.39.195.126] (unknown [10.39.195.126]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4730B1C10C0C; Wed, 7 Feb 2024 21:05:07 +0000 (UTC) Message-ID: <33e757b2-9c66-426b-5ffd-bbb798661015@redhat.com> Date: Wed, 7 Feb 2024 22:05:06 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH] MdePkg/BaseLib: Fix AARCH64 compilation error To: devel@edk2.groups.io, adam.liu@tw.synaptics.com References: From: "Laszlo Ersek" Cc: Ard Biesheuvel , Leif Lindholm , Liming Gao , Michael D Kinney , Sami Mujawar , Zhiguang Liu In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: b81PWPgsmEV5n5vzbrplNzcTx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=F6gW1VK1; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 2/6/24 07:11, Adam Liu wrote: > Declare InternalAssertJumpBuffer as EXTERN CC'ing maintainers per Maintainers.txt. Other than that -- the patch seems to be HTML mail; did you send it with git-send-email? Laszlo > >   > > Signed-off-by: "Liu, Shun Cheng" > > > --- > > MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 + > > 1 file changed, 1 insertion(+) > >   > > diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm > b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm > > index 6ec8f35f2c..397593ceaf 100644 > > --- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm > > +++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm > > @@ -4,6 +4,7 @@ > > ; SPDX-License-Identifier: BSD-2-Clause-Patent > > ; > > ;------------------------------------------------------------------------------ > > +  EXTERN InternalAssertJumpBuffer > >   > >    EXPORT SetJump > >    EXPORT InternalLongJump > > -- > > 2.22.0.windows.1 > >   > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115255): https://edk2.groups.io/g/devel/message/115255 Mute This Topic: https://groups.io/mt/104198930/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-