From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 66CDA740034 for ; Wed, 12 Jun 2024 01:24:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6QIEiYVCJDZRGijvMdnLhPz6ZE66Hq1RWsW5oamm4Z0=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:Subject:To:CC:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1718155491; v=1; b=v4h7QL5lm+FQ8SvVRajzWi5QaGbqMeggXpx/3rQghfgO7HJiIGq8HzuDNR3gEV9SqyiA4c14 TdUQqQjrb9WIMv1okSn0bcOSlEjBl5QdRhw0EYLG/wB5MTRF8prBDs8Mv2nV2HbYqM7kyHk+Vd/ 1hC2CZ0BV+XTFUYpkgOeFH12v4NTxA6fPkUL4tb93bQEXUtadjmFt9S5uq6y7hVxkkzHdNoDiPd HH8sQFzTNVSuVuLM+7F6bgpCQTPmACS1zSq16G1GFJZ6x2GEeSMd8S8SjNB58P594Mt5BD1TR7P k0Xplil/4x9KCTl8eTSUtHjFSn/+58xnHbRL1wjsr9WWg== X-Received: by 127.0.0.2 with SMTP id 4SW3YY7687511xKjmCbxwdHF; Tue, 11 Jun 2024 18:24:49 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.53]) by mx.groups.io with SMTP id smtpd.web10.1004.1718155488956016960 for ; Tue, 11 Jun 2024 18:24:49 -0700 X-Received: from CH3PR12MB9194.namprd12.prod.outlook.com (2603:10b6:610:19f::7) by CYXPR12MB9317.namprd12.prod.outlook.com (2603:10b6:930:e2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.37; Wed, 12 Jun 2024 01:24:46 +0000 X-Received: from CH3PR12MB9194.namprd12.prod.outlook.com ([fe80::53fb:bf76:727f:d00f]) by CH3PR12MB9194.namprd12.prod.outlook.com ([fe80::53fb:bf76:727f:d00f%7]) with mapi id 15.20.7633.037; Wed, 12 Jun 2024 01:24:46 +0000 Message-ID: <33edb454-112a-4dea-9833-4124d149b63d@amd.com> Date: Wed, 12 Jun 2024 11:24:29 +1000 User-Agent: Mozilla Thunderbird Beta Subject: Re: [edk2-devel] [PATCH ovmf v4 5/5] OvmfPkf: Enable AMD SEV-ES DebugVirtualization To: Tom Lendacky , devel@edk2.groups.io CC: Liming Gao , Michael D Kinney , Zhiguang Liu , Ard Biesheuvel , Erdem Aktas , Gerd Hoffmann , Jiewen Yao , Michael Roth , Min Xu References: <20240605020946.1224515-1-aik@amd.com> <20240605020946.1224515-6-aik@amd.com> From: "Alexey Kardashevskiy via groups.io" In-Reply-To: X-ClientProxiedBy: SY5P282CA0069.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:203::13) To CH3PR12MB9194.namprd12.prod.outlook.com (2603:10b6:610:19f::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9194:EE_|CYXPR12MB9317:EE_ X-MS-Office365-Filtering-Correlation-Id: 3931e6fd-cd87-4efc-9c0d-08dc8a7e7204 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4SPymrSCN1dk1wN7f23IVTopAOjV8chqPRU93SlI8ALEY1GsgeL6K5dVTQj0?= =?us-ascii?Q?PuQVWNCiQ4a60F/vCYGtOqCNP0bCcLygX3wEVQtN1Uk2sy1HIKXN5D+sXfGA?= =?us-ascii?Q?R9/9ZtGOTWVC1V5Bu7HvK+LuV0+8+QYCAwPncGfinGIdXEbwsV9ywRsCQHUu?= =?us-ascii?Q?OwjOgyFrVDOAIrjpzjT8tJtoe0DH5tbq876+CwwGf4mdOmsP+PrwwLnVBFK7?= =?us-ascii?Q?fBEbzqu5INYFqGx98Olfv+dPP2ZVFiCTCKm1zGol7Z0MqRXm/VRJqmsraDLb?= =?us-ascii?Q?W/kNGXfYXl7mTPfxROAX23nW3xmfJU/5f4uGiwzvSl11t9M65HeIUr9EI+FM?= =?us-ascii?Q?TVZ+yIwUH8YIzerk3keo41dcE7wmYuLrfZCXC53y8uCwHW9zcSE0ALrtF9nX?= =?us-ascii?Q?j7Dt3wm3Z0Rlib3SAVDclboVTZDNM3iZ/jUZL463XibtzsvP0wHPMr65ebwN?= =?us-ascii?Q?BG9B2AYFibJJ6fJZpBEZ6RjC+z7+/94Webqh5OuRslVzmGK85ujRNDidXfOO?= =?us-ascii?Q?oljn8N6yV/yAwKrddEBF9p1PF3GAZLRSwbO4W4AtD6ErKoA28YtFCyrphuFQ?= =?us-ascii?Q?G1dtB9Iqi3oSv3ymvPDY2xyGzMwUwl7TQV+R/X1qPfcDppHdzXlxnZ6v4DVY?= =?us-ascii?Q?VvDhY1hA5EVtjviA+FrwWN2pSVA64EEZHmpTKsTF//LvXrTjDRe4zRtZkCZS?= =?us-ascii?Q?1fqVihuLz6f9VaSbYLJQRaM647EmtcdGoUUomYuBS/PWenv4q6JtvdeDo3b5?= =?us-ascii?Q?gLUbDQaXOqipqMJM/38B4veYdxwcfz/cilCTqU8QVDfs0j/qLfA/ZSKWqry4?= =?us-ascii?Q?SZIV2qGTmIqFY3hxbUjVPq6gF+Cy5y1C/gD2m+j7UVWruFHUTVi3qBaeh/2w?= =?us-ascii?Q?JIvrTyah8BzCxI/sTKpQHF2JzGQEXb+pOUsteTuxplJfOFgcNTDlQNtDg8uV?= =?us-ascii?Q?D9g6jREq2fXEg1pdupZupL5ZZojpVItuumJvIMytdzUpUl+WYbGQDLKMSoa4?= =?us-ascii?Q?o9DAJFpeDda6oPPJ1La5qewRe6dnnYAuAyOL58YB1g99gwRIgcxOOv4sCmyc?= =?us-ascii?Q?5NvhRIbeXwUwlqLc8EbtKINZSUjAnYkFB7+tA60LJqHOeBQSNp8wRD6ae8cJ?= =?us-ascii?Q?t9lBptK49OyFgVnW+BC1Bs91f3LegBDiGwoO1pSEtRmINnxZRF4iCQI+4Yf1?= =?us-ascii?Q?oPCu/ywCRFHMbaw6hm9ZKHjZcz1hAkPqNH3Jyfspr1Rprf4luqirnrvie20W?= =?us-ascii?Q?mOO6mBOzrrVmUMZx6hny2v7wfUd8a1PJD08LZYhOyypa+nwXeekYdcZcMjEN?= =?us-ascii?Q?bvJ1euF8uXb5t0C6iJg/dnSv?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PBX75PaX/Y8aRSF1bTaiIIrCjvJxmgT/tJ5MurUBV1L6Quhxfdo5mY1jfbzq?= =?us-ascii?Q?IfCezltB08YBVN6A/8ofAhr3oVeFAXvKRtgAASHz65drkKkwh7E92PA/CQkn?= =?us-ascii?Q?zxNS4nqBJzGlsJFGG6NlTQVPrMghzToGjdxAfwC5X/Fxwvj/9Dgc/alDhDUh?= =?us-ascii?Q?QpHq6woI4RrQVw40NUJ+pvzxsxEqoY/1dO9KWXhhK7fA5AkbGdGeOSTJgIcE?= =?us-ascii?Q?jZKfCz72fHIZ71Lx64B2Gb6mGAwzLzDU/WKO+lK/tZNUUGv7qmeU/goc3JaC?= =?us-ascii?Q?Z3wENjmErX5CgHjXxZ5bX1IFP9RcdtheympofwDtOgWkXKVT0mwKzgbGKYPr?= =?us-ascii?Q?t37qfyZvlNkaY7nc2Av+Jhllg8uGKjNKmUx8biipjwkPMKNlXvYmVI7uc+/l?= =?us-ascii?Q?zj1ZPqH8U+jKv4iCO/bwGCVUGtqjfK4OcY2xApdZhqjX8vL8ikATTSEU9bOd?= =?us-ascii?Q?i9+cdwGghD6iuEaTLTQCCCB3szwk+Qd7JlkccCAd9Dz6HAmH5h/WSW1+V6+B?= =?us-ascii?Q?s5N7Z/O3XJHIuRKvYUSLC9KGX9drPrnQ24ZfUuUbRkZhgaUTUJMdiwCjosxL?= =?us-ascii?Q?aPvm89mUKYQDPLgkui/AUpA2pG2J7pelze7BXQ7+fpoo2rnImMU6xlpT6mp0?= =?us-ascii?Q?/ZXefNEHmgeoGfgy4qkzdrDuauPywsgSQpHFcLD6Tp4njfG9uJmqT2n1k5V1?= =?us-ascii?Q?Z1nP1BDCY4+y8pn14qkuBnkFJskp7WToEmUaRYJfE/dUEieF4yTER1TV8FPZ?= =?us-ascii?Q?soOc2kpSdynQeywZTcU4/TV7jGQiCOrsTtuQ/Cm4Imyp5mev/jriMSK+0RHo?= =?us-ascii?Q?nrMNUb2NghfZ/+6nHfAtTRNGpLWnLPKCOcuxteQmMiSasmcP+9fH7iv1v4Aw?= =?us-ascii?Q?OP/qETR+18ePJDEisy250tiL+1bPTLfUXHOpYUPrLEWGwMTCoJNTVwAHOKuw?= =?us-ascii?Q?OmuZn5C6y7UDr8FqyrQ7RVofr6BQhGnk9vhkRpWdT1wxJL53e/t+E1OXZuLJ?= =?us-ascii?Q?ZxvO4wbOTGk7HX1O/lJBEHanEi+TkMeIlcQ41qm2Bi7xZ4AJdzdcu2K4MLfc?= =?us-ascii?Q?/Fv5kQReeQOgjKtAY0GWZKjXtzP9VLllvjoaTxN8rJkYBxIr4XCMWwaarwvR?= =?us-ascii?Q?HsFF3gKrVEpkKtDz5BPW7cmdk0LI3YYTSKm2wT8MbLR4ZKZjSqumcTxAJqkj?= =?us-ascii?Q?0/XQjsfQzXm1TXdH3rBFA4pR5sYNbChkQxdvmbmMPgDtr8wQ3TJEaJfqQQO2?= =?us-ascii?Q?RIsikJ1CclcDc8fFrhfAsTDBO1CAlGVBd3i69iQZ7Qmg64twjzQA5mdxcZuS?= =?us-ascii?Q?r1bB+z0nmI6NsM+AbgmdzOX9wjzHLqZ7bkofz4QQbqUstIruHYz4NQhebzkn?= =?us-ascii?Q?sJRkaNvqeqyg9jLQkDmGi9OsCMLtvHC6OSBfUPox1CwV0GFR/c+BUk0vy75J?= =?us-ascii?Q?9S99ySc3SbdjOrUQ/YW3mHH/tQuFUcJnhXG3IsESbF1AVbiPPTWwN5IViiDY?= =?us-ascii?Q?bjul4lgmfRX2lf9Yefyb3JU5sor3IaOlKtr3j0W4ujt/61Aiytfgw2P/rPlh?= =?us-ascii?Q?l7HOhipXxtv6SZPbj5dQrbLcS4E3v+QntoB7ql9G?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3931e6fd-cd87-4efc-9c0d-08dc8a7e7204 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9194.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 01:24:46.6499 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kM1eGUpPKRR1ouZinz2SQgaLlmF3z4OUwhBacvhOkMqjHLcwBR3B8/Gg7YyDZUIwD9v1TzLufaSIkd6ZS9WPwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9317 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 11 Jun 2024 18:24:49 -0700 Resent-From: aik@amd.com Reply-To: devel@edk2.groups.io,aik@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5i4ruLZVKy0O233pEeoK6TKRx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=v4h7QL5l; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks Tom! Now, I've pushed it again to my github,=20 https://github.com/tianocore/edk2/pull/5594 re-ran the tasks but "Review=20 required" is still there so I assume re-posting patches won't help=20 getting them in as I need more reviews, right? On 6/6/24 04:54, Tom Lendacky wrote: > On 6/4/24 21:09, Alexey Kardashevskiy wrote: >> Write the feature bit into PcdConfidentialComputingGuestAttr >> and enable DebugVirtualization in PEI, SEC, DXE. >> >> Cc: Ard Biesheuvel >> Cc: Erdem Aktas >> Cc: Gerd Hoffmann >> Cc: Jiewen Yao >> Cc: Michael Roth >> Cc: Min Xu >> Cc: Tom Lendacky >> Signed-off-by: Alexey Kardashevskiy >=20 > Reviewed-by: Tom Lendacky >=20 >> --- >> Changes: >> v4: >> * s/DebugSwap/DebugVirtualization/g >> * the feature is enabled here for all modes >> --- >> =C2=A0 OvmfPkg/Library/BaseMemEncryptSevLib/PeiMemEncryptSevLibInternal.= c=20 >> |=C2=A0 6 +++++- >> =C2=A0 OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptSevLibInternal.= c=20 >> |=C2=A0 6 +++++- >> =C2=A0 OvmfPkg/PlatformPei/AmdSev.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=20 >> 13 ++++++++++--- >> =C2=A0 3 files changed, 20 insertions(+), 5 deletions(-) >> >> diff --git=20 >> a/OvmfPkg/Library/BaseMemEncryptSevLib/PeiMemEncryptSevLibInternal.c=20 >> b/OvmfPkg/Library/BaseMemEncryptSevLib/PeiMemEncryptSevLibInternal.c >> index 7d823ad639f4..f381b9255bb7 100644 >> --- a/OvmfPkg/Library/BaseMemEncryptSevLib/PeiMemEncryptSevLibInternal.c >> +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/PeiMemEncryptSevLibInternal.c >> @@ -154,5 +154,9 @@ MemEncryptSevEsDebugVirtualizationIsEnabled ( >> =C2=A0=C2=A0=C2=A0 VOID >> =C2=A0=C2=A0=C2=A0 ) >> =C2=A0 { >> -=C2=A0 return FALSE; >> +=C2=A0 MSR_SEV_STATUS_REGISTER=C2=A0 Msr; >> + >> +=C2=A0 Msr.Uint32 =3D InternalMemEncryptSevStatus (); >> + >> +=C2=A0 return Msr.Bits.DebugVirtualization ? TRUE : FALSE; >> =C2=A0 } >> diff --git=20 >> a/OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptSevLibInternal.c=20 >> b/OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptSevLibInternal.c >> index 33a326ac1571..946bed2ada13 100644 >> --- a/OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptSevLibInternal.c >> +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptSevLibInternal.c >> @@ -154,7 +154,11 @@ MemEncryptSevEsDebugVirtualizationIsEnabled ( >> =C2=A0=C2=A0=C2=A0 VOID >> =C2=A0=C2=A0=C2=A0 ) >> =C2=A0 { >> -=C2=A0 return FALSE; >> +=C2=A0 MSR_SEV_STATUS_REGISTER=C2=A0 Msr; >> + >> +=C2=A0 Msr.Uint32 =3D InternalMemEncryptSevStatus (); >> + >> +=C2=A0 return Msr.Bits.DebugVirtualization ? TRUE : FALSE; >> =C2=A0 } >> =C2=A0 /** >> diff --git a/OvmfPkg/PlatformPei/AmdSev.c b/OvmfPkg/PlatformPei/AmdSev.c >> index 88ca14507f5e..8562787035db 100644 >> --- a/OvmfPkg/PlatformPei/AmdSev.c >> +++ b/OvmfPkg/PlatformPei/AmdSev.c >> @@ -434,6 +434,7 @@ AmdSevInitialize ( >> =C2=A0=C2=A0=C2=A0 ) >> =C2=A0 { >> =C2=A0=C2=A0=C2=A0 UINT64=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 EncryptionMask; >> +=C2=A0 UINT64=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 CCGuestAt= tr; >> =C2=A0=C2=A0=C2=A0 RETURN_STATUS=C2=A0 PcdStatus; >> =C2=A0=C2=A0=C2=A0 // >> @@ -517,13 +518,19 @@ AmdSevInitialize ( >> =C2=A0=C2=A0=C2=A0 // technology is active. >> =C2=A0=C2=A0=C2=A0 // >> =C2=A0=C2=A0=C2=A0 if (MemEncryptSevSnpIsEnabled ()) { >> -=C2=A0=C2=A0=C2=A0 PcdStatus =3D PcdSet64S (PcdConfidentialComputingGue= stAttr,=20 >> CCAttrAmdSevSnp); >> +=C2=A0=C2=A0=C2=A0 CCGuestAttr =3D CCAttrAmdSevSnp; >> =C2=A0=C2=A0=C2=A0 } else if (MemEncryptSevEsIsEnabled ()) { >> -=C2=A0=C2=A0=C2=A0 PcdStatus =3D PcdSet64S (PcdConfidentialComputingGue= stAttr,=20 >> CCAttrAmdSevEs); >> +=C2=A0=C2=A0=C2=A0 CCGuestAttr =3D CCAttrAmdSevEs; >> =C2=A0=C2=A0=C2=A0 } else { >> -=C2=A0=C2=A0=C2=A0 PcdStatus =3D PcdSet64S (PcdConfidentialComputingGue= stAttr,=20 >> CCAttrAmdSev); >> +=C2=A0=C2=A0=C2=A0 CCGuestAttr =3D CCAttrAmdSev; >> =C2=A0=C2=A0=C2=A0 } >> +=C2=A0 if (MemEncryptSevEsDebugVirtualizationIsEnabled ()) { >> +=C2=A0=C2=A0=C2=A0 CCGuestAttr |=3D CCAttrFeatureAmdSevEsDebugVirtualiz= ation; >> +=C2=A0 } >> + >> +=C2=A0 PcdStatus =3D PcdSet64S (PcdConfidentialComputingGuestAttr,=20 >> CCGuestAttr); >> + >> =C2=A0=C2=A0=C2=A0 ASSERT_RETURN_ERROR (PcdStatus); >> =C2=A0 } --=20 Alexey -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119555): https://edk2.groups.io/g/devel/message/119555 Mute This Topic: https://groups.io/mt/106496092/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-