From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mx.groups.io with SMTP id smtpd.web10.98116.1683510560063167282 for ; Sun, 07 May 2023 18:49:20 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=A/gx5PA0; spf=pass (domain: bsdio.com, ip: 66.111.4.27, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5F0B75C0060; Sun, 7 May 2023 21:49:19 -0400 (EDT) Received: from imap43 ([10.202.2.93]) by compute5.internal (MEProxy); Sun, 07 May 2023 21:49:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1683510559; x=1683596959; bh=fSXYTOxO2eDpB0uirTN1RKZ13Y+XOasFpkG oMAVY3p0=; b=A/gx5PA0FohPo/d012KKVzCouUsQQOXavKwJH87Y1hCrhx2nsQ6 K5qmBO5NcsDMdGnHQVOtWkJTpC3jrQNbWmQeSjqrZcZPOBTek6Vmnqep2Q6Z6i0+ Dt2hiAGop6wxq7pdDUrM6FggxGBS5JjkyTGQ+bX7cdxe1jq++RDyfoZVHfXzGr+Q 4bGJXmfNZkJYeRprqKx2FZWMCfmbhc7zAE3JU1nNkBI5YvVtgYTPGhT6R7OZbVDR nS0dxI2bwB5IZhP+GGPwpHZHNytyNwJKy1UsuAeSJ4UawFKYNDnmgu+JrEXJ6i04 gT32/eZgYWMu9nF/S26V4neQBZrAtWMfkOQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1683510559; x= 1683596959; bh=fSXYTOxO2eDpB0uirTN1RKZ13Y+XOasFpkGoMAVY3p0=; b=X EkPSpgTzo8te6tQ++Fm3sOmyrbmOWV/exaC/47CouuTJMRuhHpyMYc8r8pdBCRYO PndBRdZm7jAm+46qvXn/hpwbcKPDHaxbJiAUdy/3ev48dJ1Pkr44oFiVUh5EG0jI 8Om9yioT4SrOPqZQGKHs4RaxANfa3lHqrrmhSdwXR45y/VXRVX9QvG5n1mwAZFv2 N7PuV1K8eAPAhSF84qnRtH/qOHXwtuXnkvwerIj/JylD4bYDQ7ASQ5wTEczkbMpt lcFQ+VwD9828oYcss96IkKoPESuwCtZ7hoO/d2+XKulMnTOoJGvYe4F9JFouu4V3 P5gqyYwDf+2PaIjy/HsUw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefjedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgfgsehtqhertderreejnecuhfhrohhmpedftfgv sggvtggtrgcuvehrrghnfdcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtf frrghtthgvrhhnpeetudeuvdfhteeltdegheduffeiueffkeetvddvudfggefhvefhgeek ieeuvefgtdenucffohhmrghinhepvggukhhsvghtuhhprdhshhdpghhithhhuhgsrdgtoh hmpdhgrhhouhhpshdrihhonecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomheprhgvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E19282D4008E; Sun, 7 May 2023 21:49:18 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-386-g2404815117-fm-20230425.001-g24048151 Mime-Version: 1.0 Message-Id: <33f98f94-a7a0-4f76-8667-18e854357ee5@app.fastmail.com> In-Reply-To: <00a701d9814e$7e155620$7a400260$@byosoft.com.cn> References: <20230506193052.1835-1-rebecca@bsdio.com> <008101d9814c$a5018c60$ef04a520$@byosoft.com.cn> <4672f0d7-a84e-4e57-a11c-ec8f579d6f23@app.fastmail.com> <00a701d9814e$7e155620$7a400260$@byosoft.com.cn> Date: Sun, 07 May 2023 19:49:18 -0600 From: "Rebecca Cran" To: devel@edk2.groups.io, gaoliming , "Andrew Fish" , "Leif Lindholm" , "Kinney, Michael D" , "'Bob Feng'" , "'Yuwei Chen'" Subject: =?UTF-8?B?UmU6IFtlZGsyLWRldmVsXSDlm57lpI06IFtQQVRDSCB2MyAwLzRdIGVka3NldHVwLmJhdCwgQmFzZVRvb2xzOiBJbXByb3ZlIFdpbmRvd3MgZW52aXJvbm1lbnQgc2V0dXAgYW5kIEJhc2VUb29scyBDIGNvbXBpbGF0aW9u?= Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Oh that=E2=80=99s a good point. I also noticed that on Windows we don=E2=80= =99t run the python test in BaseTools/Tests/RunTests.py. I=E2=80=99ll get the current patches merged and work on adding the python v= ersion check on Linux and the python functionally tests on Windows. On Sun, May 7, 2023, at 7:43 PM, gaoliming via groups.io wrote: > Rebecca: > I see this patch. It removes python2. But, it doesn't add python=20 > version check. Will you add this check in edksetup.sh? > > Thanks > Liming >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Rebecca Cran >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B45=E6=9C=888=E6=97=A5 = 9:32 >> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming ; >> Andrew Fish ; Leif Lindholm = ; >> Kinney, Michael D ; 'Bob Feng' >> ; 'Yuwei Chen' >> =E4=B8=BB=E9=A2=98: Re: [edk2-devel] =E5=9B=9E=E5=A4=8D: [PATCH v3 0/4] = edksetup.bat, BaseTools: >> Improve Windows environment setup and BaseTools C compilation >>=20 >> I=E2=80=99ve removed the python 2 checks from edksetup.sh in the patch = =E2=80=9CRemove >> bashisms from edksetup.sh and BaseTools/BuildEnv=E2=80=9D that I sent ou= t a few >> days ago. >>=20 >> Rebecca >>=20 >> On Sun, May 7, 2023, at 7:30 PM, gaoliming via groups.io wrote: >> > Rebecca: >> > This change is good to me. Reviewed-by: Liming Gao >> > > cn> >> > >> > But, I see edksetup.sh also has python2 check. I think the same clea= n up >> > can be done in edksetup.sh. >> > >> > Thanks >> > Liming >> >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> >> =E5=8F=91=E4=BB=B6=E4=BA=BA: Rebecca Cran >> >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B45=E6=9C=887=E6=97= =A5 3:31 >> >> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Andrew Fish ; Leif >> >> Lindholm ; Michael D Kinney >> >> ; Liming Gao ; >> >> Bob Feng ; Yuwei Chen >> >> =E6=8A=84=E9=80=81: Rebecca Cran >> >> =E4=B8=BB=E9=A2=98: [PATCH v3 0/4] edksetup.bat, BaseTools: Improve W= indows >> >> environment setup and BaseTools C compilation >> >> >> >> There are remnants of Python 2 support in BaseTools/toolsetup.bat tha= t >> > it's >> >> probably time to remove since we only support Python 3.6 and newer >> these >> >> days. >> >> So, remove the variables that enable Python3 support and simplify the >> > batch >> >> script. I've also seen errors where after running edksetup.bat the bu= ild >> >> command isn't available because PYTHONPATH wasn't being set, so fix t= hat >> >> when the Pip BaseTools are being used. >> >> >> >> At the same time, let's add a check that we meet the minimum version >> >> requirement so we don't end up failing with an obscure error. >> >> >> >> Building BaseTools causes a warning about threading.currentThread bei= ng >> >> deprecated, so update code in NmakeSubdirs.py to switch to >> >> threading.current_thread. >> >> >> >> There needs to be further work, because if PYTHON_COMMAND isn't >> >> specified then >> >> it defaults to "py -3", where py is C:\Windows\py.exe, which doesn't = work >> > if >> >> you're using a virtualenv since it installs python.exe and pythonw.ex= e in >> >> venv\Scripts. toolsetup.bat therefore fails to detect the Pip BaseToo= ls >> > and >> >> uses the in-source Basetools. >> >> >> >> GitHub PR: https://github.com/tianocore/edk2/pull/4302 >> >> GitHub branch: https://github.com/bcran/edk2/tree/py3 >> >> >> >> Changes between v1 and v2 >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D >> >> >> >> - Require Python 3.6 or newer: 3.6 was when PEP 526 was added, which >> we >> >> use. >> >> - Fix Tests/RunTests.py on Windows. >> >> >> >> Rebecca Cran (4): >> >> BaseTools: Remove Python2/Python3 detection from toolset.bat >> >> BaseTools: use threading.current_thread in NmakeSubdirs.py >> >> edksetup.bat: if toolsetup.bat fails, just exit >> >> BaseTools: Update toolsetup.bat and Tests/PythonTest.py to check ve= r >> >> >> >> BaseTools/Source/C/Makefiles/NmakeSubdirs.py | 2 +- >> >> BaseTools/Tests/PythonTest.py | 22 +++- >> >> BaseTools/toolsetup.bat | 119 >> >> ++++++++------------ >> >> edksetup.bat | 1 + >> >> 4 files changed, 69 insertions(+), 75 deletions(-) >> >> >> >> -- >> >> 2.40.0.windows.1 >> > >> > >> > >> > >> > >> > >>=20 >>=20 >>=20 >>=20 > > > > > >=20