From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web12.1041.1581057446544380708 for ; Thu, 06 Feb 2020 22:37:26 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2020 22:37:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,412,1574150400"; d="scan'208";a="264888054" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 06 Feb 2020 22:37:25 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 6 Feb 2020 22:37:25 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 7 Feb 2020 14:37:23 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Fri, 7 Feb 2020 14:37:23 +0800 From: "Liming Gao" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: Matthew Carlson , "Kinney, Michael D" Subject: Re: [PATCH] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17 Thread-Topic: [PATCH] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17 Thread-Index: AQHV3Xz0wXEV4tdd1Ui89gYlkRkRHagPRbQQ Date: Fri, 7 Feb 2020 06:37:23 +0000 Message-ID: <33ff840c392a4b9389555c0048cd22c6@intel.com> References: <20200207060718.22384-1-zhichao.gao@intel.com> In-Reply-To: <20200207060718.22384-1-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Zhichao: Two comments.=20 Thanks Liming > -----Original Message----- > From: Gao, Zhichao > Sent: Friday, February 7, 2020 2:07 PM > To: devel@edk2.groups.io > Cc: Matthew Carlson ; Kinney, Michael D ; Gao, Liming > Subject: [PATCH] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3= .0 type17 >=20 > From: Matthew Carlson >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2482 >=20 > Refer to DSP0134_3.3.0.pdf, there are two additional DWORD added > for type 17. One is "Extended Speed", the other is "Extended > Configured Memory Speed". The lack of these field may cause strange > error i some operating systems. Seemly, this is typo. It should be in some operating systems >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Signed-off-by: Zhichao Gao > --- > MdePkg/Include/IndustryStandard/SmBios.h | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/In= dustryStandard/SmBios.h > index 8b3c4d7ba9..b5401599db 100644 > --- a/MdePkg/Include/IndustryStandard/SmBios.h > +++ b/MdePkg/Include/IndustryStandard/SmBios.h > @@ -1,7 +1,7 @@ > /** @file > Industry Standard Definitions of SMBIOS Table Specification v3.3.0. >=20 > -Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.
Don't change copyright. Original patch doesn't touch it.=20 Thanks Liming > (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP
> (C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development LP
> SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -1843,6 +1843,11 @@ typedef struct { > UINT64 VolatileSize; > UINT64 CacheSize; > UINT64 LogicalSize; > + // > + // Add for smbios 3.3.0 > + // > + UINT32 ExtendedSpeed; > + UINT32 ExtendedConfiguredMemorySpee= d; > } SMBIOS_TABLE_TYPE17; >=20 > /// > -- > 2.16.2.windows.1