From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.42]) by mx.groups.io with SMTP id smtpd.web10.4206.1596829396756722428 for ; Fri, 07 Aug 2020 12:43:17 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=eir3kSRv; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.92.42, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XV0SiF+AEMlXvxQoMTAgiCfUFd+S27qHe0rwrVTQfIa4VhpeNJ5tvHQe+rVfQVijVWvabntCLnVJqrx//KoVDy06ZmZExdCZ+xeKOqHoSjUtvmVbJTu0nm3u6n8emWQfwOEkT1J0whwqgIuyWH4iiN5r/lW7p4HbrkLEAxnGZv/9h4qMlRgpbZm481xe06yrnlCrgpjMI2p4NXAh0dpQ29m+250ZY08QaXRKHXge4M9mlkH0mlTlrjOoq15ekryfs7OgkMjjuvsT7Pu0PfdAlxOkUaotPCWTymssYzYbcwhGptU+OB6wVQ55ygp5If/RGJdUNLzcwsjvQ4HhCA90vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eqxKEl1jkDkoQSy0tcmI5Mo0oyJK/DNNn+LhL12PTF0=; b=jNt6H7qBQggEGefP6f4ILHrKwB+m2dUUd/uSuP9VutEBBJu9+dpqB39cY3FE4P4XJuWX0Sjk+ZuQUk3BI3s0nE707BSg9QkwrNFtNDQFiyHCTEIvXcX+z2/mc47MoIBomYSMOzfhy+Rx7wkDiBd1Fv6JIeRVYzLiO3rVIOQZacScxY3pw/wnuHxYdax8yQnkzHJ0lJ4IvLb/CwKaSIkO1paxqNHjiHef5ZO46MtSUuxhENCfvA3tZyD+EnN2Pb0XASRiKmoDU0bALOa0sYk9p+kfFoHdMwXg+b2af819jsayHsBHPxso7pZ7PiOV+K5Q6t5sH67aqRCOs7CtLwyZTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eqxKEl1jkDkoQSy0tcmI5Mo0oyJK/DNNn+LhL12PTF0=; b=eir3kSRvhznnGHx3p1km2Sb+74NKG+ULOS7hxwvtThMNr7uZJzQ2FosBBBI+9hA2cU2r0w0kSP1uhHDh10k9y8pJoijkJ7jORX6LHbDj7zzfckei9j5QjoWcfjnEOnteVvMiiDiEI09Ddq29lLipi+fG73Q+lNBH8kZOS6zN/pE= Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=amd.com; Received: from CY4PR12MB1352.namprd12.prod.outlook.com (2603:10b6:903:3a::13) by CY4PR12MB1798.namprd12.prod.outlook.com (2603:10b6:903:11a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.19; Fri, 7 Aug 2020 19:43:14 +0000 Received: from CY4PR12MB1352.namprd12.prod.outlook.com ([fe80::9181:78bf:bf0:702b]) by CY4PR12MB1352.namprd12.prod.outlook.com ([fe80::9181:78bf:bf0:702b%5]) with mapi id 15.20.3239.024; Fri, 7 Aug 2020 19:43:14 +0000 From: "Lendacky, Thomas" To: devel@edk2.groups.io CC: Brijesh Singh , Ard Biesheuvel , Eric Dong , Jordan Justen , Laszlo Ersek , Liming Gao , Michael D Kinney , Ray Ni Subject: [PATCH v14 26/46] OvmfPkg/VmgExitLib: Add support for DR7 Read/Write NAE events Date: Fri, 7 Aug 2020 14:39:11 -0500 Message-ID: <340ece6d1a871e8e15a672cbdf56e87dc5d9f5af.1596829170.git.thomas.lendacky@amd.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: X-ClientProxiedBy: SN6PR16CA0048.namprd16.prod.outlook.com (2603:10b6:805:ca::25) To CY4PR12MB1352.namprd12.prod.outlook.com (2603:10b6:903:3a::13) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from tlendack-t1.amd.com (165.204.77.1) by SN6PR16CA0048.namprd16.prod.outlook.com (2603:10b6:805:ca::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.18 via Frontend Transport; Fri, 7 Aug 2020 19:43:13 +0000 X-Mailer: git-send-email 2.27.0 X-Originating-IP: [165.204.77.1] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0dd40a77-eed1-4dc6-ea14-08d83b0a1ffd X-MS-TrafficTypeDiagnostic: CY4PR12MB1798: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RYzQ2v2Sw89wQs4Es7o9opaE5r5Gfd2soEYSMG2joUtdJhrz7eJCfrQH8o27KS+qDKoX9T1v06XWoXTmvsu+BDumJifJsVFMNkpSHkDSEdXqgt9DqCEmtRdzS6988jrB3HXO1vUqQuithjJ9y3L8UCM2bL3JhF4bNLphrTZ6dEkZHAA+NQydsAzEx9CH1S3ZejDGjGwvCbiNwTmNqxVU6JcTkwPObVC1vTUgHBx9OplfRxSvHkDXmKIM4mM0F3Gs5MqCHaInT+DqlzTpeKn05ZSiv5NRpWHuukxVP7JQxHXihqLsLds+4BntKnb9wwqdzkYJQzZSN/otG3cBOp5K5Q3hzawBLUDEmIDku7l26IJVyzWLh+DSdWWnfR/j6nYAQrL+VjevHj6YldEevu5Yras4ozgwPvGLKqlcLpEjKhEKUfNGM5n5p8hpUVY7z3ELuqipoPo+0sXkT4dlbD4ZAw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR12MB1352.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(376002)(136003)(366004)(39860400002)(346002)(396003)(4326008)(66946007)(6486002)(2906002)(66556008)(66476007)(5660300002)(966005)(478600001)(8676002)(7696005)(26005)(8936002)(16526019)(186003)(86362001)(956004)(6916009)(36756003)(2616005)(52116002)(316002)(54906003)(83380400001)(136400200001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 7fMDTHO3ftzb7zCKtbSGBzzHTwSbLuqQ9m/5DkGnAQ/fPlBaj5BNngrI6qEdaBjpE/yodQH2CwS56R3AIsTkconjpt3dhY7Bs9ZCCv/8LSKjqNC/vS2BM1YB6nvkE3TNGGKYg7aX9uf8+xk2KAJ0xr/IgXVYdEVO1hEVGlgzswEvOfEVIZ9YM3XLth20D61MDm9S5SONCzav2580kbuOp00VVXgubAz5+KPSvjc1xqluzSyIwcegvmFK2/aeduV3EMR8MCUbPdfvM7d+Bh2SzKiPqPgFklQ6zi18EDFrxfqq/fwMKbjTHyBWbMFCO90PYQGAtKc/IDK9B8nNYgzNDy2HIHh3ArmkGrBrsh55KjZMvIVJrgQFI5xw7y/+0UTaCCZNIBPvei+dkskhxhpURn26upW9+dC8hpmuEjMUaNlpko2yYEEDdP5O64Yu3iWgnZL6w/vyAymTJlxj2jMKpNau8V90VdZvaObT2jdfQ8KgO8P4qOBKkl0TJnKQZRvGRUefWH+R/1O+LZPWgeiK/uIuWDL3csqJbUKlw68fqYDKyNYDjR+GlIzYkcgbeecKsccDhKfdUCEQx2OudoBcMR8LzznEGOg5ei/L9c2uEey6WKm0RSoTI3O2f5UsWPZY3tzIZ5De6RVKjPw2v3V/zw== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0dd40a77-eed1-4dc6-ea14-08d83b0a1ffd X-MS-Exchange-CrossTenant-AuthSource: CY4PR12MB1352.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2020 19:43:14.7700 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +v+bGvLBoPwaxQ1WrakQ0AP+SC6FtEv6+ANRfZGbwUrelLJz9z9Kr77agv0KE2MXQc3g0O1efyXnKMPf4TPDlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1798 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2198 Under SEV-ES, a DR7 read or write intercept generates a #VC exception. The #VC handler must provide special support to the guest for this. On a DR7 write, the #VC handler must cache the value and issue a VMGEXIT to notify the hypervisor of the write. However, the #VC handler must not actually set the value of the DR7 register. On a DR7 read, the #VC handler must return the cached value of the DR7 register to the guest. VMGEXIT is not invoked for a DR7 register read. The caching of the DR7 values will make use of the per-CPU data pages that are allocated along with the GHCB pages. The per-CPU page for a vCPU is the page that immediately follows the vCPU's GHCB page. Since each GHCB page is unique for a vCPU, the page that follows becomes unique for that vCPU. The SEC phase will reserves an area of memory for a single GHCB and per-CPU page for use by the BSP. After transitioning to the PEI phase, new GHCB and per-CPU pages are allocated for the BSP and all APs. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Acked-by: Laszlo Ersek Signed-off-by: Tom Lendacky --- OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 114 ++++++++++++++++++ 1 file changed, 114 insertions(+) diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c b/OvmfPkg/Librar= y/VmgExitLib/VmgExitVcHandler.c index e70e0ef82f68..c57c8c4ba203 100644 --- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c +++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c @@ -126,6 +126,14 @@ UINT64 SEV_ES_INSTRUCTION_DATA *InstructionData ); =20 +// +// Per-CPU data mapping structure +// +typedef struct { + BOOLEAN Dr7Cached; + UINT64 Dr7; +} SEV_ES_PER_CPU_DATA; + =20 /** Checks the GHCB to determine if the specified register has been marked v= alid. @@ -1480,6 +1488,104 @@ RdtscExit ( return 0; } =20 +/** + Handle a DR7 register write event. + + Use the VMGEXIT instruction to handle a DR7 write event. + + @param[in, out] Ghcb Pointer to the Guest-Hypervisor Communi= cation + Block + @param[in, out] Regs x64 processor context + @param[in] InstructionData Instruction parsing context + + @retval 0 Event handled successfully + @return New exception value to propagate + +**/ +STATIC +UINT64 +Dr7WriteExit ( + IN OUT GHCB *Ghcb, + IN OUT EFI_SYSTEM_CONTEXT_X64 *Regs, + IN SEV_ES_INSTRUCTION_DATA *InstructionData + ) +{ + SEV_ES_INSTRUCTION_OPCODE_EXT *Ext; + SEV_ES_PER_CPU_DATA *SevEsData; + UINT64 *Register; + UINT64 Status; + + Ext =3D &InstructionData->Ext; + SevEsData =3D (SEV_ES_PER_CPU_DATA *) (Ghcb + 1); + + DecodeModRm (Regs, InstructionData); + + // + // MOV DRn always treats MOD =3D=3D 3 no matter how encoded + // + Register =3D GetRegisterPointer (Regs, Ext->ModRm.Rm); + + // + // Using a value of 0 for ExitInfo1 means RAX holds the value + // + Ghcb->SaveArea.Rax =3D *Register; + GhcbSetRegValid (Ghcb, GhcbRax); + + Status =3D VmgExit (Ghcb, SVM_EXIT_DR7_WRITE, 0, 0); + if (Status !=3D 0) { + return Status; + } + + SevEsData->Dr7 =3D *Register; + SevEsData->Dr7Cached =3D TRUE; + + return 0; +} + +/** + Handle a DR7 register read event. + + Use the VMGEXIT instruction to handle a DR7 read event. + + @param[in, out] Ghcb Pointer to the Guest-Hypervisor Communi= cation + Block + @param[in, out] Regs x64 processor context + @param[in] InstructionData Instruction parsing context + + @retval 0 Event handled successfully + +**/ +STATIC +UINT64 +Dr7ReadExit ( + IN OUT GHCB *Ghcb, + IN OUT EFI_SYSTEM_CONTEXT_X64 *Regs, + IN SEV_ES_INSTRUCTION_DATA *InstructionData + ) +{ + SEV_ES_INSTRUCTION_OPCODE_EXT *Ext; + SEV_ES_PER_CPU_DATA *SevEsData; + UINT64 *Register; + + Ext =3D &InstructionData->Ext; + SevEsData =3D (SEV_ES_PER_CPU_DATA *) (Ghcb + 1); + + DecodeModRm (Regs, InstructionData); + + // + // MOV DRn always treats MOD =3D=3D 3 no matter how encoded + // + Register =3D GetRegisterPointer (Regs, Ext->ModRm.Rm); + + // + // If there is a cached valued for DR7, return that. Otherwise return th= e + // DR7 standard reset value of 0x400 (no debug breakpoints set). + // + *Register =3D (SevEsData->Dr7Cached) ? SevEsData->Dr7 : 0x400; + + return 0; +} + /** Handle a #VC exception. =20 @@ -1524,6 +1630,14 @@ VmgExitHandleVc ( =20 ExitCode =3D Regs->ExceptionData; switch (ExitCode) { + case SVM_EXIT_DR7_READ: + NaeExit =3D Dr7ReadExit; + break; + + case SVM_EXIT_DR7_WRITE: + NaeExit =3D Dr7WriteExit; + break; + case SVM_EXIT_RDTSC: NaeExit =3D RdtscExit; break; --=20 2.27.0