From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.67, mailfrom: philmd@redhat.com)
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67])
 by groups.io with SMTP; Wed, 24 Jul 2019 05:22:25 -0700
Received: by mail-wr1-f67.google.com with SMTP id n9so46847581wru.0
        for <devel@edk2.groups.io>; Wed, 24 Jul 2019 05:22:24 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id
         :date:user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=578cMBOWRiI8f3kWBLL/g+W8wH9QqQpHscxw7Js9VeA=;
        b=V74IdRBZRHXxrVfN1jvcs038MInWsDHCn7pEP1r7fqwnxRKKdzUD7vAKVFNXgKk2M9
         7XaLXmG2K8BLk9ZJVMJqmfAlNgTupcAwXyN/sAw7I6jtbA3mxv8W6OSRShvFDaUf9m94
         9wC5Pmc6kZmU7hXmrTaVBv0LWEXP4w3lR02L6qzWDmKc6OU3JcAMTfmx4YFefuilTwHD
         r1zBHldP2zueqbCYsx5kkjxivoRTN6k5xRxvjO3yXX0N/l9l5cRMfYY671PRTXa6UgeK
         iSCuE+2ew+WPDijPzTbAwckbadiMYjj3TUu9R8B3UhT0wQFrZW6PzNZ6KtEhmMTnNvzS
         0TQg==
X-Gm-Message-State: APjAAAWFE5Jhn2Mm0kcHl2sMFBItJCwyT84gOQYxHbJfhUBYIGxkT482
	fJzmhifTd4nP6Rh3XqlCr2mJvJo/fpg=
X-Google-Smtp-Source: APXvYqwfrWg1Vgzrnaoh/o0PxgLnJYNKcJprcaQ809OtWN6a1X9iVKn1HQ4vkrZuRGjP0ChKCUqEqQ==
X-Received: by 2002:adf:ec0c:: with SMTP id x12mr12613326wrn.342.1563970943491;
        Wed, 24 Jul 2019 05:22:23 -0700 (PDT)
Return-Path: <philmd@redhat.com>
Received: from [10.201.33.105] ([195.166.127.210])
        by smtp.gmail.com with ESMTPSA id j17sm69591025wrb.35.2019.07.24.05.22.22
        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);
        Wed, 24 Jul 2019 05:22:22 -0700 (PDT)
Subject: Re: [edk2-devel] [Patch] BaseTools: Sort file list in Makefile
To: devel@edk2.groups.io, bob.c.feng@intel.com
Cc: Liming Gao <liming.gao@intel.com>
References: <20190718073418.11832-1-bob.c.feng@intel.com>
From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= <philmd@redhat.com>
Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE;
 url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE
Message-ID: <3418cc0d-131b-037a-b706-3aa8f87aed8e@redhat.com>
Date: Wed, 24 Jul 2019 14:22:22 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20190718073418.11832-1-bob.c.feng@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 7/18/19 9:34 AM, Bob Feng wrote:
> This patch is going to sort the file list in generated
> Makefile. This change make the autogen makefile easy to
> compare.

Good idea.

> 
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

> ---
>  BaseTools/Source/Python/AutoGen/GenMake.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/Python/AutoGen/GenMake.py
> index 212ca0fa7f..031c0ae370 100644
> --- a/BaseTools/Source/Python/AutoGen/GenMake.py
> +++ b/BaseTools/Source/Python/AutoGen/GenMake.py
> @@ -1024,11 +1024,12 @@ cleanlib:
>                          self.FileListMacros[T.FileListMacro].append(NewFile)
>                      elif T.GenFileListMacro:
>                          self.FileListMacros[T.FileListMacro].append(NewFile)
>                      else:
>                          Deps.append(NewFile)
> -
> +                for key in self.FileListMacros:
> +                    self.FileListMacros[key].sort()
>                  # Use file list macro as dependency
>                  if T.GenFileListMacro:
>                      Deps.append("$(%s)" % T.FileListMacro)
>                      if Type in [TAB_OBJECT_FILE, TAB_STATIC_LIBRARY]:
>                          Deps.append("$(%s)" % T.ListFileMacro)
>