Re: [edk2-devel] [Patch 3/4] BaseTools/Scripts/PatchCheck: Error if no Cc tags are present

["Michael Kubacki" <mikuback@linux.microsoft.com>]

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 2/18/2024 3:59 PM, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4694
> 
> If no Cc tags are detected in a commit message, then generate an
> error. All patches sent for review are required to provide the set
> of maintainers and reviewers responsible for the directories/files
> modified. The set of maintainers and reviewers are documented in
> Maintainers.txt and can be retrieved using the script
> BaseTools/Scripts/GetMaintainer.py.
> 
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   BaseTools/Scripts/PatchCheck.py | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
> index 158a2b30a5ce..415198e3824e 100755
> --- a/BaseTools/Scripts/PatchCheck.py
> +++ b/BaseTools/Scripts/PatchCheck.py
> @@ -229,8 +229,10 @@ class CommitMessageCheck:
>           )
>   
>       def check_misc_signatures(self):
> -        for sig in self.sig_types:
> -            self.find_signatures(sig)
> +        for sigtype in self.sig_types:
> +            sigs = self.find_signatures(sigtype)
> +            if sigtype == 'Cc' and len(sigs) == 0:
> +                self.error('No Cc: tags for maintainers/reviewers found!')
>   
>       cve_re = re.compile('CVE-[0-9]{4}-[0-9]{5}[^0-9]')
>   


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115902): https://edk2.groups.io/g/devel/message/115902
Mute This Topic: https://groups.io/mt/104434584/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-