From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2110F740035 for ; Sat, 24 Feb 2024 01:26:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=SrWiVccFtyRrf66DIdoHD8XWGJrwpvTaLoiSeBpbXOQ=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708738013; v=1; b=G5Oj3QUMZc8ip80yqhkHL1mlgxXRwrGL8+AxatQw7xrGW88eoZhqSoSAmGeWl3+76cPyImO6 8d8Z0BZwCuxJ0fxvIN4yMiO+0NHGC31PNCSAwbo0+W5BKQuqphMppWxjso1GQPxnK24HfNakc84 g7vSeiTIGWdIHWjS6B5QZftU= X-Received: by 127.0.0.2 with SMTP id 9RAAYY7687511xlsOtI7uQco; Fri, 23 Feb 2024 17:26:53 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.11328.1708738013072820805 for ; Fri, 23 Feb 2024 17:26:53 -0800 X-Received: from [10.0.0.154] (unknown [20.39.63.0]) by linux.microsoft.com (Postfix) with ESMTPSA id 0391020B74C0; Fri, 23 Feb 2024 17:26:51 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0391020B74C0 Message-ID: <3418f167-6093-4e57-bc43-13a36795daae@linux.microsoft.com> Date: Fri, 23 Feb 2024 20:26:51 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [Patch 3/4] BaseTools/Scripts/PatchCheck: Error if no Cc tags are present To: Michael D Kinney , devel@edk2.groups.io Cc: Rebecca Cran , Liming Gao , Bob Feng , Yuwei Chen References: <20240218205951.497-1-michael.d.kinney@intel.com> <20240218205951.497-4-michael.d.kinney@intel.com> From: "Michael Kubacki" In-Reply-To: <20240218205951.497-4-michael.d.kinney@intel.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ll6Kcrp6iLzN93WupJcjwW0Jx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=G5Oj3QUM; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Michael Kubacki On 2/18/2024 3:59 PM, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4694 >=20 > If no Cc tags are detected in a commit message, then generate an > error. All patches sent for review are required to provide the set > of maintainers and reviewers responsible for the directories/files > modified. The set of maintainers and reviewers are documented in > Maintainers.txt and can be retrieved using the script > BaseTools/Scripts/GetMaintainer.py. >=20 > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > Cc: Michael Kubacki > Signed-off-by: Michael D Kinney > --- > BaseTools/Scripts/PatchCheck.py | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchChe= ck.py > index 158a2b30a5ce..415198e3824e 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -229,8 +229,10 @@ class CommitMessageCheck: > ) > =20 > def check_misc_signatures(self): > - for sig in self.sig_types: > - self.find_signatures(sig) > + for sigtype in self.sig_types: > + sigs =3D self.find_signatures(sigtype) > + if sigtype =3D=3D 'Cc' and len(sigs) =3D=3D 0: > + self.error('No Cc: tags for maintainers/reviewers found!= ') > =20 > cve_re =3D re.compile('CVE-[0-9]{4}-[0-9]{5}[^0-9]') > =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115902): https://edk2.groups.io/g/devel/message/115902 Mute This Topic: https://groups.io/mt/104434584/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-