[edk2-devel] [PATCH v2 1/1] edk2-test: uefi-sct Increase the waiting time in the SCT GetStatus_Func test

[edk2-devel] [PATCH v2 1/1] edk2-test: uefi-sct Increase the waiting time in the SCT GetStatus_Func test

[G Edhaya Chandran]

The current time delay in the SCT GetStatus_Func test is 5 milliseconds, which caused false positives with some platforms
This time delay is increased to 500 miliseconds with reference to
similar values in https://github.com/tianocore/edk2/blob/master/NetworkPkg/Include/Library/NetLib.h#L265

Signed-off-by: G Edhaya Chandran <edhaya.chandran@arm.com>
Co-authored-by: Sunny Wang <sunny.wang@arm.com>
---
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c
index 31c3590cd620..c077bfb29e52 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c
@@ -1870,7 +1870,7 @@ BBTestGetStatusFunctionTest (
     StatCode = gtBS->SetTimer (
                        TimeoutEvent,
                        TimerRelative,
-                       50000);  /* 5 milliseconds */
+                       5000000);  /* 500 milliseconds. This value is increased from old value 5 milliseconds to due false positives on some platforms */
     if (EFI_ERROR(StatCode)) {
       StandardLib->RecordAssertion (
                      StandardLib,
@@ -2196,7 +2196,7 @@ BBTestTransmitFunctionTest (
     StatCode = gtBS->SetTimer (
         TimeoutEvent,
         TimerRelative,
-        50000);  /* 5 milliseconds */
+        5000000);  /* 500 milliseconds. This value is increased from old value 5 milliseconds to due false positives on some platforms */
     if (EFI_ERROR(StatCode)) {
       StandardLib->RecordAssertion (
                      StandardLib,
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120655): https://edk2.groups.io/g/devel/message/120655
Mute This Topic: https://groups.io/mt/109160778/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 1/1] edk2-test: uefi-sct Increase the waiting time in the SCT GetStatus_Func test

[Sunny Wang]

Looks good. Thanks, Edhaya.
Reviewed-by: Sunny Wang <sunny.wang@arm.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of G Edhaya Chandran via groups.io
Sent: Tuesday, October 22, 2024 4:55 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH v2 1/1] edk2-test: uefi-sct Increase the waiting time in the SCT GetStatus_Func test

The current time delay in the SCT GetStatus_Func test is 5 milliseconds, which caused false positives with some platforms
This time delay is increased to 500 miliseconds with reference to
similar values in https://github.com/tianocore/edk2/blob/master/NetworkPkg/Include/Library/NetLib.h#L265

Signed-off-by: G Edhaya Chandran <edhaya.chandran@arm.com>
Co-authored-by: Sunny Wang <sunny.wang@arm.com>
---
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c
index 31c3590cd620..c077bfb29e52 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c
@@ -1870,7 +1870,7 @@ BBTestGetStatusFunctionTest (
     StatCode = gtBS->SetTimer (
                        TimeoutEvent,
                        TimerRelative,
-                       50000);  /* 5 milliseconds */
+                       5000000);  /* 500 milliseconds. This value is increased from old value 5 milliseconds to due false positives on some platforms */
     if (EFI_ERROR(StatCode)) {
       StandardLib->RecordAssertion (
                      StandardLib,
@@ -2196,7 +2196,7 @@ BBTestTransmitFunctionTest (
     StatCode = gtBS->SetTimer (
         TimeoutEvent,
         TimerRelative,
-        50000);  /* 5 milliseconds */
+        5000000);  /* 500 milliseconds. This value is increased from old value 5 milliseconds to due false positives on some platforms */
     if (EFI_ERROR(StatCode)) {
       StandardLib->RecordAssertion (
                      StandardLib,
--
2.25.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120655): https://edk2.groups.io/g/devel/message/120655
Mute This Topic: https://groups.io/mt/109160778/5985097
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [Sunny.Wang@arm.com]
-=-=-=-=-=-=


IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120663): https://edk2.groups.io/g/devel/message/120663
Mute This Topic: https://groups.io/mt/109160778/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 1/1] edk2-test: uefi-sct Increase the waiting time in the SCT GetStatus_Func test

[G Edhaya Chandran]

[-- Attachment #1: Type: text/plain, Size: 534 bytes --]

Thank you, Sunny for the review.
The solution is upstreamed through commit ID: https://github.com/tianocore/edk2-test/commit/8d01932fb1f253b5a28b21e278945557d1ebc409


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120754): https://edk2.groups.io/g/devel/message/120754
Mute This Topic: https://groups.io/mt/109160778/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1119 bytes --]