From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.zytor.com (terminus.zytor.com [65.50.211.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A279721D046D1 for ; Mon, 18 Sep 2017 06:50:00 -0700 (PDT) Received: from [10.26.0.110] (corporativo.static.gvt.net.br [177.135.97.54] (may be forged)) (authenticated bits=0) by mail.zytor.com (8.15.2/8.15.2) with ESMTPSA id v8IDomot002449 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Mon, 18 Sep 2017 06:50:50 -0700 To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Cc: "Kinney, Michael D" , "Gao, Liming" , Laszlo Ersek References: <37b896c68ff32f81de986b0997f309325bd6ca67.1505653040.git.pcacjr@zytor.com> <734D49CCEBEEF84792F5B80ED585239D5BA4413A@SHSMSX151.ccr.corp.intel.com> From: Paulo Alcantara Message-ID: <3481c2e6-0744-b50a-e287-30812a709949@zytor.com> Date: Mon, 18 Sep 2017 10:50:37 -0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BA4413A@SHSMSX151.ccr.corp.intel.com> Subject: Re: [PATCH v2 1/3] MdePkg: Add UDF volume structure definitions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 13:50:00 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ruiyu, On 9/17/2017 9:28 PM, Ni, Ruiyu wrote: > #define _GET_TAG_ID(_Pointer) \ > (((UDF_DESCRIPTOR_TAG *)(_Pointer))->TagIdentifier) > > #define IS_PD(_Pointer) \ > ((BOOLEAN)(_GET_TAG_ID (_Pointer) == 5)) > #define IS_LVD(_Pointer) \ > ((BOOLEAN)(_GET_TAG_ID (_Pointer) == 6)) > #define IS_TD(_Pointer) \ > ((BOOLEAN)(_GET_TAG_ID (_Pointer) == 8)) > > #define IS_AVDP(_Pointer) \ > ((BOOLEAN)(_GET_TAG_ID (_Pointer) == 2)) > > Paulo, > If you take a look at Pci22.h in the same directory, all macros are started > as "IS_PCI_". > How about changing the above IS_xxx to IS_UDF_xxx? Looks good to me. I'll change them. > Shall we change AVDP to AVD, following the same naming style as PD, LVD and TD? There is no "Anchor Volume Descriptor" but "Anchor Volume Descriptor Pointer", so we still need to keep 'P'. > How about changing _Pointer to _Tag or DescriptorTag? I will change it to _Tag. _Pointer is really a bad name. Thanks! :-) Paulo > > > Thanks/Ray > >> -----Original Message----- >> From: Paulo Alcantara [mailto:pcacjr@zytor.com] >> Sent: Sunday, September 17, 2017 9:13 PM >> To: edk2-devel@lists.01.org >> Cc: Paulo Alcantara ; Kinney, Michael D >> ; Gao, Liming ; Laszlo >> Ersek ; Ni, Ruiyu >> Subject: [PATCH v2 1/3] MdePkg: Add UDF volume structure definitions >> >> This patch adds a fewe more UDF structures in order to detect Logical >> Volume and Partition descriptors during Main Volume Descriptor Sequence >> in Partition driver. >> >> Cc: Michael D Kinney >> Cc: Liming Gao >> Cc: Laszlo Ersek >> Cc: Ruiyu Ni >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Paulo Alcantara >> --- >> MdePkg/Include/IndustryStandard/Udf.h | 63 ++++++++++++++++++++ >> 1 file changed, 63 insertions(+) >> >> diff --git a/MdePkg/Include/IndustryStandard/Udf.h >> b/MdePkg/Include/IndustryStandard/Udf.h >> index 0febb4bcda..6cc42f8543 100644 >> --- a/MdePkg/Include/IndustryStandard/Udf.h >> +++ b/MdePkg/Include/IndustryStandard/Udf.h >> @@ -27,9 +27,19 @@ >> #define _GET_TAG_ID(_Pointer) \ >> (((UDF_DESCRIPTOR_TAG *)(_Pointer))->TagIdentifier) >> >> +#define IS_PD(_Pointer) \ >> + ((BOOLEAN)(_GET_TAG_ID (_Pointer) == 5)) #define IS_LVD(_Pointer) \ >> + ((BOOLEAN)(_GET_TAG_ID (_Pointer) == 6)) #define IS_TD(_Pointer) \ >> + ((BOOLEAN)(_GET_TAG_ID (_Pointer) == 8)) >> + >> #define IS_AVDP(_Pointer) \ >> ((BOOLEAN)(_GET_TAG_ID (_Pointer) == 2)) >> >> +#define LV_UDF_REVISION(_Lv) \ >> + *(UINT16 *)(UINTN)(_Lv)->DomainIdentifier.IdentifierSuffix >> + >> #pragma pack(1) >> >> typedef struct { >> @@ -55,6 +65,59 @@ typedef struct { >> UINT8 Reserved[480]; >> } UDF_ANCHOR_VOLUME_DESCRIPTOR_POINTER; >> >> +typedef struct { >> + UINT8 CharacterSetType; >> + UINT8 CharacterSetInfo[63]; >> +} UDF_CHAR_SPEC; >> + >> +typedef struct { >> + UINT8 Flags; >> + UINT8 Identifier[23]; >> + UINT8 IdentifierSuffix[8]; >> +} UDF_ENTITY_ID; >> + >> +typedef struct { >> + UINT32 LogicalBlockNumber; >> + UINT16 PartitionReferenceNumber; >> +} UDF_LB_ADDR; >> + >> +typedef struct { >> + UINT32 ExtentLength; >> + UDF_LB_ADDR ExtentLocation; >> + UINT8 ImplementationUse[6]; >> +} UDF_LONG_ALLOCATION_DESCRIPTOR; >> + >> +typedef struct { >> + UDF_DESCRIPTOR_TAG DescriptorTag; >> + UINT32 VolumeDescriptorSequenceNumber; >> + UDF_CHAR_SPEC DescriptorCharacterSet; >> + UINT8 LogicalVolumeIdentifier[128]; >> + UINT32 LogicalBlockSize; >> + UDF_ENTITY_ID DomainIdentifier; >> + UDF_LONG_ALLOCATION_DESCRIPTOR LogicalVolumeContentsUse; >> + UINT32 MapTableLength; >> + UINT32 NumberOfPartitionMaps; >> + UDF_ENTITY_ID ImplementationIdentifier; >> + UINT8 ImplementationUse[128]; >> + UDF_EXTENT_AD IntegritySequenceExtent; >> + UINT8 PartitionMaps[6]; >> +} UDF_LOGICAL_VOLUME_DESCRIPTOR; >> + >> +typedef struct { >> + UDF_DESCRIPTOR_TAG DescriptorTag; >> + UINT32 VolumeDescriptorSequenceNumber; >> + UINT16 PartitionFlags; >> + UINT16 PartitionNumber; >> + UDF_ENTITY_ID PartitionContents; >> + UINT8 PartitionContentsUse[128]; >> + UINT32 AccessType; >> + UINT32 PartitionStartingLocation; >> + UINT32 PartitionLength; >> + UDF_ENTITY_ID ImplementationIdentifier; >> + UINT8 ImplementationUse[128]; >> + UINT8 Reserved[156]; >> +} UDF_PARTITION_DESCRIPTOR; >> + >> #pragma pack() >> >> #endif >> -- >> 2.11.0 > >