From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 12 Aug 2019 06:54:17 -0700 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 83D5D307C83E; Mon, 12 Aug 2019 13:54:17 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-247.ams2.redhat.com [10.36.116.247]) by smtp.corp.redhat.com (Postfix) with ESMTP id 48A7571C82; Mon, 12 Aug 2019 13:54:16 +0000 (UTC) Subject: Re: [PATCH v4 03/15] ArmVirtPkg/ArmVirtQemu.dsc: Add ResetUtilityLib to dsc file From: "Laszlo Ersek" To: Zhichao Gao , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Liming Gao References: <20190812030758.10324-1-zhichao.gao@intel.com> <20190812030758.10324-4-zhichao.gao@intel.com> <40748d61-a86a-a15f-0ac9-fa158d9db63a@redhat.com> Message-ID: <348ccc09-90e3-835a-165e-b2a47b72f6e2@redhat.com> Date: Mon, 12 Aug 2019 15:54:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <40748d61-a86a-a15f-0ac9-fa158d9db63a@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 12 Aug 2019 13:54:17 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/12/19 15:49, Laszlo Ersek wrote: > Hi, > > On 08/12/19 05:07, Zhichao Gao wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 >> >> ResetUtilityLib would be consumed by CapsuleRuntimeDxe. >> So add it for the platform dsc file. >> >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Leif Lindholm >> Cc: Liming Gao >> Signed-off-by: Zhichao Gao >> --- >> ArmVirtPkg/ArmVirtQemu.dsc | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc >> index 7ae6702ac1f0..4b8130f8e7fe 100644 >> --- a/ArmVirtPkg/ArmVirtQemu.dsc >> +++ b/ArmVirtPkg/ArmVirtQemu.dsc >> @@ -73,6 +73,7 @@ [LibraryClasses.common] >> PciPcdProducerLib|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf >> PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf >> + ResetUtilityLib|MdeModulePkg/Library/ResetUtilityLib/ResetUtilityLib.inf >> >> [LibraryClasses.common.PEIM] >> ArmVirtMemInfoLib|ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoPeiLib.inf >> > > thanks for updating your git config; these patches are a lot easier to read. > > Under ArmVirtPkg, there are three platform DSC files that include > CapsuleRuntimeDxe: > > - ArmVirtPkg/ArmVirtQemu.dsc > - ArmVirtPkg/ArmVirtQemuKernel.dsc > - ArmVirtPkg/ArmVirtXen.dsc > > In this v4 patch series, the last platform above doesn't seem to be updated. > > I suggest dropping patches #3 and #4 from the v4 series, and adding a > single patch that modifies "ArmVirtPkg/ArmVirt.dsc.inc". When you update "ArmVirtPkg/ArmVirt.dsc.inc", please add the new ResetUtilityLib class resolution just under the ResetSystemLib resolution. (That one is also part of [LibraryClasses.common].) Thanks Laszlo