From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: jiewen.yao@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Mon, 20 May 2019 09:30:43 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 May 2019 09:30:42 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 20 May 2019 09:30:42 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 20 May 2019 09:30:42 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 20 May 2019 09:30:42 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.249]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.70]) with mapi id 14.03.0415.000; Tue, 21 May 2019 00:30:39 +0800 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Desai, Imran" Subject: Re: [edk2-devel] [Enable measured boot with SM3 digest algorithm 0/4] Thread-Topic: [edk2-devel] [Enable measured boot with SM3 digest algorithm 0/4] Thread-Index: AQHVDPmOcv2IWSLyMUSf22u173eOJ6Z0OMQu Date: Mon, 20 May 2019 16:30:38 +0000 Message-ID: <349057BE-9766-48BB-B2E9-3D4F3C98B009@intel.com> References: <20190517183127.38140-1-imran.desai@intel.com> In-Reply-To: <20190517183127.38140-1-imran.desai@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: zh-CN Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable hi thanks for this contribution Besides the comment from Laszlo, would you please also share your unit tes= t result? What test you have done for this patch? thank you! Yao, Jiewen > =1B$B:_=1B(B 2019=1B$BG/=1B(B5=1B$B7n=1B(B17=1B$BF|!$2<8a=1B(B2:43=1B$B!= $=1B(BImran Desai =1B$B=20 > https://github.com/idesai/edk2/tree/enable_sm3_measured_boot >=20 > Support for SM3 digest algorithm is needed for TPM with SM3 PCR banks. T= his digest algorithm is part of the China Crypto algorithm suite. Support f= or these algorithms is needed to enable platforms for the PRC market. > This integration has dependency on the openssl_1_1_1b integration into e= dk2. >=20 > Imran Desai (4): > sm3_enabling: Augment crypt interface with calls into openssl to > calculate sm3 digest prior to exercising TPM2 calls for PCR extend > sm3-enabling: Add SM3 TCG algorithm registry value to the > PcdTpm2HashMask > sm3-enabling: Add SM3 guid reference in the TPM2 hash mask structure > in HashLibBaseCryptoRouterCommon.c > sm3-enabling: Add SM3 hashinstance library information to all OvmfPkg > and SecurityPkg >=20 > SecurityPkg/SecurityPkg.dec | 5 +- > OvmfPkg/OvmfPkgIa32.dsc | 2 + > OvmfPkg/OvmfPkgIa32X64.dsc | 2 + > OvmfPkg/OvmfPkgX64.dsc | 2 + > SecurityPkg/SecurityPkg.dsc | 3 + > .../HashInstanceLibSm3/HashInstanceLibSm3.inf | 46 ++++++ > MdePkg/Include/Protocol/Hash.h | 5 + > SecurityPkg/Include/Library/HashLib.h | 1 + > .../HashInstanceLibSm3/HashInstanceLibSm3.c | 155 ++++++++++++++++++ > .../HashLibBaseCryptoRouterCommon.c | 1 + > .../HashInstanceLibSm3/HashInstanceLibSm3.uni | 21 +++ > 11 files changed, 241 insertions(+), 2 deletions(-) > create mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLi= bSm3.inf > create mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLi= bSm3.c > create mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLi= bSm3.uni >=20 > --=20 > 2.17.0 >=20 >=20 >=20 >=20