Re: [edk2-devel] [PATCH V6 0/6] MPAM ACPI definitions and parser

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Rohit,

I think the pull request template must be used. In addition to the patch series description you have added, it has questions like if the change is a breaking change, how was the patch tested etc.
It would be good if you can update the pull request to use the PR template.

Regards,

Sami Mujawar

On 09/07/2024, 09:03, "Rohit Mathew" <Rohit.Mathew@arm.com <mailto:Rohit.Mathew@arm.com>> wrote:


Thank you, Sami, for letting me know. I had created a PR as well for making sure the CI goes through here - https://github.com/tianocore/edk2/pull/5888 <https://github.com/tianocore/edk2/pull/5888>


Could you please let me know if this would be sufficient?


Regards,
Rohit


> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>>
> Sent: Tuesday, July 9, 2024 8:16 AM
> To: Rohit Mathew <Rohit.Mathew@arm.com <mailto:Rohit.Mathew@arm.com>>; devel@edk2.groups.io <mailto:devel@edk2.groups.io>
> Cc: Michael D Kinney <michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>>; Liming Gao
> <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>>; Thomas Abraham
> <thomas.abraham@arm.com <mailto:thomas.abraham@arm.com>>; James Morse <James.Morse@arm.com <mailto:James.Morse@arm.com>>; Ray
> Ni <ray.ni@intel.com <mailto:ray.ni@intel.com>>; Zhichao Gao <zhichao.gao@intel.com <mailto:zhichao.gao@intel.com>>; nd
> <nd@arm.com <mailto:nd@arm.com>>
> Subject: Re: [PATCH V6 0/6] MPAM ACPI definitions and parser
> 
> Hi Rohit,
> 
> Edk2 has moved to a pull request model for code review and merge.
> See the latest guidelines at
> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development- <https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development->
> Process
> I replied to your previous patch series on the mailing list as it was sent before
> the new process was introduced.
> You will need to create a PR for the new series to progress.
> 
> Regards,
> 
> Sami Mujawar
> 
> On 08/07/2024, 22:35, "Rohit Mathew" <rohit.mathew@arm.com <mailto:rohit.mathew@arm.com>
> <mailto:rohit.mathew@arm.com <mailto:rohit.mathew@arm.com>>> wrote:
> 
> 
> This series adds the following
> 
> 
> * definitions corresponding to MPAM ACPI 2.0 specification.
> * MPAM parser An MPAM
> 
> 
> ACPI table formulated using the newly added MPAM ACPI definitions were
> validated on the linux kernel tree at [1]. The same table was parsed via
> acpiview using the newly added parser. Certain aspects of the MPAM ACPI
> specification are still not implemented by the kernel tree. These aspects were
> verified only using acpiview.
> 
> 
> Changes since V1:
> Addressed comments on MPAM ACPI definitions from Sami.
> V1 did not incorporate the parser. V2 has this implemented.
> 
> 
> Changes since V2:
> Addressed comments related to Interface/Link type defintions from Sami.
> 
> 
> Changes since V3:
> Addressed comments from Pierre
> 
> 
> Changes since V4:
> Addressed comments from Sami regarding Parser.
> 
> 
> Changes since V5:
> Addressed comments from Sami regarding Parser.
> 
> 
> Changes can be found at:
> https://github.com/rohit-arm/edk2/tree/mpam_acpi_v6 <https://github.com/rohit-arm/edk2/tree/mpam_acpi_v6>
> <https://github.com/rohit-arm/edk2/tree/mpam_acpi_v6> <https://github.com/rohit-arm/edk2/tree/mpam_acpi_v6&gt;>
> 
> 
> CI results/PR can be found at:
> https://github.com/tianocore/edk2/pull/5888 <https://github.com/tianocore/edk2/pull/5888>
> <https://github.com/tianocore/edk2/pull/5888> <https://github.com/tianocore/edk2/pull/5888&gt;>
> 
> 
> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/log/?h=mpam <https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/log/?h=mpam>
> /snapshot/v6.7-rc2
> <https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/log/?h=mpa <https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/log/?h=mpa>
> m/snapshot/v6.7-rc2>
> 
> 
> Rohit Mathew (6):
> MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification
> ShellPkg/AcpiView: Update field-validator prototype
> ShellPkg/AcpiView: Update print-formatter prototype
> ShellPkg: acpiview: Add routine to print 16 chars
> ShellPkg: acpiview: Add routines to print reserved fields
> ShellPkg/AcpiView: Add MPAM Parser
> 
> 
> MdePkg/Include/IndustryStandard/Acpi65.h | 7 +-
> MdePkg/Include/IndustryStandard/Mpam.h | 246 ++++
> ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 207 +++-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 113 +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Aest/AestParser.c |
> 36 +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c |
> 8 +- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Erst/ErstParser.c
> | 28 +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c |
> 24 +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c |
> 14 +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Hmat/HmatParser.c |
> 12 +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Hpet/HpetParser.c |
> 19 +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 32
> +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c |
> 24 +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mpam/MpamParser.
> c | 1241 ++++++++++++++++++++
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c |
> 56 +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c |
> 38 +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c |
> 14 +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Spcr/SpcrParser.c |
> 14 +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | 26
> +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Wsmt/WsmtParser.c
> | 20 +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommand
> Lib.c | 3 +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommand
> Lib.inf | 3 +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommand
> Lib.uni | 3 +-
> 23 files changed, 2040 insertions(+), 148 deletions(-) create mode 100644
> MdePkg/Include/IndustryStandard/Mpam.h
> create mode 100644
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mpam/MpamParser.
> c
> 
> 
> --
> 2.34.1
> 
> 
> 
> 
> 







-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119829): https://edk2.groups.io/g/devel/message/119829
Mute This Topic: https://groups.io/mt/107112126/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-