Re: [PATCH 1/1] Ext4Pkg: Fix bug in EXT4_HAS_GDT_CSUM

["Marvin Häuser" <mhaeuser@posteo.de>]

> On 5. Sep 2022, at 03:58, Pedro Falcato <pedro.falcato@gmail.com> wrote:
> 
> Catched when running clang-tidy on this code. Also tidies up some logic
> in BlockGroup.c

Caught

Reviewed-by: Marvin Häuser <mhaeuser@posteo.de>

> 
> Cc: Marvin Häuser <mhaeuser@posteo.de>
> Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
> ---
> Features/Ext4Pkg/Ext4Dxe/BlockGroup.c | 4 ++--
> Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h    | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Features/Ext4Pkg/Ext4Dxe/BlockGroup.c b/Features/Ext4Pkg/Ext4Dxe/BlockGroup.c
> index 572e8f60ab92..cba96cd95afc 100644
> --- a/Features/Ext4Pkg/Ext4Dxe/BlockGroup.c
> +++ b/Features/Ext4Pkg/Ext4Dxe/BlockGroup.c
> @@ -218,9 +218,9 @@ Ext4CalculateBlockGroupDescChecksum (
>   IN UINT32                       BlockGroupNum
>   )
> {
> -  if ((Partition->FeaturesRoCompat & EXT4_FEATURE_RO_COMPAT_METADATA_CSUM) != 0) {
> +  if (EXT4_HAS_METADATA_CSUM (Partition)) {
>     return Ext4CalculateBlockGroupDescChecksumMetadataCsum (Partition, BlockGroupDesc, BlockGroupNum);
> -  } else if ((Partition->FeaturesRoCompat & EXT4_FEATURE_RO_COMPAT_GDT_CSUM) != 0) {
> +  } else if (EXT4_HAS_GDT_CSUM (Partition)) {
>     return Ext4CalculateBlockGroupDescChecksumGdtCsum (Partition, BlockGroupDesc, BlockGroupNum);
>   }
> 
> diff --git a/Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h b/Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h
> index b446488b2112..81e59a4babc9 100644
> --- a/Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h
> +++ b/Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h
> @@ -1095,7 +1095,7 @@ Ext4CalculateBlockGroupDescChecksum (
>    @return TRUE if the gdt_csum is supported, else FALSE.
> **/
> #define EXT4_HAS_GDT_CSUM(Partition)                                           \
> -  EXT4_HAS_RO_COMPAT(Partition, EXT4_FEATURE_RO_COMPAT_METADATA_CSUM)
> +  EXT4_HAS_RO_COMPAT(Partition, EXT4_FEATURE_RO_COMPAT_GDT_CSUM)
> 
> /**
>    Retrieves the volume name.
> -- 
> 2.37.3
>