From: "Zeng, Star" <star.zeng@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, edk2-devel@lists.01.org
Cc: Eric Dong <eric.dong@intel.com>,
Liming Gao <liming.gao@intel.com>,
Dandan Bi <dandan.bi@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Michael D Kinney <michael.d.kinney@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
star.zeng@intel.com
Subject: Re: [PATCH 3/6] MdePkg/UefiLib: introduce EfiAllocatePeiAccessiblePages routine
Date: Wed, 23 May 2018 09:59:17 +0800 [thread overview]
Message-ID: <34a78e76-107f-da2d-38f1-b96d1d559c6f@intel.com> (raw)
In-Reply-To: <20180522140850.30369-4-ard.biesheuvel@linaro.org>
On 2018/5/22 22:08, Ard Biesheuvel wrote:
> Add a routine to UefiLib that abstracts the allocation of memory that
> should be accessible by PEI after a warm reboot. We will use it to
Glad to see this patch series.
It is the case "PEI for S3", but not "PEI after a warm reboot".
Thanks,
Star
> replace open coded implementations that limit the address to < 4 GB,
> which may not be possible on non-Intel systems that have no 32-bit
> addressable memory at all.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> MdePkg/Include/Library/UefiLib.h | 23 ++++++++++
> MdePkg/Library/UefiLib/UefiLib.c | 48 ++++++++++++++++++++
> 2 files changed, 71 insertions(+)
>
> diff --git a/MdePkg/Include/Library/UefiLib.h b/MdePkg/Include/Library/UefiLib.h
> index 256498e3fd8d..8fa077af41e0 100644
> --- a/MdePkg/Include/Library/UefiLib.h
> +++ b/MdePkg/Include/Library/UefiLib.h
> @@ -1520,4 +1520,27 @@ EfiLocateProtocolBuffer (
> OUT UINTN *NoProtocols,
> OUT VOID ***Buffer
> );
> +
> +/**
> + Allocates one or more 4KB pages of a given type from a memory region that is
> + accessible to PEI.
> +
> + Allocates the number of 4KB pages of type 'MemoryType' and returns a
> + pointer to the allocated buffer. The buffer returned is aligned on a 4KB
> + boundary. If Pages is 0, then NULL is returned. If there is not enough
> + memory remaining to satisfy the request, then NULL is returned.
> +
> + @param[in] MemoryType The memory type to allocate
> + @param[in] Pages The number of 4 KB pages to allocate.
> +
> + @return A pointer to the allocated buffer or NULL if allocation fails.
> +
> +**/
> +VOID *
> +EFIAPI
> +EfiAllocatePeiAccessiblePages (
> + IN EFI_MEMORY_TYPE MemoryType,
> + IN UINTN Pages
> + );
> +
> #endif
> diff --git a/MdePkg/Library/UefiLib/UefiLib.c b/MdePkg/Library/UefiLib/UefiLib.c
> index ba449a1c34ce..3a9d75149dd7 100644
> --- a/MdePkg/Library/UefiLib/UefiLib.c
> +++ b/MdePkg/Library/UefiLib/UefiLib.c
> @@ -1715,3 +1715,51 @@ EfiLocateProtocolBuffer (
>
> return EFI_SUCCESS;
> }
> +
> +/**
> + Allocates one or more 4KB pages of a given type from a memory region that is
> + accessible to PEI.
> +
> + Allocates the number of 4KB pages of type 'MemoryType' and returns a
> + pointer to the allocated buffer. The buffer returned is aligned on a 4KB
> + boundary. If Pages is 0, then NULL is returned. If there is not enough
> + memory remaining to satisfy the request, then NULL is returned.
> +
> + @param[in] MemoryType The memory type to allocate
> + @param[in] Pages The number of 4 KB pages to allocate.
> +
> + @return A pointer to the allocated buffer or NULL if allocation fails.
> +
> +**/
> +VOID *
> +EFIAPI
> +EfiAllocatePeiAccessiblePages (
> + IN EFI_MEMORY_TYPE MemoryType,
> + IN UINTN Pages
> + )
> +{
> + EFI_STATUS Status;
> + EFI_PHYSICAL_ADDRESS Memory;
> + EFI_ALLOCATE_TYPE AllocType;
> +
> + if (Pages == 0) {
> + return NULL;
> + }
> +
> +#ifdef MDE_CPU_X64
> + //
> + // On X64 systems, a X64 build of DXE may be combined with a 32-bit build of
> + // PEI, and so we need to allocate below 4 GB to ensure that the allocation
> + // is accessible by PEI.
> + //
> + AllocType = AllocateMaxAddress;
> + Memory = MAX_UINT32;
> +#else
> + AllocType = AllocateAnyPages;
> +#endif
> + Status = gBS->AllocatePages (AllocType, MemoryType, Pages, &Memory);
> + if (EFI_ERROR (Status)) {
> + return NULL;
> + }
> + return (VOID *)(UINTN)Memory;
> +}
>
next prev parent reply other threads:[~2018-05-23 1:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 14:08 [PATCH 0/6] Abstract allocation of PEI accessible memory Ard Biesheuvel
2018-05-22 14:08 ` [PATCH 1/6] OvmfPkg/PlatformBootManagerLib: add missing report status code call Ard Biesheuvel
2018-05-22 18:58 ` Laszlo Ersek
2018-05-22 14:08 ` [PATCH 2/6] ArmVirtPkg/PlatformBootManagerLib: " Ard Biesheuvel
2018-05-22 18:58 ` Laszlo Ersek
2018-05-22 14:08 ` [PATCH 3/6] MdePkg/UefiLib: introduce EfiAllocatePeiAccessiblePages routine Ard Biesheuvel
2018-05-22 17:40 ` Kinney, Michael D
2018-05-22 17:47 ` Ard Biesheuvel
2018-05-22 19:11 ` Laszlo Ersek
2018-05-23 2:02 ` Zeng, Star
2018-05-23 1:59 ` Zeng, Star [this message]
2018-05-22 14:08 ` [PATCH 4/6] IntelFrameworkPkg/FrameworkUefiLib: add " Ard Biesheuvel
2018-05-22 14:08 ` [PATCH 5/6] MdeModulePkg/DxeCorePerformanceLib: use EfiAllocatePeiAccessiblePages Ard Biesheuvel
2018-05-22 14:08 ` [PATCH 6/6] MdeModulePkg/FirmwarePerformanceDataTableDxe: " Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34a78e76-107f-da2d-38f1-b96d1d559c6f@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox