From: "Kun Qin" <kuqin12@gmail.com>
To: Rebecca Cran <rebecca@quicinc.com>,
devel@edk2.groups.io, quic_rcran@quicinc.com,
Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Sami Mujawar <sami.mujawar@arm.com>,
Jian J Wang <jian.j.wang@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH 1/2] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls
Date: Tue, 29 Nov 2022 16:15:03 -0800 [thread overview]
Message-ID: <34a7918e-02e5-b3f1-9346-8d35cdec825d@gmail.com> (raw)
In-Reply-To: <2e583842-93f5-c6c9-985b-de700e868391@quicinc.com>
Thanks for the update, Rebecca. I will also keep an eye on the cache
issue when I have a chance to run this on FVP models.
Regards,
Kun
On 11/28/2022 4:04 PM, Rebecca Cran wrote:
> On 11/28/22 15:59, Kun Qin wrote:
>> Hi Rebecca/Ard,
>>
>> I was trying to reach out regarding the original patches earlier (see
>> below) but it might fell off your stacks
>> due to high traffic on the mailing list. Could you please kindly
>> review the questions when you have a chance?
>>
>> In addition, I found another edge case of the MP service: when the AP
>> routine hits a timeout, the metadata
>> will be left in the unfinished states. If the AP routine eventually
>> completes and return, this AP will stay in "finished"
>> but never become "ready" during this boot. I tried to add below
>> change, which seems to work. But please let me
>> know if you have other concerns:
>> https://github.com/kuqin12/mu_silicon_arm_tiano/commit/c76072b37018276f2fec2582d0c540be5b40d0f2
>>
>
> Thanks, I'll take a look and integrate the fix into the next revision
> of the patch series.
>
>>
>> Lastly, do you plan to merge these patches in the near future? This
>> will be a great add-on for ARM platforms.
>
> The issue that's currently preventing them from being merged is a
> failure I noticed on the Neoverse N2 FVP: for some reason despite
> enabling the MMU and caches, manual cache flushes are still required
> for the data to be seen between CPUs. I don't know if that's a bug in
> the code or in the FVP model.
>
next prev parent reply other threads:[~2022-11-30 0:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 15:59 [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64 Rebecca Cran
2022-08-29 15:59 ` [PATCH 1/2] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls Rebecca Cran
2022-09-29 18:45 ` [edk2-devel] " Kun Qin
2022-11-28 22:59 ` Kun Qin
2022-11-29 0:04 ` Rebecca Cran
2022-11-30 0:15 ` Kun Qin [this message]
2022-11-28 23:59 ` Rebecca Cran
2022-08-29 15:59 ` [PATCH 2/2] MdeModulePkg: Add new Application/MpServicesTest application Rebecca Cran
2022-08-30 16:29 ` Rebecca Cran
2022-09-05 10:57 ` [edk2-devel] [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64 Ard Biesheuvel
2022-09-05 15:51 ` Rebecca Cran
2022-09-05 15:55 ` Ard Biesheuvel
2022-09-06 16:53 ` Ard Biesheuvel
2022-09-06 17:01 ` Rebecca Cran
2022-09-06 17:53 ` Ard Biesheuvel
2022-09-06 18:17 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34a7918e-02e5-b3f1-9346-8d35cdec825d@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox