From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mx.groups.io with SMTP id smtpd.web11.1111.1669767305272566083 for ; Tue, 29 Nov 2022 16:15:05 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=BZ/8GNty; spf=pass (domain: gmail.com, ip: 209.85.210.172, mailfrom: kuqin12@gmail.com) Received: by mail-pf1-f172.google.com with SMTP id c15so6000549pfb.13 for ; Tue, 29 Nov 2022 16:15:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BFDDSzpDW1351scB8qOmyMyrsA3LBiDzw/e9XvQiwjo=; b=BZ/8GNtypXgSlqmkjOndEyXjxHwk9H5iQTSjt1EG6unW/sHdqNXWqrkmAXijAbIyLO 7bAlWEhuO1qr7gByKANa4XmlbrcxypnHkr2EMlpPeMtySPFrCJqUPWkJAqjYqWiKwxR0 Ck/5F93JcrvtAEc7ZtEMKF3/7a6emYEfXdbzOuszIaZqcdR3GPxKV1Ghg4FNj6bDuV+R NpjZdue8eEVQVwk8qYjvNKhK5cKTEErQC3l8pfevnkW2lCPAK+lMn6NTMZtJJ2exY+MU GNge5C0ZLs2SHbmqh+mlg6vR8W0dXGXwsxAxy/TljgV15qAs1n+lHUIc2IB3NAxSemuf HBZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BFDDSzpDW1351scB8qOmyMyrsA3LBiDzw/e9XvQiwjo=; b=YIwCAHsvgWEjisQYe5qRWWGaUZGAK7UryHt2buwWL4Ctpamw+3lFEo1O0wSiIA+a+s iCL+Lj1ZoZ7myQkKF9HK3bAwLYduZGzAT+DDvv45LwC3hT/hXj50vQmVPfFGS5wnNBqi NF4XMLpNuh5SJO54LUlrr5J9SNgp8ZqhzPk+eY1oAw66BdbpA9UnkD0q1I8qweCRPHDj K9YJUvRx6Efj4GaMcu9uYB0c2o1GQ4na24d/6LBgNaRPXee912r616ny7jE8Zjp+FDRZ G6CbO6avmVX1AeumPSeRZ7f+Al3DEjVrAfWujhJkVR3StmP7OpWuN/sPCuRggRhNfRos B1VA== X-Gm-Message-State: ANoB5plgR9LZdr8RVpCh0eJFFwa0TOnbT4dDAa6bb5XPcLU89GfKOaqR lK0JGAiyAtNDjdwdvYNuqj0= X-Google-Smtp-Source: AA0mqf5/XX7onci4QkpEifcnRey4KM2OAobs5Td148Dith19MVziS6WBmMLcEeK/t3JbseOA1fXt7w== X-Received: by 2002:a05:6a00:4509:b0:562:641b:c1b2 with SMTP id cw9-20020a056a00450900b00562641bc1b2mr43779157pfb.8.1669767304605; Tue, 29 Nov 2022 16:15:04 -0800 (PST) Return-Path: Received: from ?IPV6:2001:4898:d8:33:c04a:e3de:392c:efec? ([2001:4898:80e8:1:406c:e3de:392c:efec]) by smtp.gmail.com with ESMTPSA id w63-20020a626242000000b005624e2e0508sm44608pfb.207.2022.11.29.16.15.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 16:15:04 -0800 (PST) Message-ID: <34a7918e-02e5-b3f1-9346-8d35cdec825d@gmail.com> Date: Tue, 29 Nov 2022 16:15:03 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [edk2-devel] [PATCH 1/2] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls To: Rebecca Cran , devel@edk2.groups.io, quic_rcran@quicinc.com, Leif Lindholm , Ard Biesheuvel , Sami Mujawar , Jian J Wang , Liming Gao References: <20220829155955.3767-1-rebecca@quicinc.com> <20220829155955.3767-2-rebecca@quicinc.com> <25c22db8-2974-44c3-9482-3972af6cd08c@gmail.com> <2e583842-93f5-c6c9-985b-de700e868391@quicinc.com> From: "Kun Qin" In-Reply-To: <2e583842-93f5-c6c9-985b-de700e868391@quicinc.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for the update, Rebecca. I will also keep an eye on the cache issue when I have a chance to run this on FVP models. Regards, Kun On 11/28/2022 4:04 PM, Rebecca Cran wrote: > On 11/28/22 15:59, Kun Qin wrote: >> Hi Rebecca/Ard, >> >> I was trying to reach out regarding the original patches earlier (see >> below) but it might fell off your stacks >> due to high traffic on the mailing list. Could you please kindly >> review the questions when you have a chance? >> >> In addition, I found another edge case of the MP service: when the AP >> routine hits a timeout, the metadata >> will be left in the unfinished states. If the AP routine eventually >> completes and return, this AP will stay in "finished" >> but never become "ready" during this boot. I tried to add below >> change, which seems to work. But please let me >> know if you have other concerns: >> https://github.com/kuqin12/mu_silicon_arm_tiano/commit/c76072b37018276f2fec2582d0c540be5b40d0f2 >> > > Thanks, I'll take a look and integrate the fix into the next revision > of the patch series. > >> >> Lastly, do you plan to merge these patches in the near future? This >> will be a great add-on for ARM platforms. > > The issue that's currently preventing them from being merged is a > failure I noticed on the Neoverse N2 FVP: for some reason despite > enabling the MMU and caches, manual cache flushes are still required > for the data to be seen between CPUs. I don't know if that's a bug in > the code or in the FVP model. >