Re: [edk2-devel] [PATCH v2 0/2] BZ 4249: Fix FatPkg/EnhancedFatDxe issues pointed by Coverity

["Oliver Smith-Denny via groups.io" <osde=linux.microsoft.com@groups.io>]

Hi Ranbir and Veeresh,

On 11/6/2023 10:28 PM, Ranbir Singh wrote:
> v1 -> v2:
>    - Rebased to latest master HEAD
> 
> Ranbir Singh (2):
>    FatPkg/EnhancedFatDxe: Fix SIGN_EXTENSION Coverity issues
>    FatPkg/EnhancedFatDxe: Fix OVERFLOW_BEFORE_WIDEN Coverity issue
> 
>   FatPkg/EnhancedFatDxe/DirectoryManage.c | 4 ++--
>   FatPkg/EnhancedFatDxe/DiskCache.c       | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 

I see that this patch was never merged (I don't see any response to
Laszlo's comments, which I agree with) but the GH issue is open:
https://github.com/tianocore/edk2/issues/10318.

If you want to put up a PR to address this issue, taking into account
Laszlo's review, please do so.

Thanks,
Oliver


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120948): https://edk2.groups.io/g/devel/message/120948
Mute This Topic: https://groups.io/mt/102438361/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-