From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4901ED807AB for ; Thu, 2 Jan 2025 21:38:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2vDHderaOs9P5gQT/TvSmrKONZe7ytpzhEodOSHEavc=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240830; t=1735853919; v=1; x=1736113118; b=uWx/MaxsApadCUQbUV0lxoYb1NUCfS2/m53WB4Dixj2wSFRCT7LT83OwcKaixAEClUEUm+qA K4YLHxFyh6hkV2wUkhbRD2VWzUkO36jP9mrQU3i6WYJlb7Alta8SYmV/lHUpmmonnaiOq9Rvtfk caVB14OhFwnkoyhmmrtN+HRUXI8Lx45igSQ4Q8egtx7rp22N4cKhJ8C9Sad9K3gGKKAyMYwVuVu IiUhaeQIGuC9P6pFFxMBlcjmvuFxF58Xs6Mmrq7BhHJNHSjP9x1gcE0z7GBQbp/e9jdVaOhnbJg BgvPhR4VsS9pa8FxyQaR1ZqBkrjSZEc6ZowDXmW5A6okQ== X-Received: by 127.0.0.2 with SMTP id 1bTUYY7687511xKIlz01UeGT; Thu, 02 Jan 2025 13:38:38 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.18274.1735853913040898254 for ; Thu, 02 Jan 2025 13:38:33 -0800 X-Received: from [10.137.194.171] (unknown [131.107.1.235]) by linux.microsoft.com (Postfix) with ESMTPSA id 0B1F02041A87; Thu, 2 Jan 2025 13:38:32 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0B1F02041A87 Message-ID: <34f547bd-a5c0-40ac-b2b8-ef6e95301368@linux.microsoft.com> Date: Thu, 2 Jan 2025 13:38:31 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 0/2] BZ 4249: Fix FatPkg/EnhancedFatDxe issues pointed by Coverity To: devel@edk2.groups.io, rsingh@ventanamicro.com, veeresh.sangolli@dellteam.com, Ranbir.Singh3@Dell.com References: <20231107062842.116670-1-rsingh@ventanamicro.com> From: "Oliver Smith-Denny via groups.io" In-Reply-To: <20231107062842.116670-1-rsingh@ventanamicro.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 02 Jan 2025 13:38:33 -0800 Resent-From: osde@linux.microsoft.com Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: akazWt8w3z3jT49X4FkYCfkgx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b="uWx/Maxs"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io Hi Ranbir and Veeresh, On 11/6/2023 10:28 PM, Ranbir Singh wrote: > v1 -> v2: > - Rebased to latest master HEAD >=20 > Ranbir Singh (2): > FatPkg/EnhancedFatDxe: Fix SIGN_EXTENSION Coverity issues > FatPkg/EnhancedFatDxe: Fix OVERFLOW_BEFORE_WIDEN Coverity issue >=20 > FatPkg/EnhancedFatDxe/DirectoryManage.c | 4 ++-- > FatPkg/EnhancedFatDxe/DiskCache.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 I see that this patch was never merged (I don't see any response to Laszlo's comments, which I agree with) but the GH issue is open: https://github.com/tianocore/edk2/issues/10318. If you want to put up a PR to address this issue, taking into account Laszlo's review, please do so. Thanks, Oliver -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120948): https://edk2.groups.io/g/devel/message/120948 Mute This Topic: https://groups.io/mt/102438361/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-