From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id F1282AC14C8 for ; Tue, 9 Jul 2024 13:12:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=V7p2R+UlZc1u/Qfpn4a5hmRir4H6BHpe8q75JgifakE=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20240206; t=1720530764; v=1; b=FWv4ot6XrWPESxUH/eAwqOGb46MMGdJTtWD7WNZlNX5yfCZpRHF1HPl0RB4LQWyi0h3nEFpn 3KYA8sn3WVMbskbe2UyWiaRHfCd6YWZwdpoQDDh9HZcQ4i2BxusLxNy+lNnurdod4y8d0c2OZz7 tcCZ2z/jvusRuBfkgHkYLjC+DtPLqOhadOn5icXjQncTtpIfzgZvNlnWTg4KY0CQ52Xk8lGXTv2 +4gVk4aThNOQ02TljDDeutK8Ur4eSPfZMNzCm+GllfcsZchiUwYcEkhwUYg+8Wr3w4OEw9CIH45 96DokzMs71/mOuKaw2x7lgDulDg4pRiJAwiqILbWWqzKA== X-Received: by 127.0.0.2 with SMTP id dki5YY7687511xaVnhz8lOTl; Tue, 09 Jul 2024 06:12:43 -0700 X-Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by mx.groups.io with SMTP id smtpd.web10.12702.1720530762772023107 for ; Tue, 09 Jul 2024 06:12:43 -0700 X-Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-58d24201934so8069570a12.0 for ; Tue, 09 Jul 2024 06:12:42 -0700 (PDT) X-Gm-Message-State: Y8VF5ZXbHHcGqJqKyQjT83Syx7686176AA= X-Google-Smtp-Source: AGHT+IFqp1G8cO3NtFjR1K8FQvwzZH0I5bF/IxeN+Q1sFiaz4kI6B+qtWK7P7sZt8fsoLj9ZkndWmQ== X-Received: by 2002:a05:6402:502:b0:57d:3df:ba2d with SMTP id 4fb4d7f45d1cf-594dc4ae5d2mr1736315a12.2.1720530759552; Tue, 09 Jul 2024 06:12:39 -0700 (PDT) X-Received: from puchatek.local (83.8.74.165.ipv4.supernova.orange.pl. [83.8.74.165]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-594bc4e8173sm1058216a12.54.2024.07.09.06.12.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jul 2024 06:12:39 -0700 (PDT) From: "Marcin Juszkiewicz" To: devel@edk2.groups.io, quic_llindhol@quicinc.com Cc: devel@edk2.groups.io, Xiong Yining , Ard Biesheuvel , Graeme Gregory , Chen Baozi Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 5/5] SbsaQemu: introduce helper in PPTT generation Date: Tue, 09 Jul 2024 15:12:37 +0200 Message-ID: <3514462.yRhR9qJLr4@puchatek.local> In-Reply-To: References: <20240709-acpi65-v3-0-ee93ba536fcf@linaro.org> <20240709-acpi65-v3-5-ee93ba536fcf@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 09 Jul 2024 06:12:43 -0700 Resent-From: marcin.juszkiewicz@linaro.org Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=FWv4ot6X; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Dnia wtorek, 9 lipca 2024 15:00:12 CEST Leif Lindholm via groups.io pisze: > On Tue, Jul 09, 2024 at 12:47:10 +0200, Marcin Juszkiewicz wrote: > > Function AddPpttTable() adding PPTT got too long. This change moves par= t > > of it into helper function AddCoresToPpttTable() which takes care of > > generating entries for Core and below (Cache, Thread). > >=20 > > Signed-off-by: Marcin Juszkiewicz > > --- > >=20 > > .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 237 > > +++++++++++--------- 1 file changed, 133 insertions(+), 104 deletions(= -) > >=20 > > diff --git > > a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c > > b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c index > > a7a9664abdcb..a4b2ee2fdcb0 100644 > > --- a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c > > +++ b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c > > @@ -29,6 +29,9 @@ > >=20 > > static UINTN GicItsBase; > >=20 > > +static UINTN CpuId; > > +static UINTN CacheId; > > + >=20 > static variables are supposed to have g (global) or m (module) prefix. > This is local, so m. > (Yes, that means I missed that when reviewing the GitIts bits.) >=20 > Also, why are these in a #pragma pack(1) block? Added right after GicItsBase. Moved out of block. > > #pragma pack () =20 > STATIC >=20 > > +UINT32 > > +AddCoresToPpttTable ( > > + UINT8 *New, > > + UINT32 ClusterIndex, > > + CpuTopology CpuTopo > > + ) done > > - ClusterIndex =3D CoreIndex; > > + CoresPartSize =3D AddCoresToPpttTable (New, ClusterIndex, CpuTop= o); > > + ClusterIndex +=3D CoresPartSize; >=20 > This sounds like ClisterIndex is no longer an Index after this patch. > Should it be renamed? It is still an Index. CoresPartSize is a size taken by Core/Cache/Thread pa= rt=20 of this Cluster. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119843): https://edk2.groups.io/g/devel/message/119843 Mute This Topic: https://groups.io/mt/107120147/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-